octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2025-01-08 17:24:08 +00:00
Code Issues Packages Projects Releases Wiki Activity
7df75e681d
syncthing/lib/model
History
Gusted 356c5055ad
lib/sha256: Remove it (#9643) 
### Purpose

Remove the `lib/sha256` package, because it's no longer necessary. Go's
standard library now has the same performance and is on par with
`sha256-simd` since [Since Go
1.21](1a64574f42).
Therefore using `sha256-simd` has no benefits anymore.

ARM already has optimized sha256 assembly code since
7b8a7f8272,
`sha256-simd` published their results before that optimized assembly was
implemented,
f941fedda8.
The assembly looks very similar and the benchmarks in the Go commit
match that of `sha256-simd`.

This patch removes all of the related code of `lib/sha256` and makes
`crypto/sha256` the 'default'.

Benchmark of `sha256-simd` and `crypto/sha256`:
<details>

```
cpu: AMD Ryzen 5 3600X 6-Core Processor
                │  simd.txt   │               go.txt                │
                │   sec/op    │    sec/op     vs base               │
Hash/8Bytes-12    63.25n ± 1%    73.38n ± 1%  +16.02% (p=0.002 n=6)
Hash/64Bytes-12   98.73n ± 1%   105.30n ± 1%   +6.65% (p=0.002 n=6)
Hash/1K-12        567.2n ± 1%    572.8n ± 1%   +0.99% (p=0.002 n=6)
Hash/8K-12        4.062µ ± 1%    4.062µ ± 1%        ~ (p=0.396 n=6)
Hash/1M-12        512.1µ ± 0%    510.6µ ± 1%        ~ (p=0.485 n=6)
Hash/5M-12        2.556m ± 1%    2.564m ± 0%        ~ (p=0.093 n=6)
Hash/10M-12       5.112m ± 0%    5.127m ± 0%        ~ (p=0.093 n=6)
geomean           13.82µ         14.27µ        +3.28%

                │   simd.txt   │               go.txt                │
                │     B/s      │     B/s       vs base               │
Hash/8Bytes-12    120.6Mi ± 1%   104.0Mi ± 1%  -13.81% (p=0.002 n=6)
Hash/64Bytes-12   618.2Mi ± 1%   579.8Mi ± 1%   -6.22% (p=0.002 n=6)
Hash/1K-12        1.682Gi ± 1%   1.665Gi ± 1%   -0.98% (p=0.002 n=6)
Hash/8K-12        1.878Gi ± 1%   1.878Gi ± 1%        ~ (p=0.310 n=6)
Hash/1M-12        1.907Gi ± 0%   1.913Gi ± 1%        ~ (p=0.485 n=6)
Hash/5M-12        1.911Gi ± 1%   1.904Gi ± 0%        ~ (p=0.093 n=6)
Hash/10M-12       1.910Gi ± 0%   1.905Gi ± 0%        ~ (p=0.093 n=6)
geomean           1.066Gi        1.032Gi        -3.18%
```

</details>


### Testing

Compiled and tested on Linux.

### Documentation

https://github.com/syncthing/docs/pull/874
2024-08-10 12:58:20 +01:00
..
mocks all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
testdata all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
blockpullreorderer_test.go
blockpullreorderer.go
debug.go
deviceactivity_test.go
deviceactivity.go
devicedownloadstate_test.go
devicedownloadstate.go
doc.go
fakeconns_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
folder_recvenc.go all: Remove lib/util package (#9049) 2023-08-21 19:44:33 +02:00
folder_recvonly_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
folder_recvonly.go all: Remove lib/util package (#9049) 2023-08-21 19:44:33 +02:00
folder_sendonly.go lib/ignore: Refactor out result type (#9343) 2024-01-13 18:58:23 +01:00
folder_sendrecv_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
folder_sendrecv_unix.go
folder_sendrecv_windows.go
folder_sendrecv.go lib/sha256: Remove it (#9643) 2024-08-10 12:58:20 +01:00
folder_summary.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
folder_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
folder.go lib/model: Only handle relevant folder summaries (kqueue) (fixes #9183) (#9288) 2023-12-13 12:34:24 +01:00
folderstate.go all: Add Prometheus-style metrics to expose some internal performance counters (fixes #5175) (#9003) 2023-08-04 19:57:30 +02:00
indexhandler_test.go lib/model: Deflake new IndexHandlerTest (#9412) 2024-02-11 09:03:12 +01:00
indexhandler.go lib/model: Don't bump seq on error in index handler (#9459) 2024-03-11 07:30:21 +01:00
metrics.go all: Add Prometheus-style metrics to expose some internal performance counters (fixes #5175) (#9003) 2023-08-04 19:57:30 +02:00
model_test.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
model.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
progressemitter_test.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
progressemitter.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
queue_test.go all: Use some Go 1.21 features (#9409) 2024-02-10 21:02:42 +01:00
queue.go
requests_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
sentdownloadstate.go
service_map_test.go lib/model: Refactor folderRunners to use a serviceMap (#9071) 2023-09-02 16:42:46 +02:00
service_map.go lib/model: Remove spurious "replacing service" failure event (ref #9271) 2023-12-11 07:43:40 +01:00
sharedpullerstate_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
sharedpullerstate.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
testos_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
testutils_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
util.go lib/model: Use a single lock (phase two: cleanup) (#9276) 2023-12-11 22:06:45 +01:00
utils_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00