mirror of https://github.com/octoleo/syncthing.git synced 2025-01-23 07:08:24 +00:00

History

cmd/stdiscosrv: Prevent nil IPs from X-Forwarded-For (fixes #9189 ) (#9190 )

### Purpose

Treat X-Forwarded-For as a comma-separated string to prevent nil IP being returned by the Discovery Server

### Testing

Unit Tests implemented

Testing with a Discovery Client can be done as follows:
```
A simple example to replicate this entails running Discovery with HTTP, use Nginx as a reverse proxy and hardcode (as an example) a list of IPs in the X-Forwarded-For header.
1. Send an Announcement with tcp://0.0.0.0:<some-port>
2. Query the DeviceID
3. Observe the returned IP Address is no longer nil; i.e.  `tcp://<nil>:<some-port>`
```

2023-11-08 11:10:23 +00:00

etc

etc: Fix misleading comment in discosrv options file (#6258 )

2020-01-06 22:43:41 +00:00

scripts

build, etc: Add systemd units and ufw rules for relay and discovery (fixes #5115 ) (#5350 )

2019-08-08 18:04:52 +02:00

apisrv_test.go

cmd/stdiscosrv: Prevent nil IPs from X-Forwarded-For (fixes #9189 ) (#9190 )

2023-11-08 11:10:23 +00:00

apisrv.go

cmd/stdiscosrv: Prevent nil IPs from X-Forwarded-For (fixes #9189 ) (#9190 )