octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2024-12-22 10:58:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
896f9725ec
syncthing/lib/model
History
Hireworks 36ef17df8f
fix(model): check if remote folder state before pulling files (fixes #9686) (#9732) 
### Purpose

As discussed in #9686 
Syncthing currently does not check folderstate on remote device before
pulling. If no devices have a valid folderstate (i.e all devices have
the folder paused) it will still attempt to pull. On large folders this
will cause a hanging "Syncing" status.

This checks whether at least one connected device has the file available
and has a valid folderstate.

### Testing
Tested locally on multiple devices.
We're new to Go (all our stuff is Python) so please bear with!
Interested if there may be a better place to slot this in.

Thanks,
Jon

---------

Co-authored-by: Simon Frei <freisim93@gmail.com>
2024-11-12 08:51:52 +01:00
..
mocks all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
testdata all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
blockpullreorderer_test.go all: Remove miscellaneous vestigial code (#7495) 2021-03-17 22:23:12 +01:00
blockpullreorderer.go lib/model: Add support for different puller block ordering (#6587) 2020-05-11 22:44:04 +01:00
debug.go all, lib/logger: Refactor SetDebug calls (#6054) 2019-10-04 13:03:34 +02:00
deviceactivity_test.go lib/model: Return index from deviceActivity.leastBusy 2021-11-26 12:07:43 +01:00
deviceactivity.go lib/model: Return index from deviceActivity.leastBusy 2021-11-26 12:07:43 +01:00
devicedownloadstate_test.go all: Move remaining protos to use the vanity plugin (#7009) 2020-10-02 08:07:05 +02:00
devicedownloadstate.go all: Move remaining protos to use the vanity plugin (#7009) 2020-10-02 08:07:05 +02:00
doc.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
fakeconns_test.go lib/protocol: Further interface refactor (#9396) 2024-08-24 12:45:10 +02:00
folder_recvenc.go all: Remove lib/util package (#9049) 2023-08-21 19:44:33 +02:00
folder_recvonly_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
folder_recvonly.go all: Remove lib/util package (#9049) 2023-08-21 19:44:33 +02:00
folder_sendonly.go lib/ignore: Refactor out result type (#9343) 2024-01-13 18:58:23 +01:00
folder_sendrecv_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
folder_sendrecv_unix.go all: Support syncing ownership (fixes #1329) (#8434) 2022-07-26 08:24:58 +02:00
folder_sendrecv_windows.go all: Support syncing ownership (fixes #1329) (#8434) 2022-07-26 08:24:58 +02:00
folder_sendrecv.go fix(model): check if remote folder state before pulling files (fixes #9686) (#9732) 2024-11-12 08:51:52 +01:00
folder_summary.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
folder_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
folder.go lib/model: Only handle relevant folder summaries (kqueue) (fixes #9183) (#9288) 2023-12-13 12:34:24 +01:00
folderstate.go all: Add Prometheus-style metrics to expose some internal performance counters (fixes #5175) (#9003) 2023-08-04 19:57:30 +02:00
indexhandler_test.go lib/protocol: Further interface refactor (#9396) 2024-08-24 12:45:10 +02:00
indexhandler.go chore(model): improve tracking sentPrevSeq for index debugging (#9740) 2024-09-29 22:18:24 +00:00
metrics.go all: Add Prometheus-style metrics to expose some internal performance counters (fixes #5175) (#9003) 2023-08-04 19:57:30 +02:00
model_test.go lib/protocol: Further interface refactor (#9396) 2024-08-24 12:45:10 +02:00
model.go fix(model): check if remote folder state before pulling files (fixes #9686) (#9732) 2024-11-12 08:51:52 +01:00
progressemitter_test.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
progressemitter.go lib/protocol: Further interface refactor (#9396) 2024-08-24 12:45:10 +02:00
queue_test.go all: Use some Go 1.21 features (#9409) 2024-02-10 21:02:42 +01:00
queue.go lib/model: Optimize jobQueue performance and memory use (#8023) 2021-10-29 20:20:46 +02:00
requests_test.go lib/protocol: Further interface refactor (#9396) 2024-08-24 12:45:10 +02:00
sentdownloadstate.go all: Fix various user-facing and non-user-facing typos (#8509) 2022-08-23 15:44:11 +02:00
service_map_test.go lib/model: Refactor folderRunners to use a serviceMap (#9071) 2023-09-02 16:42:46 +02:00
service_map.go lib/model: Remove spurious "replacing service" failure event (ref #9271) 2023-12-11 07:43:40 +01:00
sharedpullerstate_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
sharedpullerstate.go all: minimal set of changes for iOS app (#9619) 2024-07-31 07:31:14 +02:00
testos_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00
testutils_test.go lib/protocol: Refactor interface (#9375) 2024-01-31 08:18:27 +01:00
util.go lib/model: Use a single lock (phase two: cleanup) (#9276) 2023-12-11 22:06:45 +01:00
utils_test.go all: Grand test refactor (fixes #8779, fixes #8799) 2023-05-09 10:01:57 +00:00