mirror of
https://github.com/octoleo/syncthing.git
synced 2024-12-23 03:18:59 +00:00
b9c6d3ae09
When creating an initial default config, we usually probe for a free
TCP port. But when a UNIX socket is specified via the `STGUIADDRESS=`
override or the `--gui-address=unix:///...` command line syntax, parsing
that option will fail during port probing.
The solution is to just skip the port probing when the address is
determined to specify something other than a TCP socket.
### Testing
Start with a fresh home directory each time.
1. Specify a UNIX socket for the GUI (works with this PR):
TMPHOME=$(mktemp -d); ./syncthing --home=$TMPHOME
--gui-address=unix://$TMPHOME/socket
2. Specify no GUI address (probes for a free port if default is taken,
as before):
TMPHOME=$(mktemp -d); ./syncthing --home=$TMPHOME
3. Specify a TCP GUI address (probes whether the given port is taken,
as before):
TMPHOME=$(mktemp -d); ./syncthing --home=$TMPHOME
--gui-address=127.0.0.1:8385
|
||
|---|---|---|
| .. | ||
| mocks | ||
| testdata | ||
| authmode.go | ||
| blockpullorder.go | ||
| commit_test.go | ||
| compression_test.go | ||
| compression.go | ||
| config_test.go | ||
| config.go | ||
| copyrangemethod.go | ||
| debug.go | ||
| deviceconfiguration.go | ||
| filesystemtype.go | ||
| folderconfiguration.go | ||
| foldertype.go | ||
| guiconfiguration.go | ||
| ldapconfiguration.go | ||
| ldaptransport.go | ||
| migrations_test.go | ||
| migrations.go | ||
| observed.go | ||
| optionsconfiguration.go | ||
| pullorder.go | ||
| size_test.go | ||
| size.go | ||
| tuning_test.go | ||
| tuning.go | ||
| versioningconfiguration.go | ||
| wrapper.go | ||