diff --git a/README.html b/README.html index dd5d2b8..a51e2cb 100644 --- a/README.html +++ b/README.html @@ -341,7 +341,7 @@ It features background tasks and interactive chats, and can serve as an interfac
Running a Telegram Bot means it is connected to the public and you never know what's send to your Bot.
Bash scripts in general are not designed to be bulletproof, so consider this Bot as a proof of concept. Bash programmers often struggle with 'quoting hell' and globbing, see Implications of wrong quoting.
Whenever you are processing input from untrusted sources (messages, files, network) you must be as careful as possible (e.g. set IFS appropriately, disable globbing with set -f
and quote everything). In addition remove unused scripts and examples from your Bot (e.g. everything in example/
) and disable/remove all unused bot commands.
It's important to escape or remove $
in input from user, files or network (as bashbot does). One of the powerful features of Unix shells is variable and command substitution using ${}
and$()
can lead to remote code execution (RCE) or remote information disclosure (RID) bugs if unescaped $
is included in untrusted input (e.g. $$
or $(rm -rf /*)
).
It's important to escape or remove $
in input from user, files or network (as bashbot does). One of the powerful features of Unix shells is variable and command substitution using ${}
and $()
can lead to remote code execution (RCE) or remote information disclosure (RID) bugs if unescaped $
is included in untrusted input (e.g. $$
or $(rm -rf /*)
).
A powerful tool to improve your scripts is shellcheck
. You can use it online or install shellcheck locally. Shellcheck is used extensively in bashbot development to ensure a high code quality (e.g. it's not allowed to push changes without passing all shellcheck tests). In addition bashbot has a test suite to check if important functionality is working as expected.
If you're writing a script that accepts external input (e.g. from the user as arguments or the file system), you shouldn't use echo to display it. Use printf whenever possible.
@@ -350,8 +350,9 @@ It features background tasks and interactive chats, and can serve as an interfacNever run your Bot as root, this is the most dangerous you can do! Usually the user 'nobody' has almost no rights on Linux/Unix systems. See Expert use on how to run your Bot as an other user.
Your Bot configuration must not be readable by other users. Everyone who can read your Bots token is able to act as your Bot and has access to all chats the Bot is in!
-Everyone with read access to your Bot files can extract your Bots data. Especially your Bot config inconfig.jssh
must be protected against other users. No one except you should have write access to the Bot files. The Bot should be restricted to have write access tocount.jssh
and data-bot-bash
only, all other files must be write protected.
To set access rights for your bashbot installation to a reasonable default runsudo ./bashbot.sh init
after every update or change to your installation directory.
Everyone with read access to your Bot files can extract your Bots data. Especially your Bot config in config.jssh
must be protected against other users. No one except you should have write access to the Bot files. The Bot should be restricted to have write access to count.jssh
, data-bot-bash/
and logs/
only, all other files must be write protected.
To set access rights for your bashbot installation to a reasonable default run sudo ./bashbot.sh init
after every update or change to your installation directory.
Note: Keep old log files in a safe place or even better delete them, they are GDPR relevant and may contain information you don't want to be public.
Bashbot is not more (in)secure than a Bot written in another language. We have done our best to make it as secure as possible. But YOU are responsible for the bot commands you wrote and you should know about the risks ...
@@ -365,8 +366,8 @@ It features background tasks and interactive chats, and can serve as an interfacAt the beginning bashbot was simply the filebashbot.sh
that you could copy everywhere and run the bot. Now we have 'commands.sh', 'mycommands.sh', 'modules/*.sh' and much more.
Hey no problem, if you are finished with your cool bot, rundev/make-standalone.sh
to create a stripped down version of your bot containing only 'bashbot.sh' and 'commands.sh'! For more information see Create a stripped down version of your Bot.
At the beginning bashbot was simply the file bashbot.sh
that you could copy everywhere and run the bot. Now we have 'commands.sh', 'mycommands.sh', 'modules/*.sh' and much more.
Hey no problem, if you are finished with your cool bot, run dev/make-standalone.sh
to create a stripped down version of your bot containing only 'bashbot.sh' and 'commands.sh'! For more information see Create a stripped down version of your Bot.
Of course you can send messages from command line and scripts! Simply install bashbot as described here, send the message '/start' to set yourself as botadmin and then stop the bot with ./bashbot.sh stop
.
Bashbot provides some ready to use scripts for sending messages from command line in bin/
dir, e.g. send_message.sh
.
@Gnadelwartz
If you feel that there's something missing or if you found a bug, feel free to submit a pull request!
-