Fix mail::send_incomplete_2fa_login panic issue (#4792)

- fixes https://github.com/dani-garcia/vaultwarden/issues/4528
This commit is contained in:
Daniel 2024-08-07 23:45:41 +03:00 committed by GitHub
parent a7be8fab9b
commit e7d5c17ff7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -269,10 +269,18 @@ pub async fn send_incomplete_2fa_notifications(pool: DbPool) {
"User {} did not complete a 2FA login within the configured time limit. IP: {}",
user.email, login.ip_address
);
mail::send_incomplete_2fa_login(&user.email, &login.ip_address, &login.login_time, &login.device_name)
match mail::send_incomplete_2fa_login(&user.email, &login.ip_address, &login.login_time, &login.device_name)
.await
.expect("Error sending incomplete 2FA email");
login.delete(&mut conn).await.expect("Error deleting incomplete 2FA record");
{
Ok(_) => {
if let Err(e) = login.delete(&mut conn).await {
error!("Error deleting incomplete 2FA record: {e:#?}");
}
}
Err(e) => {
error!("Error sending incomplete 2FA email: {e:#?}");
}
}
}
}