Commit Graph

1461 Commits

Author SHA1 Message Date
ariasuni
045172bd9e Fix all remaining clippy warnings
- Allow clippy::cast_*: generated warnings are mostly useless
- Fix the other warnings so using clippy is actually useful
2021-05-08 18:09:35 +02:00
Mélanie Chauvel
f8610d05ae
Merge pull request #865 from ariasuni/filter-rs-cleanup
`src/fs/filter.rs` cleanup
2021-05-08 16:37:19 +02:00
ariasuni
86d5939abe Remove unused function 2021-05-08 16:20:17 +02:00
ariasuni
90416ed3ce Update comments about how the --git-ignore option is handled 2021-05-08 16:20:17 +02:00
ariasuni
7c80070120 Update broken link, remove content copied from said link
The old Google+ post is unavailable. The new link points to an article who saved the content and is also available on Wayback Machine.
2021-05-08 16:20:17 +02:00
Mélanie Chauvel
a58ad6487f
Merge pull request #862 from cgzones/clippy
Cleanup clippy warnings
2021-05-08 16:06:49 +02:00
Christian Göttsche
ae62f5d18e Cleanup clippy warnings
Drop unused allow overrides
2021-04-30 15:37:43 +02:00
Christian Göttsche
d253893614 Cleanup clippy warnings
Enable clippy::missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section
   --> src/main.rs:164:5
    |
164 | /     pub fn run(mut self) -> io::Result<i32> {
165 | |         debug!("Running with options: {:#?}", self.options);
166 | |
167 | |         let mut files = Vec::new();
...   |
202 | |         self.print_dirs(dirs, no_files, is_only_dir, exit_status)
203 | |     }
    | |_____^
    |
2021-04-30 15:37:39 +02:00
Christian Göttsche
61ec153bcd Cleanup clippy warnings
warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
 --> src/output/escape.rs:4:1
  |
4 | pub fn escape<'a>(string: String, bits: &mut Vec<ANSIString<'a>>, good: Style, bad: Style) {
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |

warning: this lifetime isn't used in the function definition
 --> src/output/escape.rs:4:15
  |
4 | pub fn escape<'a>(string: String, bits: &mut Vec<ANSIString<'_>>, good: Style, bad: Style) {
  |               ^^
  |

warning: single-character string constant used as pattern
   --> src/output/table.rs:310:41
    |
310 |                     if file.starts_with(":") {
    |                                         ^^^ help: try using a `char` instead: `':'`
    |

warning: single-character string constant used as pattern
   --> src/output/table.rs:310:41
    |
310 |                     if file.starts_with(":") {
    |                                         ^^^ help: try using a `char` instead: `':'`
    |

warning: methods called `new` usually return `Self`
  --> src/output/render/git.rs:38:5
   |
38 |     fn new(&self) -> Style;
   |     ^^^^^^^^^^^^^^^^^^^^^^^
   |

warning: this lifetime isn't used in the function definition
  --> src/output/icons.rs:40:22
   |
40 | pub fn iconify_style<'a>(style: Style) -> Style {
   |                      ^^
   |

warning: lint `clippy::find_map` has been removed: this lint has been replaced by `manual_find_map`, a more specific lint
  --> src/main.rs:11:10
   |
11 | #![allow(clippy::find_map)]
   |          ^^^^^^^^^^^^^^^^
   |

warning: redundant else block
   --> src/fs/dir.rs:124:18
    |
124 |               else {
    |  __________________^
125 | |                 return None
126 | |             }
    | |_____________^
    |

warning: redundant else block
  --> src/options/view.rs:60:18
   |
60 |               else {
   |  __________________^
61 | |                 // the --tree case is handled by the DirAction parser later
62 | |                 return Ok(Self::Details(details));
63 | |             }
   | |_____________^
   |

warning: all variants have the same postfix: `Bytes`
   --> src/output/table.rs:170:1
    |
170 | / pub enum SizeFormat {
171 | |
172 | |     /// Format the file size using **decimal** prefixes, such as “kilo”,
173 | |     /// “mega”, or “giga”.
...   |
181 | |     JustBytes,
182 | | }
    | |_^
    |

warning: all variants have the same postfix: `Bytes`
   --> src/output/table.rs:171:1
    |
171 | / pub enum SizeFormat {
172 | |
173 | |     /// Format the file size using **decimal** prefixes, such as “kilo”,
174 | |     /// “mega”, or “giga”.
...   |
182 | |     JustBytes,
183 | | }
    | |_^
    |

warning: useless use of `format!`
   --> src/options/mod.rs:181:50
    |
181 |               return Err(OptionsError::Unsupported(format!(
    |  __________________________________________________^
182 | |                 "Options --git and --git-ignore can't be used because `git` feature was disabled in this build of exa"
183 | |             )));
    | |_____________^ help: consider using `.to_string()`: `"Options --git and --git-ignore can't be used because `git` feature was disabled in this build of exa".to_string()`
    |

warning: stripping a prefix manually
   --> src/fs/filter.rs:287:33
    |
287 |         if n.starts_with('.') { &n[1..] }
    |                                 ^^^^^^^
    |

warning: case-sensitive file extension comparison
  --> src/info/filetype.rs:24:19
   |
24 |         file.name.ends_with(".ninja") ||
   |                   ^^^^^^^^^^^^^^^^^^^
   |
2021-04-30 15:37:31 +02:00
Mélanie Chauvel
95682f5674
Merge pull request #858 from Prunkles/master
Add F# icons
2021-04-27 01:01:41 +02:00
Mélanie Chauvel
6b8d7fcd70
Merge pull request #850 from ariasuni/replace-term_size-by-terminal_size
Replace unmaintained crate `term_size` by `terminal_size`
2021-04-27 00:57:49 +02:00
ariasuni
a85c72e2a0 Replace unmaintained crate term_size by terminal_size 2021-04-27 00:16:25 +02:00
Haren S
90b97753ad
Update lockfile (#854)
Update lockfile (exa now requires Rust 1.45.2 or higher)

Co-authored-by: Mélanie Chauvel <perso@hack-libre.org>
2021-04-26 23:37:32 +02:00
Prunkles
7a26b4e0f7 Add F# icons 2021-04-26 08:05:05 +03:00
Benjamin Sago
293372a613 v0.10.1 2021-04-12 22:28:31 +01:00
Benjamin Sago
c0df1fb6c2 cargo update 2021-04-12 22:27:59 +01:00
Benjamin Sago
e3e776a1fa Use better icon for TeX files
Fixes GH-777.
2021-04-12 22:23:51 +01:00
Benjamin Sago
1f4e58ee52 Explain Git characters in man page
Fixes GH-778.
2021-04-12 22:17:39 +01:00
Benjamin Sago
dbd11d3804 Add classify char to symlink targets
Fixes GH-589.
2021-04-12 22:02:30 +01:00
Benjamin Sago
b1c49341c0 Add tests for common command-line errors
Specifically, making sure that they start with "exa", which is something that's been bugging me recently.
2021-04-12 21:55:22 +01:00
Benjamin Sago
550f2d29c2 Add context to all option number parse errors
Fixes GH-839.
2021-04-12 21:42:45 +01:00
Benjamin Sago
31043462af Improve help text for -d flag
Fixes GH-202.
2021-04-11 23:43:36 +01:00
Benjamin Sago
311c9baf65 Explain device IDs with a comment 2021-04-11 23:34:29 +01:00
Benjamin Sago
d19d66d57a Fix device IDs test so it works every time
It inadvertently contained the machine build time, which meant it stopped working once the Vagrant machine was rebuild.
2021-04-11 23:34:14 +01:00
Benjamin Sago
051a46c643
Merge pull request #842 from ariasuni/dont-aggregate-git-ignored-status2
Fix deducing git ignored state for files too, not only directories
2021-04-11 20:33:56 +01:00
ariasuni
bfd2644869 Add xtests for new git ignored status deducing logic 2021-04-10 01:42:02 +02:00
Benjamin Sago
f6e66d982d Add tests for device IDs in file size column 2021-04-09 23:59:54 +01:00
ariasuni
bd4f144884 Fix deducing git ignored state for files too, not only directories 2021-04-10 00:56:07 +02:00
Benjamin Sago
6403336028
Merge pull request #841 from ariasuni/dont-aggregate-git-ignored-status
Fix --git deducing ignored state in unintuitive way
2021-04-09 23:12:37 +01:00
Benjamin Sago
e86f2b938b
Merge pull request #837 from ariasuni/fix-month-name-not-translated
Fix month name not following locale when date is in current year
2021-04-09 23:11:28 +01:00
Benjamin Sago
f3ae6a9bd9
Merge pull request #836 from ariasuni/fix-exa-grid-rows
Fix `EXA_GRID_ROWS` not working in some cases
2021-04-09 23:02:49 +01:00
ariasuni
8c10feec51 Fix --git deducing ignored state in unintuitive way
It makes sense to consider that a directory has the aggregated status of all the files under it.

The exception is that for the ignored status, it’s more useful and intuitive to consider that it applies to everything under it.

- A directory containing an ignored file is no longer considered ignored
- A file inside an ignored directory is now considered ignored
2021-04-09 21:47:42 +02:00
ariasuni
f673e018b5 Add a test checking that date of the current year follows locale 2021-04-09 18:46:10 +02:00
ariasuni
3a8005c840 Fix month name not following locale when date is in current year 2021-04-09 17:54:18 +02:00
ariasuni
beaf561086 Add xtests for EXA_GRID_ROWS 2021-04-09 17:48:00 +02:00
ariasuni
a0457f9c87 Fix misleading name of some test files 2021-04-09 17:48:00 +02:00
ariasuni
050931e48f Fix a typo in test descriptions 2021-04-09 17:48:00 +02:00
ariasuni
c729e226da Fix EXA_GRID_ROWS not working in some cases 2021-04-09 17:48:00 +02:00
Benjamin Sago
2aaead1721
Merge pull request #830 from ariasuni/fix-alignement-with-non-ascii-thousands-separator
Use thousand separators again and fix alignement when it’s not ASCII
2021-04-08 23:33:54 +01:00
ariasuni
7a4cde75eb Use thousand separators again and fix alignement when it’s not ASCII 2021-04-06 16:23:30 +02:00
Benjamin Sago
505808fd9f The road ahead 2021-04-04 23:03:53 +01:00
Benjamin Sago
03cd3a81ff v0.10.0 2021-04-03 17:42:56 +01:00
Benjamin Sago
aee9c0e623 Remove some unused Cargo.toml options 2021-04-03 17:41:54 +01:00
Benjamin Sago
8c34b46a22 Version output changes
• Bring what's shown in the version string in line with my other projects (URL, description, git hash and date for release-mode non-final builds only, potential for colours in the future)
• Show +git or -git depending on feature status
• Tests for the above, and for checking that the command-line flag is warned about
2021-04-03 17:41:48 +01:00
Benjamin Sago
b051ac9477
Merge pull request #827 from Tezkerek/patch-1
Fix completions.zsh syntax
2021-04-03 11:44:45 +01:00
Tezkerek
1da705c355
Fix completions.zsh syntax 2021-04-03 11:47:59 +03:00
Benjamin Sago
ba763d4bbd
Merge pull request #801 from alexanderadam/add-termux
documentation: add hint how to install exa on Android / Termux
2021-04-02 13:27:11 +01:00
Alexander Adam
8f8e81182a
documentation: add hint how to install exa on Android / Termux 2021-04-01 18:50:57 +02:00
Benjamin Sago
004589d079 Upgrade datetime to remove some dependencies 2021-04-01 16:58:01 +01:00
Benjamin Sago
701a2e60e5 Add 'exa: ' before all command-line errors 2021-04-01 11:25:50 +01:00