accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2024-09-20 03:29:00 +00:00
Code Issues Releases Activity

refactor: validateStockAvailability

Browse Source
This commit is contained in:
akshayitzme 2023-02-17 16:04:46 +05:30
parent 4fc6c3cf1b
commit 09591703e4
1 changed files with 39 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

86
models/inventory/StockManager.ts
View File

@ -88,7 +88,6 @@ export class StockManager {
this.#validateQuantity(details); this.#validateQuantity(details);
this.#validateLocation(details); this.#validateLocation(details);
await this.#validateStockAvailability(details); await this.#validateStockAvailability(details);
await this.#validateBatchWiseStockAvailability(details);
} }
#validateQuantity(details: SMIDetails) { #validateQuantity(details: SMIDetails) {
@ -127,58 +126,51 @@ export class StockManager {
throw new ValidationError(t`Both From and To Location cannot be undefined`); throw new ValidationError(t`Both From and To Location cannot be undefined`);
} }
async #validateBatchWiseStockAvailability(details: SMIDetails) {
if (!details.fromLocation) {
return;
}
const isItemHasBatchNumber = await this.fyo.getValue(
'Item',
details.item,
'hasBatchNumber'
);
if (!isItemHasBatchNumber) return;
if (!details.batchNumber) {
throw new ValidationError(
t`Please enter Batch Number for ${details.item}`
);
}
const date = details.date.toISOString();
const itemsInBatch =
(await this.fyo.db.getStockQuantity(
details.item,
details.fromLocation,
undefined,
date,
details.batchNumber
)) ?? 0;
if (details.quantity < itemsInBatch) return;
const formattedDate = this.fyo.format(details.date, 'Datetime');
throw new ValidationError(
[
t`Insufficient Quantity in Batch ${details.batchNumber}`,
t`Additional quantity (${
details.quantity - itemsInBatch
}) is required in batch ${
details.batchNumber
} to make the outward transfer of item ${details.item} from ${
details.fromLocation
} on ${formattedDate}`,
].join('\n')
);
}
async #validateStockAvailability(details: SMIDetails) { async #validateStockAvailability(details: SMIDetails) {
if (!details.fromLocation) { if (!details.fromLocation) {
return; return;
} }
const date = details.date.toISOString(); const date = details.date.toISOString();
const isItemHasBatchNumber = await this.fyo.getValue(
'Item',
details.item,
'hasBatchNumber'
);
if (isItemHasBatchNumber) {
if (!details.batchNumber) {
throw new ValidationError(
t`Please enter Batch Number for ${details.item}`
);
}
const itemsInBatch =
(await this.fyo.db.getStockQuantity(
details.item,
details.fromLocation,
undefined,
date,
details.batchNumber
)) ?? 0;
if (details.quantity < itemsInBatch) return;
const formattedDate = this.fyo.format(details.date, 'Datetime');
throw new ValidationError(
[
t`Insufficient Quantity in Batch ${details.batchNumber}`,
t`Additional quantity (${
details.quantity - itemsInBatch
}) is required in batch ${
details.batchNumber
} to make the outward transfer of item ${details.item} from ${
details.fromLocation
} on ${formattedDate}`,
].join('\n')
);
}
let quantityBefore = let quantityBefore =
(await this.fyo.db.getStockQuantity( (await this.fyo.db.getStockQuantity(
details.item, details.item,