accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2025-02-10 07:59:03 +00:00
Code Issues Releases Activity

fix: Use sql method in getAll

Browse Source
This commit is contained in:
Faris Ansari 2019-11-22 00:51:56 +05:30
parent 31ebfb1d0e
commit 26e51d4edf
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
backends/sqlite.js
View File

@ -212,7 +212,6 @@ class SqliteDatabase extends Database {
filters = Object.assign({}, filters, meta.filters); filters = Object.assign({}, filters, meta.filters);
} }
return new Promise((resolve, reject) => {
let conditions = this.getFilterConditions(filters); let conditions = this.getFilterConditions(filters);
let query = `select ${fields.join(", ")} let query = `select ${fields.join(", ")}
from ${baseDoctype} from ${baseDoctype}
@ -221,16 +220,7 @@ class SqliteDatabase extends Database {
${orderBy ? ("order by " + orderBy) : ""} ${orderBy ? (order || "asc") : ""} ${orderBy ? ("order by " + orderBy) : ""} ${orderBy ? (order || "asc") : ""}
${limit ? ("limit " + limit) : ""} ${start ? ("offset " + start) : ""}`; ${limit ? ("limit " + limit) : ""} ${start ? ("offset " + start) : ""}`;
this.conn.all(query, conditions.values, return this.sql(query, conditions.values);
(err, rows) => {
if (err) {
console.error(err);
reject(err);
} else {
resolve(rows);
}
});
});
} }
run(query, params) { run(query, params) {