accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2024-12-31 05:51:49 +00:00
Code Issues Releases Activity

feat: prevent coupon usage if maximum limit is exceeded

Browse Source
This commit is contained in:
AbleKSaju 2024-09-18 10:41:15 +05:30
parent 8697e7ebf9
commit 41a67cc864
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
models/baseModels/AppliedCouponCodes/AppliedCouponCodes.ts
View File

@ -23,10 +23,18 @@ export class AppliedCouponCodes extends InvoiceItem {
'pricingRule',
'validFrom',
'validTo',
'maximumUse',
'used',
],
filters: { name: value as string },
});
if ((coupon[0]?.maximumUse as number) <= (coupon[0]?.used as number)) {
throw new ValidationError(
'Coupon code has been used maximum number of times'
);
}
const applicableCouponCodesNames = await getApplicableCouponCodesName(
value as string,
this.parentdoc as SalesInvoice

15
models/baseModels/Invoice/Invoice.ts
View File

@ -236,6 +236,10 @@ export abstract class Invoice extends Transactional {
await this._updateIsItemsReturned();
await this._createLoyaltyPointEntry();
if (this.schemaName === ModelNameEnum.SalesInvoice) {
this.updateUsedCountOfCoupons();
}
}
async afterCancel() {
@ -553,6 +557,17 @@ export abstract class Invoice extends Transactional {
return newReturnDoc;
}
updateUsedCountOfCoupons() {
this.coupons?.map(async (coupon) => {
const couponDoc = await this.fyo.doc.getDoc(
ModelNameEnum.CouponCode,
coupon.coupons
);
await couponDoc.setAndSync({ used: (couponDoc.used as number) + 1 });
});
}
async _updateIsItemsReturned() {
if (!this.isReturn || !this.returnAgainst || this.isQuote) {
return;