accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2025-01-23 07:08:36 +00:00
Code Issues Releases Activity

fix: prevent NaN in the invoices

Browse Source
This commit is contained in:
18alantom 2021-11-10 19:09:21 +05:30
parent 04d2c4278f
commit 735bf3f830
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
models/doctype/PurchaseInvoiceItem/PurchaseInvoiceItem.js
View File

@ -40,8 +40,9 @@ export default {
fieldtype: 'Currency',
required: 1,
formula: async (row, doc) => {
let baseRate = await doc.getFrom('Item', row.item, 'rate');
return baseRate / doc.exchangeRate;
const baseRate = (await doc.getFrom('Item', row.item, 'rate')) || 0;
const exchangeRate = doc.exchangeRate ?? 1;
return baseRate / exchangeRate;
},
getCurrency: (row, doc) => doc.currency
},

5
models/doctype/SalesInvoiceItem/SalesInvoiceItem.js
View File

@ -41,8 +41,9 @@ export default {
fieldtype: 'Currency',
required: 1,
formula: async (row, doc) => {
let baseRate = await doc.getFrom('Item', row.item, 'rate');
return baseRate / doc.exchangeRate;
const baseRate = (await doc.getFrom('Item', row.item, 'rate')) || 0;
const exchangeRate = doc.exchangeRate ?? 1;
return baseRate / exchangeRate;
},
getCurrency: (row, doc) => doc.currency,
formulaDependsOn: ['item']