2
0
mirror of https://github.com/frappe/books.git synced 2024-12-23 03:19:01 +00:00

Fixed not null for defaul;t

This commit is contained in:
Achilles Rasquinha 2018-02-01 14:35:18 +05:30
parent b436aa617c
commit 7d7eae5660

View File

@ -1,6 +1,6 @@
const frappe = require('frappejs');
const sqlite3 = require('sqlite3').verbose();
const debug = false;
const debug = true;
class sqliteDatabase {
constructor({ db_path }) {
@ -62,7 +62,7 @@ class sqliteDatabase {
}
get_column_definition(df) {
return `${df.fieldname} ${this.type_map[df.fieldtype]} ${df.reqd ? "not null" : ""} ${df.default ? "default ?" : ""}`
return `${df.fieldname} ${this.type_map[df.fieldtype]} ${df.reqd && !df.default ? "not null" : ""} ${df.default ? "default ?" : ""}`
}
async alter_table(doctype) {
@ -226,10 +226,13 @@ class sqliteDatabase {
}
run(query, params) {
// TODO promisify
console.log(query, params)
console.log(this.conn.prepare(query, params))
return new Promise((resolve, reject) => {
this.conn.run(query, params, (err) => {
if (err) {
console.log(err);
console.error(err);
reject(err);
} else {
resolve();