accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2024-11-14 01:14:03 +00:00
Code Issues Releases Activity

fix: use toast for Save as PDF

Browse Source 
- DRY for export toast
This commit is contained in:
18alantom 2022-01-19 12:13:42 +05:30
parent 8e62272d08
commit 81c6812e2f
3 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
reports/commonExporter.js
View File

@ -1,10 +1,5 @@
import frappe from 'frappejs'; import frappe from 'frappejs';
import { import { getSavePath, saveData, showExportInFolder } from '../src/utils';
getSavePath,
saveData,
showItemInFolder,
showToast,
} from '../src/utils';
function templateToInnerText(innerHTML) { function templateToInnerText(innerHTML) {
const temp = document.createElement('template'); const temp = document.createElement('template');
@ -106,11 +101,5 @@ export default function getCommonExportActions(reportName) {
export async function saveExportData(data, filePath) { export async function saveExportData(data, filePath) {
await saveData(data, filePath); await saveData(data, filePath);
showToast({ showExportInFolder(frappe._('Export Successful'), filePath);
message: frappe._('Export Successful'),
actionText: frappe._('Open Folder'),
action: async () => {
await showItemInFolder(filePath);
},
});
} }

19
src/saveHtmlAsPdf.js
View File

@ -1,6 +1,5 @@
import fs from 'fs'; import { BrowserWindow } from 'electron';
import { sleep } from 'frappejs/utils'; import fs from 'fs/promises';
import { shell, BrowserWindow } from 'electron';
const PRINT_OPTIONS = { const PRINT_OPTIONS = {
marginsType: 1, // no margin marginsType: 1, // no margin
@ -17,14 +16,16 @@ export default async function makePDF(html, savePath) {
document.body.innerHTML = \`${html}\`; document.body.innerHTML = \`${html}\`;
`); `);
printWindow.webContents.on('did-finish-load', async () => { return await new Promise((resolve) => {
await sleep(1); // Required else pdf'll be blank. printWindow.webContents.on('did-finish-load', async () => {
printWindow.webContents.printToPDF(PRINT_OPTIONS).then((data) => { await sleep(1); // Required else pdf'll be blank.
// printWindow.destroy();
fs.writeFile(savePath, data, (error) => { const data = await printWindow.webContents.printToPDF(PRINT_OPTIONS);
await fs.writeFile(savePath, data, (error) => {
if (error) throw error; if (error) throw error;
return shell.openPath(savePath);
}); });
resolve();
}); });
}); });
} }

11
src/utils.js
View File

@ -174,6 +174,17 @@ export function handleErrorWithDialog(e, doc) {
export async function makePDF(html, savePath) { export async function makePDF(html, savePath) {
await ipcRenderer.invoke(IPC_ACTIONS.SAVE_HTML_AS_PDF, html, savePath); await ipcRenderer.invoke(IPC_ACTIONS.SAVE_HTML_AS_PDF, html, savePath);
showExportInFolder(frappe._('Save as PDF Successful'), savePath);
}
export function showExportInFolder(message, filePath) {
showToast({
message,
actionText: frappe._('Open Folder'),
action: async () => {
await showItemInFolder(filePath);
},
});
} }
export async function saveData(data, savePath) { export async function saveData(data, savePath) {