accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2024-12-25 20:11:15 +00:00
Code Issues Releases Activity

fix: validate select for array of objects

Browse Source
This commit is contained in:
Faris Ansari 2019-12-20 11:58:00 +05:30
parent 1603346b20
commit a53cc9f119
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
model/meta.js
View File

@ -255,11 +255,17 @@ module.exports = class BaseMeta extends BaseDocument {
let options = field.options; let options = field.options;
if (!options) return; if (!options) return;
let validValues = options;
if (typeof options === 'string') { if (typeof options === 'string') {
// values given as string // values given as string
options = field.options.split('\n'); validValues = options.split('\n');
} }
if (!options.includes(value)) { if (typeof options[0] === 'object') {
// options as array of {label, value} pairs
validValues = options.map(o => o.value);
}
if (!validValues.includes(value)) {
throw new frappe.errors.ValueError( throw new frappe.errors.ValueError(
`${value} must be one of ${options.join(', ')}` `${value} must be one of ${options.join(', ')}`
); );