accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2024-12-23 11:29:03 +00:00
Code Issues Releases Activity

refactor: inline rendering

Browse Source
This commit is contained in:
18alantom 2022-02-11 18:01:48 +05:30
parent 6701b4f769
commit c6afe59033
1 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/components/TwoColumnForm.vue
View File

@ -12,37 +12,32 @@
@change="(value) => onChange(df, value)"
/>
<template v-else>
<template v-if="inlineEditField === df && inlineEditDoc">
<div class="border-b" :key="df.fieldname">
<TwoColumnForm
ref="inlineEditForm"
:doc="inlineEditDoc"
:fields="inlineEditFields"
:column-ratio="columnRatio"
:no-border="true"
:focus-first-input="true"
:autosave="false"
@error="(msg) => $emit('error', msg)"
/>
<div class="flex px-4 pb-2">
<Button
class="w-1/2 text-gray-900"
@click="inlineEditField = null"
>
{{ t('Cancel') }}
</Button>
<Button
type="primary"
class="ml-2 w-1/2 text-white"
@click="() => saveInlineEditDoc(df)"
>
{{ df.inlineSaveText || t('Save') }}
</Button>
</div>
<div class="border-b" :key="df.fieldname" v-if="renderInline(df)">
<TwoColumnForm
ref="inlineEditForm"
:doc="inlineEditDoc"
:fields="inlineEditFields"
:column-ratio="columnRatio"
:no-border="true"
:focus-first-input="true"
:autosave="false"
@error="(msg) => $emit('error', msg)"
/>
<div class="flex px-4 pb-2">
<Button class="w-1/2 text-gray-900" @click="inlineEditField = null">
{{ t('Cancel') }}
</Button>
<Button
type="primary"
class="ml-2 w-1/2 text-white"
@click="() => saveInlineEditDoc(df)"
>
{{ df.inlineSaveText || t('Save') }}
</Button>
</div>
</template>
</div>
<div
:key="df.fieldname"
:key="df.fieldname + '-else'"
v-else
class="grid"
:class="{ 'border-b': !noBorder }"
@ -141,6 +136,11 @@ let TwoColumnForm = {
}
},
methods: {
renderInline(df) {
return (
this.inlineEditField?.fieldname === df?.fieldname && this.inlineEditDoc
);
},
evaluateBoolean(fieldProp, defaultValue) {
const type = typeof fieldProp;
switch (type) {