accounting/books
2
0
Fork 0
mirror of https://github.com/frappe/books.git synced 2024-11-08 14:50:56 +00:00
Code Issues Releases Activity

fix: required error on non required children

Browse Source
This commit is contained in:
18alantom 2023-04-21 10:42:50 +05:30
parent 99af94f38e
commit cb6aaaee31
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/pages/ImportWizard.vue
View File

@ -492,7 +492,17 @@ export default defineComponent({
const assigned = new Set(this.importer.assignedTemplateFields);
return [...this.importer.templateFieldsMap.values()]
.filter((f) => f.required && !assigned.has(f.fieldKey))
.filter((f) => {
if (assigned.has(f.fieldKey) || !f.required) {
return false;
}
if (f.parentSchemaChildField && !f.parentSchemaChildField.required) {
return false;
}
return f.required;
})
.map((f) => getColumnLabel(f));
},
errorMessage(): string {
@ -797,7 +807,9 @@ export default defineComponent({
await showDialog({
title,
type: 'error',
detail: this.t`Following cells have errors: ${cellErrors.join(', ')}.`,
detail: this.t`Following cells have errors: ${cellErrors.join(
', '
)}.`,
});
return false;
}