fix: prevent Save and Submit appearing together

fyo/model/doc.ts

@@ -157,6 +157,74 @@ export class Doc extends Observable<DocValue | Doc[]> {
     return false;
   }
 
+  get canSave() {
+    if (!!this.submitted) {
+      return false;
+    }
+
+    if (!!this.cancelled) {
+      return false;
+    }
+
+    if (!this.dirty) {
+      return false;
+    }
+
+    if (!this.notInserted) {
+      return false;
+    }
+
+    return true;
+  }
+
+  get canSubmit() {
+    if (!this.schema.isSubmittable) {
+      return false;
+    }
+
+    if (this.dirty) {
+      return false;
+    }
+
+    if (this.notInserted) {
+      return false;
+    }
+
+    if (!!this.submitted) {
+      return false;
+    }
+
+    if (!!this.cancelled) {
+      return false;
+    }
+
+    return true;
+  }
+
+  get canCancel() {
+    if (!this.schema.isSubmittable) {
+      return false;
+    }
+
+    if (this.dirty) {
+      return false;
+    }
+
+    if (this.notInserted) {
+      return false;
+    }
+
+    if (!!this.cancelled) {
+      return false;
+    }
+
+    if (!this.submitted) {
+      return false;
+    }
+
+    return true;
+  }
+
   _setValuesWithoutChecks(data: DocValueMap, convertToDocValue: boolean) {
     for (const field of this.schema.fields) {
       const { fieldname, fieldtype } = field;

src/pages/GeneralForm.vue

@@ -14,19 +14,12 @@
         </p>
         <feather-icon v-else name="more-horizontal" class="w-4 h-4" />
       </DropdownWithActions>
-      <Button
+      <Button v-if="doc.canSave" type="primary" @click="sync">
-        v-if="doc?.notInserted || doc?.dirty"
-        type="primary"
-        @click="sync"
-      >
         {{ t`Save` }}
       </Button>
-      <Button
+      <Button v-else-if="doc.canSubmit" type="primary" @click="submit">{{
-        v-if="!doc?.dirty && !doc?.notInserted && !doc?.submitted"
+        t`Submit`
-        type="primary"
+      }}</Button>
-        @click="submit"
-        >{{ t`Submit` }}</Button
-      >
     </template>
 
     <!-- Form Header -->

src/pages/InvoiceForm.vue

@@ -38,19 +38,12 @@
         </p>
         <feather-icon v-else name="more-horizontal" class="w-4 h-4" />
       </DropdownWithActions>
-      <Button
+      <Button v-if="doc.canSave" type="primary" @click="sync">
-        v-if="doc?.notInserted || doc?.dirty"
-        type="primary"
-        @click="sync"
-      >
         {{ t`Save` }}
       </Button>
-      <Button
+      <Button v-else-if="doc.canSubmit" type="primary" @click="submit">{{
-        v-if="!doc?.dirty && !doc?.notInserted && !doc?.submitted"
+        t`Submit`
-        type="primary"
+      }}</Button>
-        @click="submit"
-        >{{ t`Submit` }}</Button
-      >
     </template>
 
     <!-- Invoice Form -->

src/pages/JournalEntryForm.vue

@@ -15,7 +15,7 @@
         <feather-icon v-else name="more-horizontal" class="w-4 h-4" />
       </DropdownWithActions>
       <Button
-        v-if="doc?.notInserted || doc?.dirty"
+        v-if="doc.canSave"
         type="primary"
         class="text-white text-xs"
         @click="sync"
@@ -23,7 +23,7 @@
         {{ t`Save` }}
       </Button>
       <Button
-        v-else-if="!doc.dirty && !doc.notInserted && !doc.submitted"
+        v-else-if="doc.canSubmit"
         type="primary"
         class="text-white text-xs"
         @click="submit"

src/pages/QuickEditForm.vue

@@ -26,7 +26,7 @@
           :icon="true"
           @click="sync"
           type="primary"
-          v-if="doc?.dirty || doc?.notInserted"
+          v-if="doc.canSave"
           class="text-white text-xs"
         >
           {{ t`Save` }}
@@ -35,12 +35,7 @@
           :icon="true"
           @click="submit"
           type="primary"
-          v-if="
+          v-else-if="doc.canSubmit"
-            schema?.isSubmittable &&
-            !doc?.submitted &&
-            !doc?.notInserted &&
-            !(doc?.cancelled || false)
-          "
           class="text-white text-xs"
         >
           {{ t`Submit` }}

src/utils/ui.ts

@@ -318,7 +318,7 @@ function getCancelAction(doc: Doc): Action {
     component: {
       template: '<span class="text-red-700">{{ t`Cancel` }}</span>',
     },
-    condition: (doc: Doc) => doc.isSubmitted,
+    condition: (doc: Doc) => doc.canCancel,
     async action() {
       const res = await cancelDocWithPrompt(doc);