agerix/iconify
2
0
Fork 0
mirror of https://github.com/iconify/iconify.git synced 2024-11-09 23:00:56 +00:00
Code Issues Releases Activity

Remove IE10 attributes from SVGs in components

Browse Source
This commit is contained in:
Vjacheslav Trushkin 2020-12-16 12:04:21 +02:00
parent 3e4e42a723
commit 0a10453ee9
6 changed files with 12 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
archive/vue2/src/IconifyIcon.ts
View File

@ -78,7 +78,6 @@ const svgDefaults = {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlns:xlink': 'http://www.w3.org/1999/xlink', 'xmlns:xlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
}; };

1
packages/react/src/icon.ts
View File

@ -71,7 +71,6 @@ const svgDefaults: IconifySVGProps = {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'xmlnsXlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
'style': {}, // Include style if it isn't set to add verticalAlign later 'style': {}, // Include style if it isn't set to add verticalAlign later
}; };

5
packages/react/tests/icon.test.js
View File

@ -27,7 +27,6 @@ describe('Creating component', () => {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'xmlnsXlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
'style': {}, 'style': {},
'dangerouslySetInnerHTML': { 'dangerouslySetInnerHTML': {
@ -52,7 +51,6 @@ describe('Creating component', () => {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'xmlnsXlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
'style': { 'style': {
verticalAlign: '-0.125em', verticalAlign: '-0.125em',
@ -80,7 +78,6 @@ describe('Creating component', () => {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'xmlnsXlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
'style': {}, 'style': {},
'dangerouslySetInnerHTML': { 'dangerouslySetInnerHTML': {
@ -122,7 +119,6 @@ describe('Creating component', () => {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'xmlnsXlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
'style': {}, 'style': {},
'dangerouslySetInnerHTML': { 'dangerouslySetInnerHTML': {
@ -164,7 +160,6 @@ describe('Creating component', () => {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'xmlnsXlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
'style': {}, 'style': {},
'dangerouslySetInnerHTML': { 'dangerouslySetInnerHTML': {

1
packages/svelte/src/generate-icon.js
View File

@ -16,7 +16,6 @@ const svgDefaults = {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlns:xlink': 'http://www.w3.org/1999/xlink', 'xmlns:xlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
}; };

1
packages/vue/src/IconifyIcon.ts
View File

@ -68,7 +68,6 @@ const svgDefaults = {
'xmlns': 'http://www.w3.org/2000/svg', 'xmlns': 'http://www.w3.org/2000/svg',
'xmlns:xlink': 'http://www.w3.org/1999/xlink', 'xmlns:xlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true, 'aria-hidden': true,
'focusable': false,
'role': 'img', 'role': 'img',
}; };

24
packages/vue/tests/icon.test.js
View File

@ -38,7 +38,7 @@ describe('Mounting component', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 16 16"></svg>' '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 16 16"></svg>'
); );
}); });
}); });
@ -59,7 +59,7 @@ describe('Rendering icon', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -83,7 +83,7 @@ describe('Rendering icon', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -117,7 +117,7 @@ describe('Rendering icon', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M16 8.414l-4.5-4.5L4.414 11H6v8h3v-6h5v6h3v-8h1.586L17 9.414V6h-1v2.414zM2 12l9.5-9.5L15 6V5h3v4l3 3h-3v7.998h-5v-6h-3v6H5V12H2z" fill="currentColor"></path>' + '<path d="M16 8.414l-4.5-4.5L4.414 11H6v8h3v-6h5v6h3v-8h1.586L17 9.414V6h-1v2.414zM2 12l9.5-9.5L15 6V5h3v4l3 3h-3v7.998h-5v-6h-3v6H5V12H2z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -151,7 +151,7 @@ describe('Rendering icon', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M8 13v-1h7v1H8zm7.5-6a5.5 5.5 0 1 1 0 11H13v-1h2.5a4.5 4.5 0 1 0 0-9H13V7h2.5zm-8 11a5.5 5.5 0 1 1 0-11H10v1H7.5a4.5 4.5 0 1 0 0 9H10v1H7.5z" fill="currentColor"></path>' + '<path d="M8 13v-1h7v1H8zm7.5-6a5.5 5.5 0 1 1 0 11H13v-1h2.5a4.5 4.5 0 1 0 0-9H13V7h2.5zm-8 11a5.5 5.5 0 1 1 0-11H10v1H7.5a4.5 4.5 0 1 0 0 9H10v1H7.5z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -191,7 +191,7 @@ describe('Passing attributes', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" title="Icon!" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" title="Icon!" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -212,7 +212,7 @@ describe('Passing attributes', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" focusable="false" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -233,7 +233,7 @@ describe('Passing attributes', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" focusable="false" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" role="img" width="1em" height="1em" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -255,7 +255,7 @@ describe('Passing attributes', () => {
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
// same values, but different order // same values, but different order
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" viewBox="0 0 24 24" preserveAspectRatio="xMidYMid meet" width="1em" height="1em">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" viewBox="0 0 24 24" preserveAspectRatio="xMidYMid meet" width="1em" height="1em">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -279,7 +279,7 @@ describe('Dimensions', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="24" height="24" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="24" height="24" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -302,7 +302,7 @@ describe('Dimensions', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="32" height="48" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="32" height="48" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );
@ -324,7 +324,7 @@ describe('Dimensions', () => {
const item = wrapper; //.findComponent(Icon); const item = wrapper; //.findComponent(Icon);
expect(item.exists()).toBe(true); expect(item.exists()).toBe(true);
expect(item.html()).toStrictEqual( expect(item.html()).toStrictEqual(
'<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" focusable="false" role="img" width="24" height="24" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' + '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true" role="img" width="24" height="24" preserveAspectRatio="xMidYMid meet" viewBox="0 0 24 24">' +
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' + '<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"></path>' +
'</svg>' '</svg>'
); );