Without this change, when building images with --cache-to-registry,
BuildKit uses a proprietary cache artifact format, which breaks
when using third-party registries such as Harbor or ECR.
By adding the image-manifest=true option, BuildKit uses an
OCI-compliant cache artifact format that should be compatible with all
registries. This option requires BuildKit 0.12 or later (check with
"docker buildx ls").
See https://github.com/goharbor/harbor/issues/18941 and
https://github.com/moby/buildkit/issues/2251 for background
information.
Co-authored-by: Andrés González <andres@aulasneo.com>
Fixes #1118.
The introduction of the `-c/--clean` option caused the deletion prompt
to be displayed for every call to `tutor config save --interactive`.
This is not the desired behaviour, as decided here:
https://github.com/overhangio/tutor/pull/1086#discussion_r1681744804
With this change, the prompt is only displayed when running: `tutor
config save --interactive --clean`. The environment is still deleted on
`tutor config save --clean`, but without prompt.
We refactored the code with hooks, which simplifies the signature of the
interactive prompt function.
* fix: upgrade MySQL from 5.7 to 8.1 first and then to 8.4
This is required when upgrading from Tutor v15 to v18 directly
MySQL does not allow direct upgrades from v5.7 to v8.4
* fix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood (#1140)
We do this because MySQL 8.1 does not have the --mysql-native-password option
We have this option turned on for backward compatibility
In development, edx-platform runs with CELERY_ALWAYS_EAGER=True, which
means that lms-worker and cms-worker never catch celery tasks!
This change was heavily inspired by: https://github.com/overhangio/tutor/pull/1041
I found myself in a situation where I wasn't sure if a patch was
correctly added by the Indigo plugin. To troubleshoot that issue, I
wanted to print that rendered patch. I thought it would make a nice
addition to the CLI.
Currently, we are asking devs to set this env var manually before they run tests.
We may as well save them some keystrokes by setting it in the dev image
programmatically.
* fix: add --mysql-native-password=ON param to fix broken connection, fixes #1089
For tutor instances that were created with tutor 15 and earlier and then upgraded to tutor 18, the launch process would fail as MySQL connection could not be made. This is because mysql-native-password was removed in MySQL 8.4.0. We turn it on temporarily to fix failing connections.
With the latest Docker upgrade, we got the following warnings during
build:
FromAsCasing: 'as' and 'FROM' keywords' casing do not match
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
