mirror of
https://github.com/ChristianLight/tutor.git
synced 2024-11-16 01:57:16 +00:00
56a7614fd7
When a user registers, they receive a confirmation email. This email contained two links to "https://example.com/..." urls. This was caused by the fact that the default site, indicated by SITE_ID=1, was example.com. We resolve this issue by setting instead SITE_ID=2, which should point to the site with the LMS domain name. This is a potentially breaking change for platforms that have manually set to 1 the id of the LMS site in the database. These platforms should now set SITE_ID=1 via a plugin. Alternatives we have considered include modifying the id field of the LMS site in the database. Unfortunately such a change would have important consequences, as the site ID is used as a foreign key for other models. Note that non-https sites still include https links in the registration emails. This is because the "https" scheme is hardcoded by the "ensure_url_is_absolute" utility function. So there is nothing we can do about this without making changes upstream. Close #572. |
||
|---|---|---|
| .. | ||
| scriv | ||
| 20230106_163518_regis_fix_example_com_links.md | ||
| 20230109_100009_codewithemad_upgrade_mysql_issue.md | ||
| scriv.ini | ||