Fixed gh-373 so that the auto update of selection is only triggered when toggling the all selection button.

2019-02-06 11:32:38 +02:00 · 2019-02-06 11:32:38 +02:00 · 104c4e6bae
commit 104c4e6bae
parent 1a538e71d7
8 changed files with 22 additions and 26 deletions
--- a/README.md
+++ b/README.md
@ -12,7 +12,7 @@ The Component Builder for [Joomla](https://extensions.joomla.org/extension/compo

 Whether you're a seasoned [Joomla](https://extensions.joomla.org/extension/component-builder/) developer, or have just started, Component Builder will safe you lots of time and money. A real must have!

-You can install it quite easily and with no limitations. On [github](https://github.com/vdm-io/Joomla-Component-Builder/releases) is the latest release (2.9.10) with **ALL** its features and **ALL** concepts totally open-source and free! 
+You can install it quite easily and with no limitations. On [github](https://github.com/vdm-io/Joomla-Component-Builder/releases) is the latest release (2.9.11) with **ALL** its features and **ALL** concepts totally open-source and free! 

 > Watch Quick Build of a Hello World component in [JCB on Youtube](https://www.youtube.com/watch?v=IQfsLYIeblk&list=PLQRGFI8XZ_wtGvPQZWBfDzzlERLQgpMRE&index=45)

@ -144,11 +144,11 @@ TODO
 + *Author*: [Llewellyn van der Merwe](mailto:llewellyn@joomlacomponentbuilder.com)
 + *Name*: [Component Builder](https://github.com/vdm-io/Joomla-Component-Builder)
 + *First Build*: 30th April, 2015
-+ *Last Build*: 31st January, 2019
-+ *Version*: 2.9.10
+ *Last Build*: 6th February, 2019
+ *Version*: 2.9.11
 + *Copyright*: Copyright (C) 2015 - 2018 Vast Development Method. All rights reserved.
 + *License*: GNU General Public License version 2 or later; see LICENSE.txt
-+ *Line count*: **195869**
+ *Line count*: **195865**
 + *Field count*: **1089**
 + *File count*: **1277**
 + *Folder count*: **201**
--- a/admin/README.txt
+++ b/admin/README.txt
@ -12,7 +12,7 @@ The Component Builder for [Joomla](https://extensions.joomla.org/extension/compo

 Whether you're a seasoned [Joomla](https://extensions.joomla.org/extension/component-builder/) developer, or have just started, Component Builder will safe you lots of time and money. A real must have!

-You can install it quite easily and with no limitations. On [github](https://github.com/vdm-io/Joomla-Component-Builder/releases) is the latest release (2.9.10) with **ALL** its features and **ALL** concepts totally open-source and free! 
+You can install it quite easily and with no limitations. On [github](https://github.com/vdm-io/Joomla-Component-Builder/releases) is the latest release (2.9.11) with **ALL** its features and **ALL** concepts totally open-source and free! 

 > Watch Quick Build of a Hello World component in [JCB on Youtube](https://www.youtube.com/watch?v=IQfsLYIeblk&list=PLQRGFI8XZ_wtGvPQZWBfDzzlERLQgpMRE&index=45)

@ -144,11 +144,11 @@ TODO
 + *Author*: [Llewellyn van der Merwe](mailto:llewellyn@joomlacomponentbuilder.com)
 + *Name*: [Component Builder](https://github.com/vdm-io/Joomla-Component-Builder)
 + *First Build*: 30th April, 2015
-+ *Last Build*: 31st January, 2019
-+ *Version*: 2.9.10
+ *Last Build*: 6th February, 2019
+ *Version*: 2.9.11
 + *Copyright*: Copyright (C) 2015 - 2018 Vast Development Method. All rights reserved.
 + *License*: GNU General Public License version 2 or later; see LICENSE.txt
-+ *Line count*: **195869**
+ *Line count*: **195865**
 + *Field count*: **1089**
 + *File count*: **1277**
 + *Folder count*: **201**
--- a/admin/controllers/joomla_components.php
+++ b/admin/controllers/joomla_components.php
@ -286,13 +286,13 @@ class ComponentbuilderControllerJoomla_components extends JControllerAdmin
 		$model = componentbuilderHelper::getModel('joomla_components', JPATH_ADMINISTRATOR . '/components/com_componentbuilder');
 		// set user
 		$model->user = $this->getApiUser();
+		// make sure to set active type (adding this script from custom code :)
+		$model->activeType = 'manualBackup';
 		// check if export is allowed for this user. (we need this sorry)
 		if ($model->user->authorise('joomla_component.export', 'com_componentbuilder') && $model->user->authorise('core.export', 'com_componentbuilder'))
 		{
 			// get all component IDs to backup
 			$pks = componentbuilderHelper::getComponentIDs();
-			// make sure to set active type to backup
-			$model->activeType = 'manualBackup';
 			// set auto loader
 			ComponentbuilderHelper::autoLoader('smart');
 			// manual backup message
@ -413,7 +413,7 @@ class ComponentbuilderControllerJoomla_components extends JControllerAdmin
 				}				
 			}
 			// quite only if auto backup (adding this script from custom code :)
-			if ('backup' === 'manualBackup')
+			if ('backup' === $model->activeType)
 			{
 				echo "# " . $backupNoticeStatus . "\n" .implode("\n", $backupNotice);
 				// clear session
@ -424,7 +424,7 @@ class ComponentbuilderControllerJoomla_components extends JControllerAdmin
 			return;
 		}
 		// quite only if auto backup (adding this script from custom code :)
-		if ('backup' === 'manualBackup')
+		if ('backup' === $model->activeType)
 		{
 			echo "# Error\n" . JText::_('COM_COMPONENTBUILDER_ACCESS_DENIED');
 			// clear session
--- a/admin/models/forms/dynamic_get.js
+++ b/admin/models/forms/dynamic_get.js
@ -1523,10 +1523,6 @@ jQuery(document).ready(function()
 	getLinked();
 	var valueSwitch = jQuery("#jform_add_php_router_parse input[type='radio']:checked").val();
 	getDynamicScripts(valueSwitch);
-	// get the selected value of the select_all
-	var select_all =  jQuery("#jform_select_all input[type='radio']:checked").val();
-	// make sure the selection is correct
-	setSelectAll(select_all);
 	// check and load all the custom code edit buttons
 	getEditCustomCodeButtons();
 });
--- a/componentbuilder.xml
+++ b/componentbuilder.xml
@ -1,15 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <extension type="component" version="3.2" method="upgrade">
 	<name>COM_COMPONENTBUILDER</name>
-	<creationDate>31st January, 2019</creationDate>
+	<creationDate>6th February, 2019</creationDate>
 	<author>Llewellyn van der Merwe</author>
 	<authorEmail>llewellyn@joomlacomponentbuilder.com</authorEmail>
 	<authorUrl>http://www.joomlacomponentbuilder.com</authorUrl>
 	<copyright>Copyright (C) 2015 - 2018 Vast Development Method. All rights reserved.</copyright>
 	<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
-	<version>2.9.10</version>
+	<version>2.9.11</version>
 	<description><![CDATA[
-		<h1>Component Builder (v.2.9.10)</h1>
+		<h1>Component Builder (v.2.9.11)</h1>
 		<div style="clear: both;"></div>
 		<p>The Component Builder for [Joomla](https://extensions.joomla.org/extension/component-builder/) is highly advanced tool that is truly able to build extremely complex components in a fraction of the time.

--- a/componentbuilder_update_server.xml
+++ b/componentbuilder_update_server.xml
@ -582,10 +582,10 @@
 		<description>Builds Complex Joomla Components</description>
 		<element>com_componentbuilder</element>
 		<type>component</type>
-		<version>2.9.10</version>
+		<version>2.9.11</version>
 		<infourl title="Component Builder!">http://www.joomlacomponentbuilder.com</infourl>
 		<downloads>
-			<downloadurl type="full" format="zip">https://github.com/vdm-io/Joomla-Component-Builder/releases/download/v2.9.10/JCB_v2.9.10.zip</downloadurl>
+			<downloadurl type="full" format="zip">https://github.com/vdm-io/Joomla-Component-Builder/releases/download/v2.9.11/JCB_v2.9.11.zip</downloadurl>
 		</downloads>
 		<tags>
 			<tag>stable</tag>
--- a/script.php
+++ b/script.php
@ -5172,7 +5172,7 @@ class com_componentbuilderInstallerScript
 			echo '<a target="_blank" href="http://www.joomlacomponentbuilder.com" title="Component Builder">
 				<img src="components/com_componentbuilder/assets/images/vdm-component.jpg"/>
 				</a>
-				<h3>Upgrade to Version 2.9.10 Was Successful! Let us know if anything is not working as expected.</h3>';
+				<h3>Upgrade to Version 2.9.11 Was Successful! Let us know if anything is not working as expected.</h3>';
 		}
 	}

--- a/site/controllers/api.php
+++ b/site/controllers/api.php
@ -44,13 +44,13 @@ class ComponentbuilderControllerApi extends JControllerForm
 		$model = componentbuilderHelper::getModel('joomla_components', JPATH_ADMINISTRATOR . '/components/com_componentbuilder');
 		// set user
 		$model->user = $this->getApiUser();
+		// make sure to set active type (adding this script from custom code :)
+		$model->activeType = 'backup';
 		// check if export is allowed for this user. (we need this sorry)
 		if ($model->user->authorise('joomla_component.export', 'com_componentbuilder') && $model->user->authorise('core.export', 'com_componentbuilder'))
 		{
 			// get all component IDs to backup
 			$pks = componentbuilderHelper::getComponentIDs();
-			// make sure to set active type to backup
-			$model->activeType = 'backup';
 			// set auto loader
 			ComponentbuilderHelper::autoLoader('smart');
 			// manual backup message
@ -171,7 +171,7 @@ class ComponentbuilderControllerApi extends JControllerForm
 				}				
 			}
 			// quite only if auto backup (adding this script from custom code :)
-			if ('backup' === 'backup')
+			if ('backup' === $model->activeType)
 			{
 				echo "# " . $backupNoticeStatus . "\n" .implode("\n", $backupNotice);
 				// clear session
@ -182,7 +182,7 @@ class ComponentbuilderControllerApi extends JControllerForm
 			return;
 		}
 		// quite only if auto backup (adding this script from custom code :)
-		if ('backup' === 'backup')
+		if ('backup' === $model->activeType)
 		{
 			echo "# Error\n" . JText::_('COM_COMPONENTBUILDER_ACCESS_DENIED');
 			// clear session