Stable release of v3.2.0-beta1
Move beta to main repo. Fix #1053 so that the right and left tabs display correctly in Joomla 4&5.
This commit is contained in:
@ -12,8 +12,13 @@
|
||||
// No direct access to this file
|
||||
defined('_JEXEC') or die('Restricted access');
|
||||
|
||||
use Joomla\CMS\Factory;
|
||||
use Joomla\CMS\MVC\Controller\BaseController;
|
||||
use Joomla\CMS\Router\Route;
|
||||
use Joomla\Utilities\ArrayHelper;
|
||||
use Joomla\CMS\Language\Text;
|
||||
use VDM\Joomla\Utilities\StringHelper;
|
||||
use VDM\Joomla\Utilities\ArrayHelper as UtilitiesArrayHelper;
|
||||
|
||||
/**
|
||||
* Componentbuilder Component Base Controller
|
||||
@ -32,51 +37,51 @@ class ComponentbuilderController extends BaseController
|
||||
function display($cachable = false, $urlparams = false)
|
||||
{
|
||||
// set default view if not set
|
||||
$view = $this->input->getCmd('view', '');
|
||||
$view = $this->input->getCmd('view', '');
|
||||
$this->input->set('view', $view);
|
||||
$isEdit = $this->checkEditView($view);
|
||||
$layout = $this->input->get('layout', null, 'WORD');
|
||||
$id = $this->input->getInt('id');
|
||||
// $cachable = true; (TODO) working on a fix [gh-238](https://github.com/vdm-io/Joomla-Component-Builder/issues/238)
|
||||
|
||||
$isEdit = $this->checkEditView($view);
|
||||
$layout = $this->input->get('layout', null, 'WORD');
|
||||
$id = $this->input->getInt('id');
|
||||
// $cachable = true; (TODO) working on a fix [gh-238](https://github.com/vdm-io/Joomla-Component-Builder/issues/238)
|
||||
|
||||
// insure that the view is not cashable if edit view or if user is logged in
|
||||
$user = JFactory::getUser();
|
||||
$user = Factory::getUser();
|
||||
if ($user->get('id') || $isEdit)
|
||||
{
|
||||
$cachable = false;
|
||||
}
|
||||
|
||||
|
||||
// Check for edit form.
|
||||
if($isEdit)
|
||||
{
|
||||
if ($layout == 'edit' && !$this->checkEditId('com_componentbuilder.edit.'.$view, $id))
|
||||
{
|
||||
// Somehow the person just went to the form - we don't allow that.
|
||||
$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
|
||||
$this->setError(Text::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
|
||||
$this->setMessage($this->getError(), 'error');
|
||||
// check if item was opend from other then its own list view
|
||||
$ref = $this->input->getCmd('ref', 0);
|
||||
$refid = $this->input->getInt('refid', 0);
|
||||
$ref = $this->input->getCmd('ref', 0);
|
||||
$refid = $this->input->getInt('refid', 0);
|
||||
// set redirect
|
||||
if ($refid > 0 && ComponentbuilderHelper::checkString($ref))
|
||||
if ($refid > 0 && StringHelper::check($ref))
|
||||
{
|
||||
// redirect to item of ref
|
||||
$this->setRedirect(JRoute::_('index.php?option=com_componentbuilder&view='.(string)$ref.'&layout=edit&id='.(int)$refid, false));
|
||||
$this->setRedirect(Route::_('index.php?option=com_componentbuilder&view='.(string)$ref.'&layout=edit&id='.(int)$refid, false));
|
||||
}
|
||||
elseif (ComponentbuilderHelper::checkString($ref))
|
||||
elseif (StringHelper::check($ref))
|
||||
{
|
||||
// redirect to ref
|
||||
$this->setRedirect(JRoute::_('index.php?option=com_componentbuilder&view='.(string)$ref, false));
|
||||
$this->setRedirect(Route::_('index.php?option=com_componentbuilder&view='.(string)$ref, false));
|
||||
}
|
||||
else
|
||||
{
|
||||
// normal redirect back to the list default site view
|
||||
$this->setRedirect(JRoute::_('index.php?option=com_componentbuilder&view=', false));
|
||||
$this->setRedirect(Route::_('index.php?option=com_componentbuilder&view=', false));
|
||||
}
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
// we may need to make this more dynamic in the future. (TODO)
|
||||
$safeurlparams = array(
|
||||
'catid' => 'INT',
|
||||
@ -97,9 +102,9 @@ class ComponentbuilderController extends BaseController
|
||||
'Itemid' => 'INT');
|
||||
|
||||
// should these not merge?
|
||||
if (ComponentbuilderHelper::checkArray($urlparams))
|
||||
if (UtilitiesArrayHelper::check($urlparams))
|
||||
{
|
||||
$safeurlparams = ComponentbuilderHelper::mergeArrays(array($urlparams, $safeurlparams));
|
||||
$safeurlparams = UtilitiesArrayHelper::merge(array($urlparams, $safeurlparams));
|
||||
}
|
||||
|
||||
return parent::display($cachable, $safeurlparams);
|
||||
@ -107,7 +112,7 @@ class ComponentbuilderController extends BaseController
|
||||
|
||||
protected function checkEditView($view)
|
||||
{
|
||||
if (ComponentbuilderHelper::checkString($view))
|
||||
if (StringHelper::check($view))
|
||||
{
|
||||
$views = array(
|
||||
|
||||
|
Reference in New Issue
Block a user