Compiler cross-browser fix, zero order fix, typo fix and improved default values. #109

Merged
Llewellyn merged 4 commits from staging into master 6 years ago
Owner
  • Fixed gh-106 to insure the correct form is submitted on compile, also some other minor bug fixes
  • Improved the answer for gh-106 to insure the correct form is submitted on compile
  • Fixed gh-108 to insure that all fields get added if multiple zeros are found. Improved the default value options in global config to allow for array of default values. Fixed typo forward slash.
- Fixed gh-106 to insure the correct form is submitted on compile, also some other minor bug fixes - Improved the answer for gh-106 to insure the correct form is submitted on compile - Fixed gh-108 to insure that all fields get added if multiple zeros are found. Improved the default value options in global config to allow for array of default values. Fixed typo forward slash.
ro-ot (Migrated from github.com) reviewed 6 years ago
ro-ot commented 6 years ago (Migrated from github.com)
Poster
Owner

Can review this now, only next week if still needed.

Can review this now, only next week if still needed.
Flicka2510 commented 6 years ago (Migrated from github.com)
Poster
Owner

I have tested this, and the compiler works in Chrome, Firefox and Safari. Also an admin view that has no ordering set on fields, works as expected. All fields are loaded.

I have tested this, and the compiler works in Chrome, Firefox and Safari. Also an admin view that has no ordering set on fields, works as expected. All fields are loaded.

Reviewers

The pull request has been merged as ddeb02de74.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b staging master
git pull origin staging

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff staging
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#109
Loading…
There is no content yet.