Initial JCB API #110

2017-08-20T17:56:23Z

Llewellyn commented

2017-08-20 17:56:23 +00:00

Added JCB initial API frontend to run backups of JCB components
Setup automated backup system with cronjob.
Added email helper to send backup key to trusted email address

- Added JCB initial API frontend to run backups of JCB components - Setup automated backup system with cronjob. - Added email helper to send backup key to trusted email address

ro-ot (Migrated from github.com) reviewed

2017-08-20 19:20:03 +00:00

admin/compiler/joomla_3/Helper.php

ro-ot (Migrated from github.com) commented

2017-08-20 19:20:03 +00:00

This is much better!

ro-ot (Migrated from github.com) reviewed

2017-08-20 19:21:46 +00:00

admin/compiler/joomla_3/Helper_email.php

ro-ot (Migrated from github.com) commented

2017-08-20 19:21:46 +00:00

Maybe this function name should show it is loading the html in a table row.

ro-ot (Migrated from github.com) reviewed

2017-08-20 19:23:01 +00:00

admin/compiler/joomla_3/Helper_site.php

ro-ot (Migrated from github.com) commented

2017-08-20 19:23:01 +00:00

This will break getVars calls already in use!

ro-ot (Migrated from github.com) reviewed

2017-08-20 19:26:39 +00:00

admin/helpers/componentbuilderemail.php

						
				@@ -0,0 +101,4 @@

							// get the global details

							$globalConf	= JFactory::getConfig();

							$mailer		= $globalConf->get('mailer');

ro-ot (Migrated from github.com) commented

2017-08-20 19:26:39 +00:00

There are some new values that could be used from the global mailer.

Llewellyn reviewed

2017-08-20 19:40:27 +00:00

admin/compiler/joomla_3/Helper_email.php

Llewellyn commented

2017-08-20 19:40:27 +00:00

like setTableHtmlBody($html, $subject) ?

like `setTableHtmlBody($html, $subject)` ?

Llewellyn reviewed

2017-08-20 19:41:31 +00:00

admin/compiler/joomla_3/Helper_site.php

Llewellyn commented

2017-08-20 19:41:31 +00:00

oops... this was an accident, I was trying something and then saw it will not work, but did not change it back. Thanks!

ro-ot (Migrated from github.com) reviewed

2017-08-20 20:21:53 +00:00

admin/compiler/joomla_3/Helper_email.php

ro-ot (Migrated from github.com) commented

2017-08-20 20:21:53 +00:00

What about?

setTableBody($html, $subject)

Short and sweet.

What about? ``` setTableBody($html, $subject) ``` Short and sweet.

ro-ot commented

2017-08-20 20:53:58 +00:00

(Migrated from github.com)

Since this brings many new files and concepts to JCB I think the version should jump to 2.5

This will insure that all who knows how versioning works will take notice that a fairly big change is happening. I mean you are adding a front-end to JCB starting with a very basic API controller the does backups. I like what you are doing, just a lot of code doing nothing... is there not a way just to add a controller?

I mean can we not adapt JCB to be able to just build a controller if the site view and model is not even being used?

Since this brings many new files and concepts to JCB I think the version should jump to 2.5 This will insure that all who knows how versioning works will take notice that a fairly big change is happening. I mean you are adding a front-end to JCB starting with a very basic API controller the does backups. I like what you are doing, just a lot of code doing nothing... is there not a way just to add a controller? I mean can we not adapt JCB to be able to just build a controller if the site view and model is not even being used?

ro-ot (Migrated from github.com) approved these changes

2017-08-21 12:06:53 +00:00

ro-ot (Migrated from github.com) left a comment

The backup system works well. I have also not seen any other issues, look good!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#110