Assets Rules Improvment #114

Merged

Llewellyn merged 4 commits from staging into master

2017-08-23 21:14:51 +00:00

Llewellyn commented

2017-08-22 22:19:10 +00:00

Owner

added site-view switch to allow default public access if access is set on the site view as explained in gh-113

- added site-view switch to allow default public access if access is set on the site view as explained in gh-113

mwweb (Migrated from github.com) reviewed 2017-08-22 22:19:10 +00:00

ro-ot (Migrated from github.com) reviewed 2017-08-22 22:29:50 +00:00

admin/views/admin_views/view.html.php

ro-ot (Migrated from github.com) commented

2017-08-22 22:29:50 +00:00

Author

Owner

This is a bug, or do you really want the import of components to show in every backend view? I must have missed this before. Sorry!

Llewellyn reviewed 2017-08-22 22:31:14 +00:00

admin/views/admin_views/view.html.php

Llewellyn commented

2017-08-22 22:31:14 +00:00

Author

Owner

no you are right... This is a bug!

ro-ot (Migrated from github.com) reviewed 2017-08-22 22:48:45 +00:00

admin/views/joomla_components/view.html.php

ro-ot (Migrated from github.com) commented

2017-08-22 22:48:45 +00:00

Author

Owner

Why did you move this? the buttons are now no longer next to each other.

ro-ot (Migrated from github.com) reviewed 2017-08-22 22:53:41 +00:00

admin/helpers/compiler/e_Interpretation.php

ro-ot (Migrated from github.com) commented

2017-08-22 22:53:41 +00:00

Author

Owner

Nice so we can just extend on this assetsRules for the fields and back-ends. So it works just like the old paramsBuilder now extensionsParams. I think this will work great!

Nice so we can just extend on this **assetsRules** for the fields and back-ends. So it works just like the old **paramsBuilder** now **extensionsParams**. I think this will work great!

Llewellyn reviewed 2017-08-22 22:57:17 +00:00

admin/views/joomla_components/view.html.php

Llewellyn commented

2017-08-22 22:57:17 +00:00

Author

Owner

Well if you removed all components then you could not import any... so I moved the button to function only that does not requirer a selection, so it will show even if there is no items. I can see it messed up the lineup... 👎 will see if we can fix that. But it has to show even if there is no items.

Well if you removed all components then you could not import any... so I moved the button to function only that does not requirer a selection, so it will show even if there is no items. I can see it messed up the lineup... :-1: will see if we can fix that. But it has to show even if there is no items.

Llewellyn reviewed 2017-08-22 22:57:33 +00:00

admin/helpers/compiler/e_Interpretation.php

Llewellyn commented

2017-08-22 22:57:33 +00:00

Author

Owner

Yea it is a start!

Llewellyn commented

2017-08-23 14:55:14 +00:00

Author

Owner

@mwweb is this working for you? can I bump the version upgrade?

ro-ot (Migrated from github.com) approved these changes 2017-08-23 15:14:21 +00:00

mwweb commented

2017-08-23 19:44:40 +00:00

(Migrated from github.com)

Author

Owner

This worked fine on the demo component.

I think this is a good start on it. At least the site views can be automatically set to public. Perhaps sometime in the future we can look at, and discuss, extending this even further. An example, create and edit permissions you generally wouldn't want public, but at least registered. But that can be a start.

This worked fine on the demo component. I think this is a good start on it. At least the site views can be automatically set to public. Perhaps sometime in the future we can look at, and discuss, extending this even further. An example, create and edit permissions you generally wouldn't want public, but at least registered. But that can be a start.