Major Upgrade away from repeatable fields in Joomla component view.

Llewellyn commented

2017-10-26 16:47:00 +00:00

Owner

Added status, copy and delete sync between admin_view linked views (admin_fields, admin_fields_conditions).
Added notice of language (tanslations) added or not added with details to compiler
Resolved gh-146 compiler error on joined db in dinamic get thanks to @mwweb & @ro-ot
Resolved gh-147 by adding the sort of fields back into the save method
Resolved gh-144 to ensure that the published tab (fields overwriting and adding) option is available again.
Resolved gh-145 by moving the subforms to their own tab in dynamic get view
Converted all repeatable fields to subform fields in Joomla component view
Moved 9 subforms and other fields to their own table and view (decopuling them fom Joomla component view), that means we added 9 more views and tables to JCB
Added all the ajax for buttons and display views to Joomla component view
Added tmp scripts all across the new areas with subforms to ensure all repeatable fields are converted. Will be removed in v2.7.0
Added synced copy, change state and delete in Joomla components view in relation to all tables linked to it (same as with admin views)

- Added status, copy and delete sync between admin_view linked views (admin_fields, admin_fields_conditions). - Added notice of language (tanslations) added or not added with details to compiler - Resolved gh-146 compiler error on joined db in dinamic get thanks to @mwweb & @ro-ot - Resolved gh-147 by adding the sort of fields back into the save method - Resolved gh-144 to ensure that the published tab (fields overwriting and adding) option is available again. - Resolved gh-145 by moving the subforms to their own tab in dynamic get view - Converted all repeatable fields to subform fields in Joomla component view - Moved 9 subforms and other fields to their own table and view (decopuling them fom Joomla component view), that means we added 9 more views and tables to JCB - Added all the ajax for buttons and display views to Joomla component view - Added tmp scripts all across the new areas with subforms to ensure all repeatable fields are converted. Will be removed in v2.7.0 - Added synced copy, change state and delete in Joomla components view in relation to all tables linked to it (same as with admin views)

Llewellyn commented

2017-10-26 16:50:37 +00:00

Author

Owner

Please test, but be sure that this branch is not ready for production.

What does not yet work:

Compiler
Import and Export of JCB Packages

So all you can test at this stage is the JCB interface, that all looks and works as expected. That with the upgrade all repeatable fields are converted and in their right place.

I will over the weekend finish the compiler and export-import of JCB packages before I will next week release the upgrade.

IMPORTANT NOT PRODUCTION READY

Please test, but be sure that this branch is not ready for production. ### What does not yet work: - Compiler - Import and Export of JCB Packages So all you can test at this stage is the JCB interface, that all looks and works as expected. That with the upgrade all repeatable fields are converted and in their right place. I will over the weekend finish the compiler and export-import of JCB packages before I will next week release the upgrade. ## IMPORTANT NOT PRODUCTION READY

ro-ot commented

2017-10-26 17:08:54 +00:00

(Migrated from github.com)

Author

Owner

I tried to copy a Joomla Component view

Catchable fatal error: Object of class stdClass could not be converted to string in /home/root/libraries/src/Filter/InputFilter.php on line 345

So it seems there is a error in your copy method.

I tried to copy a Joomla Component view ``` Catchable fatal error: Object of class stdClass could not be converted to string in /home/root/libraries/src/Filter/InputFilter.php on line 345 ``` So it seems there is a error in your copy method.

mwweb commented

2017-10-26 21:19:19 +00:00

(Migrated from github.com)

Author

Owner

My preliminary testing this build appears to be working correctly.

And the layout on Dynamic Gets looks better.

My preliminary testing this build appears to be working correctly. And the layout on Dynamic Gets looks better.

Llewellyn commented

2017-10-26 21:24:19 +00:00

Author

Owner

No the build/compiler does not work. CAUTION the compiler has not been updated.

No the build/compiler does not work. **CAUTION** the compiler has not been updated.

Llewellyn commented

2017-10-26 21:25:12 +00:00

Author

Owner

Just the data have been moved and the views setup and all the nice UI stuff 👍

Just the data have been moved and the views setup and all the nice **UI** stuff :+1:

mwweb commented

2017-10-26 21:26:10 +00:00

(Migrated from github.com)

Author

Owner

I realize that. I'll test the compiler when it's ready. I tested by adding a publishing tab, and placed a field in the publishing tab. I will see if it properly places that field in the publishing tab when compile is working, which would resolve one of the issue suggestions.

Llewellyn commented

2017-10-26 21:28:24 +00:00

Author

Owner

Ya all the last few issues where addressed in the compiler, but not the transition to subforms in the joomla_component view.

I think this release is going to be the biggest yet with over 35k new lines of code.

Ya all the last few issues where addressed in the compiler, but not the transition to subforms in the joomla_component view. I think this release is going to be the biggest yet with over 35k new lines of code.

mwweb commented

2017-10-26 21:31:57 +00:00

(Migrated from github.com)

Author

Owner

With such major changes, is just a minor incremental version change appropriate? With such major changes, would it, possibly, be more appropriate to have this version as 2.6.0? Then work up from there, then for the Joomla! 4 version, start at 3.0? Just thinking out loud on this. I went around and around with the Joomla Devs on something similar when they released J! 1.6 (which they admitted later should have been 2.0, which is what I was saying to them).

Llewellyn commented

2017-10-27 01:39:12 +00:00

Author

Owner

I think the release should be v2.6.0

Then the compiler and all will be ready and working. So yes we should give a clear heads-up on this release. I pushed it to v2.5.9 but I was intending to bump to 2.6 before we let this one out 👍

The title does say Major Upgrade

I think the release should be v2.6.0 Then the compiler and all will be ready and working. So yes we should give a clear heads-up on this release. I pushed it to v2.5.9 but I was intending to bump to 2.6 before we let this one out :+1: The title does say **Major Upgrade**

Llewellyn commented

2017-10-29 16:12:05 +00:00

Author

Owner

Okay I have managed to do the complete update, everything should now work as expected.

The whole new Joomla Component View is ready
The compiler is ready
The export of JCB packages is ready
The import of JCB package

@ro-ot & @mwweb please test and let me know if you find any issues.

Okay I have managed to do the complete update, everything should now work as expected. - The whole new Joomla Component View is ready - The compiler is ready - The export of JCB packages is ready - The import of JCB package @ro-ot & @mwweb please test and let me know if you find any issues.

mwweb commented

2017-10-29 17:52:50 +00:00

(Migrated from github.com)

Author

Owner

I ran a test and it compiled fine. The custom field that I added to tab "publishing" is showing on the Publishing tab in the admin view. One thing I think we may want to point out to people is that if they want to add to that tab, they need to keep the position to Left in Tab.

Export and Import of the component appears to be working as well.

I ran a test and it compiled fine. The custom field that I added to tab "publishing" is showing on the Publishing tab in the admin view. One thing I think we may want to point out to people is that if they want to add to that tab, they need to keep the position to Left in Tab. Export and Import of the component appears to be working as well.

Llewellyn commented

2017-10-29 18:41:29 +00:00

Author

Owner

Try adding it to the right and then compile the component, you will see a message :)

mwweb commented

2017-10-29 18:46:48 +00:00

(Migrated from github.com)

Author

Owner

I did that initially and there was a message that the position didn't exist. That's where i moved it and recompiled.

Llewellyn commented

2017-10-29 19:09:49 +00:00

Author

Owner

Yes, is that not enough?

Llewellyn commented

2017-10-29 19:10:57 +00:00

Author

Owner

Can you do some test on exporting and importing of JCB packages?

mwweb commented

2017-10-29 20:11:24 +00:00

(Migrated from github.com)

Author

Owner

I guess we can leave the note as is. If there is any confusion/questions we can add to the note later. I dobt know how many will use the ability to add to the publishing tab.

I tested exporting and importing one component, and it appears to have worked flawlessly. I'll create a whole new install today and test more.

I guess we can leave the note as is. If there is any confusion/questions we can add to the note later. I dobt know how many will use the ability to add to the publishing tab. I tested exporting and importing one component, and it appears to have worked flawlessly. I'll create a whole new install today and test more.

mwweb commented

2017-10-29 22:48:44 +00:00

(Migrated from github.com)

Author

Owner

OK. I did a complete export of my components, and imported into a brand new test site. It looks like FTPs didn't export, and out of 37 layouts only 1 is in the new site.

Llewellyn commented

2017-10-30 02:19:43 +00:00

Author

Owner

Okay the FTP don't export by default, as a security measure.

I will check the layouts issue that is weird.

Thanks!

Okay the FTP don't export by default, as a security measure. I will check the layouts issue that is weird. Thanks!

Llewellyn commented

2017-10-30 02:38:30 +00:00

Author

Owner

It is weird because it is in an area I did not change in this update... I just tested it again my self with the Sermon Distributor component and it moved all the layouts as expected. I will keep looking...

Just that you know the export will only export layouts linked in templates or site_views or custom_admin_views or other layouts of course that are linked to components. IF not linked to components it will not export it. Not that I think this is the case with you... just want to make sure we are clear on that implementation principle.

It is weird because it is in an area I did not change in this update... I just tested it again my self with the Sermon Distributor component and it moved all the layouts as expected. I will keep looking... Just that you know the export will only export layouts linked in **templates** or **site_views** or **custom_admin_views** or other layouts of course that are linked to components. IF not linked to components it will not export it. Not that I think this is the case with you... just want to make sure we are clear on that implementation principle.

Llewellyn commented

2017-10-30 14:05:54 +00:00

Author

Owner

@mwweb have you been able to resolve the issues you mentioned. We are about ready to let this upgrade merge with the core.

mwweb commented

2017-10-30 17:50:22 +00:00

(Migrated from github.com)

Author

Owner

I just ran another test. The component that I am exporting is my component that is now "live". There are multiple admin views, several site views, several templates being called in the site views, and several layouts being called from the templates.

Once again, it looks like all the admin views, sites views, and templates are being exported, but not the layouts.

I event tested with doing an export of Sermon Distributor, then importing. The same thing happens: only Series Table Row imports.

I just ran another test. The component that I am exporting is my component that is now "live". There are multiple admin views, several site views, several templates being called in the site views, and several layouts being called from the templates. Once again, it looks like all the admin views, sites views, and templates are being exported, but not the layouts. I event tested with doing an export of Sermon Distributor, then importing. The same thing happens: only Series Table Row imports.

Llewellyn commented

2017-10-30 18:55:09 +00:00

Author

Owner

This is strange, I am not seeing the same issue at all, in fact this JCB seems to work more effectively then any of the version before.

Would you mind giving me the Sermon Distributor JCB package that you have exported. So I can try import it on my blank install to see what happens.

This is strange, I am not seeing the same issue at all, in fact this JCB seems to work more effectively then any of the version before. Would you mind giving me the Sermon Distributor JCB package that you have exported. So I can try import it on my blank install to see what happens.

mwweb commented

2017-10-30 19:01:31 +00:00

(Migrated from github.com)

Author

Owner

Here you go.

JCB_sermondistributor.zip

Here you go. [JCB_sermondistributor.zip](https://github.com/vdm-io/Joomla-Component-Builder/files/1428424/JCB_sermondistributor.zip)

Llewellyn commented

2017-10-30 19:23:09 +00:00

Author

Owner

Can you please email me the key?

mwweb commented

2017-10-30 19:40:59 +00:00

(Migrated from github.com)

Author

Owner

I had to dig through all my old emails to find your email address. I just sent the package and key to your joomla email address.

Llewellyn commented

2017-10-30 20:02:59 +00:00

Author

Owner

I still did not receive your email... but I found the issue. Please test and let me know.

Just note the problem was with the exporter not the importer 👍

I still did not receive your email... but I found the issue. Please test and let me know. Just **note** the problem was with the exporter not the importer :+1:

🎉 1

Llewellyn commented

2017-10-30 20:04:47 +00:00

Author

Owner

I was not seeing the error before, since I was using old exporter JCB packages. But I think it is resolved now.

Llewellyn commented

2017-10-30 20:05:34 +00:00

Author

Owner

We are about ready to publish this.... just need you to verify that the issue is resolved.

mwweb commented

2017-10-30 20:29:14 +00:00

(Migrated from github.com)

Author

Owner

That looks like it resolved the issue.

mwweb commented

2017-10-30 21:24:18 +00:00

(Migrated from github.com)

Author

Owner

I need to run 1 more test for you. When attempting to compile, I received an error: 0 Call to undefined function bcadd()

mwweb commented

2017-10-30 21:39:47 +00:00

(Migrated from github.com)

Author

Owner

Yes, it looks like there is an error in the compiler in regards to bcadd.

Yes, it looks like there is an error in the compiler in regards to bcadd. ![jcb_error](https://user-images.githubusercontent.com/19194012/32197084-2a8fb672-bd80-11e7-8c08-414f155da584.png)

mwweb commented

2017-10-30 22:06:31 +00:00

(Migrated from github.com)

Author

Owner

Update on the above error: the error ONLY occurs in PHP 7, not in PHP 5. So, there appears to be something that is not compatible with PHP 7 in the compiler.

Llewellyn commented

2017-10-31 02:05:52 +00:00

Author

Owner

This is a function for calculations that should be turned on in PHP.
http://php.net/manual/en/function.bcadd.php

This is a function for calculations that should be turned on in PHP. http://php.net/manual/en/function.bcadd.php

Major Upgrade away from repeatable fields in Joomla component view. #152

What does not yet work:

IMPORTANT NOT PRODUCTION READY