Added FTP field type back. With minor improvments to JCB compiler version options. #174

Llewellyn · 2017-11-06T15:24:00Z

Llewellyn commented

2017-11-06 15:24:00 +00:00

Added FTP field type back to core, resolves gh-173
Added version options to JCB, also changed JCB version option to only first 2 numbers. This should help cut down on the commit changes to JCB on each compilation.
Add new Hello World Tutorial to readme of component.

- Added FTP field type back to core, resolves gh-173 - Added version options to JCB, also changed JCB version option to only first 2 numbers. This should help cut down on the commit changes to JCB on each compilation. - Add new Hello World Tutorial to readme of component.

ro-ot (Migrated from github.com) reviewed 2017-11-06 15:38:42 +00:00

admin/assets/css/admin.css

ro-ot (Migrated from github.com) commented

2017-11-06 15:38:42 +00:00

Hey dropping the build date will help to avoid the many file changes every time there is an update.

ro-ot (Migrated from github.com) reviewed 2017-11-06 15:45:26 +00:00

admin/helpers/compiler/f_Infusion.php

						
				@@ -119,2 +119,4 @@

							// ###VERSION###

							$this->fileContentStatic['###VERSION###'] = trim($this->componentData->component_version);

							// set the actual global version

							$this->fileContentStatic['###ACTUALVERSION###'] = $this->fileContentStatic['###VERSION###'];

ro-ot (Migrated from github.com) commented

2017-11-06 15:45:25 +00:00

Ahh new placeholder ACTUALVERSION, nice! This is great and will help with the git commits being all crowded with changed lines (about versions and dates) that do not matter.

ro-ot (Migrated from github.com) approved these changes 2017-11-06 15:47:00 +00:00

ro-ot (Migrated from github.com) left a comment

Lets get this out!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#174