Prevent getItem from clearing $item->params #186
No reviewers
Labels
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: joomla/Component-Builder#186
Loading…
Reference in New Issue
No description provided.
Delete Branch "patch-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Additional check added to params test to ensure that if parent::getItem values are not removed if present.
Pull Request for Issue # .
Summary of Changes
Added !is_array($item->params) test to getItem method.
Testing Instructions
I'm bringing additional fields into my form via ajax and saving that data as param values. Before the patch, param data is lost. After the patch, param data remains.
Expected result
param data remains
Actual result
param data is lost
Documentation Changes Required
This should be a transparent change for most users, as there isn't a facility in JCB to create param values in the forms. It takes something weird like what I'm doing to notice it's an issue.
Thanks!