Prevent getItem from clearing $item->params #186

Merged

stutteringp0et merged 1 commits from patch-1 into master

2017-11-24 20:20:44 +00:00

stutteringp0et commented

2017-11-24 07:26:23 +00:00

(Migrated from github.com)

Additional check added to params test to ensure that if parent::getItem values are not removed if present.

Pull Request for Issue # .

Summary of Changes

Added !is_array($item->params) test to getItem method.

Testing Instructions

I'm bringing additional fields into my form via ajax and saving that data as param values. Before the patch, param data is lost. After the patch, param data remains.

Expected result

param data remains

Actual result

param data is lost

Documentation Changes Required

This should be a transparent change for most users, as there isn't a facility in JCB to create param values in the forms. It takes something weird like what I'm doing to notice it's an issue.

Additional check added to params test to ensure that if parent::getItem values are not removed if present. Pull Request for Issue # . ### Summary of Changes Added !is_array($item->params) test to getItem method. ### Testing Instructions I'm bringing additional fields into my form via ajax and saving that data as param values. Before the patch, param data is lost. After the patch, param data remains. ### Expected result param data remains ### Actual result param data is lost ### Documentation Changes Required This should be a transparent change for most users, as there isn't a facility in JCB to create param values in the forms. It takes something weird like what I'm doing to notice it's an issue.