Improment to language constant replacment #200

Merged

Llewellyn merged 3 commits from staging into master

2017-12-14 23:02:12 +00:00

Llewellyn commented

2017-12-14 13:40:00 +00:00

Owner

Pull Request for Issue gh-198 .

Summary of Changes

Updated the compiler to also target JText::script() & Joomla.JText._() in language constant replacement. Added field counter.

Testing Instructions

add some JText::script() & Joomla.JText._() to your component site or custom admin view (custom script) areas and it should be converted.

Expected result

Converting JText::script() & Joomla.JText._()

Actual result

There was no implementation for this before.

Documentation Changes Required

We may need to add some notes around the custom script areas to inform users of this feature.

Pull Request for Issue gh-198 . ### Summary of Changes Updated the compiler to also target JText::script() & Joomla.JText._() in language constant replacement. Added field counter. ### Testing Instructions add some JText::script() & Joomla.JText._() to your component site or custom admin view (custom script) areas and it should be converted. ### Expected result Converting JText::script() & Joomla.JText._() ### Actual result There was no implementation for this before. ### Documentation Changes Required We may need to add some notes around the custom script areas to inform users of this feature.

stutteringp0et (Migrated from github.com) reviewed 2017-12-14 13:40:00 +00:00

Llewellyn reviewed 2017-12-14 13:47:34 +00:00

Llewellyn reviewed 2017-12-14 13:48:02 +00:00

Llewellyn reviewed 2017-12-14 13:54:01 +00:00

Llewellyn commented

2017-12-14 15:09:04 +00:00

Author

Owner

Hey I also made a better tutorial about the developing work flow of JCB take a look 👍

Hey I also made a better [tutorial about the developing work flow of JCB](https://youtu.be/lLOfx9YA7VQ) take a look :+1:

ro-ot (Migrated from github.com) approved these changes 2017-12-14 22:58:26 +00:00