Added the feature to include code from external source with the use of a placeholder tag.
Testing Instructions
Create some code snippet on Gist here on Github, then get the url to the raw string of the code snippet. Then add the code to a custom area anywhere in your component. Using the following placeholder:
On compilation the compiler will get the code/string from https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt and add it to the area the placeholder is found.
When a change in the code/string is detected a notice will be given.
Actual result
New feature!
Documentation Changes Required
Will still make tutorials to announce this feature.
### Summary of Changes
Added the feature to include code from external source with the use of a placeholder tag.
### Testing Instructions
Create some code snippet on [Gist](https://gist.github.com) here on [Github](https://github.com), then get the url to the [raw string](https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt) of the code snippet. Then add the code to a custom area anywhere in your component. Using the following placeholder:
```
[EXTERNALCODE=https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt]
```
So the placeholder format is
```
[EXTERNALCODE=https://theUrlToText.txt]
```
### Expected result
On compilation the compiler will get the code/string from `https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt` and add it to the area the placeholder is found.
When a change in the code/string is detected a notice will be given.
### Actual result
New feature!
### Documentation Changes Required
Will still make tutorials to announce this feature.
stutteringp0et
(Migrated from github.com)
reviewed 5 years ago
ro-ot
(Migrated from github.com)
approved these changes 5 years ago
Should this not instead be called EXTERNALCODE since paths also work. I know it is little late in the game, but it makes more sense to call it EXTERNAL.
Should this not instead be called `EXTERNALCODE` since paths also work. I know it is little late in the game, but it makes more sense to call it EXTERNAL.
Well if we want to change it, best do it now. Please just note that I am not adding a DB fix, you that have been testing this, will have to fix your own DB's to have the correct table and column naming. I will update it for the release.
I will need you all to run the test again, since many variables will change, just to be save 👍
Well if we want to change it, best do it now. Please just note that I am not adding a DB fix, you that have been testing this, will have to fix your own DB's to have the correct table and column naming. I will update it for the release.
I will need you all to run the test again, since many variables will change, just to be save 👍
Summary of Changes
Added the feature to include code from external source with the use of a placeholder tag.
Testing Instructions
Create some code snippet on Gist here on Github, then get the url to the raw string of the code snippet. Then add the code to a custom area anywhere in your component. Using the following placeholder:
So the placeholder format is
Expected result
On compilation the compiler will get the code/string from
https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt
and add it to the area the placeholder is found.When a change in the code/string is detected a notice will be given.
Actual result
New feature!
Documentation Changes Required
Will still make tutorials to announce this feature.
Sorry man I was out of town for few days, this feature is excellent!
Should this not instead be called
EXTERNALCODE
since paths also work. I know it is little late in the game, but it makes more sense to call it EXTERNAL.Well if we want to change it, best do it now. Please just note that I am not adding a DB fix, you that have been testing this, will have to fix your own DB's to have the correct table and column naming. I will update it for the release.
I will need you all to run the test again, since many variables will change, just to be save 👍
Are we ready to go?
Reviewers
c78ef21678
.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Gitea.