External Code Inclution Option #228

Merged

Llewellyn merged 8 commits from staging into master

2018-02-08 12:42:02 +00:00

Llewellyn commented

2018-01-31 14:39:52 +00:00

Owner

Summary of Changes

Added the feature to include code from external source with the use of a placeholder tag.

Testing Instructions

Create some code snippet on Gist here on Github, then get the url to the raw string of the code snippet. Then add the code to a custom area anywhere in your component. Using the following placeholder:

[EXTERNALCODE=https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt]

So the placeholder format is

[EXTERNALCODE=https://theUrlToText.txt]

Expected result

On compilation the compiler will get the code/string from https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt and add it to the area the placeholder is found.

When a change in the code/string is detected a notice will be given.

Actual result

New feature!

Documentation Changes Required

Will still make tutorials to announce this feature.

### Summary of Changes Added the feature to include code from external source with the use of a placeholder tag. ### Testing Instructions Create some code snippet on [Gist](https://gist.github.com) here on [Github](https://github.com), then get the url to the [raw string](https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt) of the code snippet. Then add the code to a custom area anywhere in your component. Using the following placeholder: ``` [EXTERNALCODE=https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt] ``` So the placeholder format is ``` [EXTERNALCODE=https://theUrlToText.txt] ``` ### Expected result On compilation the compiler will get the code/string from `https://gist.githubusercontent.com/Llewellynvdm/e13ed45e73590cc4bcd98a73cf9305f1/raw/fancyDate.txt` and add it to the area the placeholder is found. When a change in the code/string is detected a notice will be given. ### Actual result New feature! ### Documentation Changes Required Will still make tutorials to announce this feature.

stutteringp0et (Migrated from github.com) reviewed 2018-01-31 14:39:52 +00:00

ro-ot (Migrated from github.com) approved these changes 2018-02-01 19:32:38 +00:00

ro-ot (Migrated from github.com) left a comment

Author

Owner

Sorry man I was out of town for few days, this feature is excellent!

Roline reviewed 2018-02-02 11:52:32 +00:00

Roline reviewed 2018-02-02 11:53:30 +00:00

Roline approved these changes 2018-02-02 22:19:20 +00:00

ro-ot commented

2018-02-02 22:22:41 +00:00

(Migrated from github.com)

Author

Owner

Should this not instead be called EXTERNALCODE since paths also work. I know it is little late in the game, but it makes more sense to call it EXTERNAL.

Should this not instead be called `EXTERNALCODE` since paths also work. I know it is little late in the game, but it makes more sense to call it EXTERNAL.

👍 1

Llewellyn commented

2018-02-02 22:55:20 +00:00

Author

Owner

Well if we want to change it, best do it now. Please just note that I am not adding a DB fix, you that have been testing this, will have to fix your own DB's to have the correct table and column naming. I will update it for the release.

I will need you all to run the test again, since many variables will change, just to be save 👍