Added the Feature to Combine/Join Values/Fields in the admin list view (called field relations) #293

Merged

Llewellyn merged 7 commits from staging into master

2018-05-30 11:46:36 +00:00

Llewellyn commented

2018-05-26 14:03:46 +00:00

Owner

Pull Request for Issue gh-287.

Summary of Changes

Resolved gh-287 that adds the feature to join/combine results of multiple fields in the admin list view.
Update the tab string to make tabs dynamic in nature.
Improved the compiler building of the admin list view
Refactored the compiler list view body builder, in preparation of the relation fields.
Added more options to the relation admin fields. gh-287
Refactored the compiler update file method
Updated compiler to allow dynamic update for language strings. Started adding the field relationship feature requested in gh-287

Testing Instructions

Watch the tutorial and do a combine/join fields in the admin view.

Expected result

The result demonstrated in the tutorials.

Actual result

New feature

Documentation Changes Required

The new tutorial will be added to the JCB playlist on youtube once the feature is released.

Pull Request for Issue gh-287. ### Summary of Changes - Resolved gh-287 that adds the feature to join/combine results of multiple fields in the admin list view. - Update the tab string to make tabs dynamic in nature. - Improved the compiler building of the admin list view - Refactored the compiler list view body builder, in preparation of the relation fields. - Added more options to the relation admin fields. gh-287 - Refactored the compiler update file method - Updated compiler to allow dynamic update for language strings. Started adding the field relationship feature requested in gh-287 ### Testing Instructions Watch [the tutorial and do a combine/join](https://youtu.be/hh4IIPmYIY8) fields in the admin view. ### Expected result The result demonstrated in the tutorials. ### Actual result New feature ### Documentation Changes Required The new tutorial will be added to the JCB playlist on youtube once the feature is released.

mwweb (Migrated from github.com) reviewed 2018-05-26 14:03:46 +00:00

mwweb commented

2018-05-27 00:42:53 +00:00

(Migrated from github.com)

Author

Owner

I tested this, and it appears to work. I will say that this appears to be a nice feature, but honestly don't see where I'll end up utilizing it in any of my components, at this point.

I have a similar feature right now, all using custom code, that takes what you did here a step further. I'll "throw this out" as something to think about.

In my case, I have a field called "Name". On save, if name is populated, then nothing gets done. However, if Name is empty, then it concatenates fields. Those concatenated fields are then saved in the Name field in the DB.

In this case, the name field I just called "Adline" which concatenates a unique record id, street, city, state, and postal code, if there is nothing manually typed in Adline. So, if the unique record id is a12345, street=123 Front Street, city=New York, state=NY, postal code=10001, then on save name becomes a12345 123 Front Street New York, NY 10001. I can then have that field, along with the street, city, state, etc on the list view.

That night be something to think about for the future of extending this functionality.

I tested this, and it appears to work. I will say that this appears to be a nice feature, but honestly don't see where I'll end up utilizing it in any of my components, at this point. I have a similar feature right now, all using custom code, that takes what you did here a step further. I'll "throw this out" as something to think about. In my case, I have a field called "Name". On save, if name is populated, then nothing gets done. However, if Name is empty, then it concatenates fields. Those concatenated fields are then saved in the Name field in the DB. In this case, the name field I just called "Adline" which concatenates a unique record id, street, city, state, and postal code, if there is nothing manually typed in Adline. So, if the unique record id is a12345, street=123 Front Street, city=New York, state=NY, postal code=10001, then on save name becomes a12345 123 Front Street New York, NY 10001. I can then have that field, along with the street, city, state, etc on the list view. That night be something to think about for the future of extending this functionality.

Llewellyn commented

2018-05-27 01:26:27 +00:00

Author

Owner

@mwweb I don't understand, this is what this new feature can do. Well basically the same and so much more. The ability to combine values in the list view.

The feature you are speaking about also is in JCB where you have fields in the admin edit view that on save gets combined into the database as one column.

But this feature we are looking at takes values from different columns and combines them in display only, while still allow the filtering and searching of those columns values separately.

I knew that with custom scripting you can already do this, but it seemed to me from reading the issues on github and feedback from the JAB that this needed to be done easier.

Okay so in my mind it seems like the header of the table is the issue here.

So to have the option to change the word Name should not be that hard... I can just add another field to override the header.

When I opened the issue gh-287 you were all for this feature. Now that I spend a week to build it you are like... ahaa wast of time! Facts are the feature does exactly what it was said to do, it combines/joins values in the admin list view in a very powerful way, and very easy.

If the greatest motivation for the feature is the limited space why add city again, or any other value that is being combined. Truth is the filter can still be loaded for those fields, and so also the search options. Not being able to add the field/value a second time as a list field is never going to change (sorry to say), but you can use any of the combine/join fields again and again... so there is the loop to use one field more then once in the list view.

Lastly, you do know that we added the option to build the alias dynamical with that kind of way you explained? well to do that with every field will be a complete other feature. Not the same as this one, as this feature focuses on the display of the value and not the creation/storing of the values. Further more as you said you already have nice custom script to deal with that. What is also true, is that you can achieve the same effect (in display) with this feature.

@mwweb I don't understand, this is what this new feature can do. Well basically the same and so much more. The ability to combine values in the list view. The feature you are speaking about also is in JCB where you have fields in the admin edit view that on save gets combined into the database as one column. But this feature we are looking at takes values from different columns and combines them in display only, while still allow the filtering and searching of those columns values separately. I knew that with custom scripting you can already do this, but it seemed to me from reading the issues on github and feedback from the JAB that this needed to be done easier. Okay so in my mind it seems like the header of the table is the issue here. ![untitled](https://user-images.githubusercontent.com/5607939/40581476-3fe779ae-6151-11e8-9c86-2fdd4acc0848.png) So to have the option to change the word **Name** should not be that hard... I can just add another field to override the header. When I opened the issue gh-287 you were all for this feature. Now that I spend a week to build it you are like... ahaa wast of time! Facts are the feature does exactly what it was said to do, it combines/joins values in the **admin list view** in a very powerful way, and very easy. If the **greatest motivation** for the feature is the limited space why add city again, or any other value that is being combined. Truth is the filter can still be loaded for those fields, and so also the search options. Not being able to add the field/value a second time as a **list field** is never going to change (sorry to say), but you can use any of the combine/**join fields** again and again... so there is the loop to use one field more then once in the list view. Lastly, you do know that we added the option to build the alias dynamical with that kind of way you explained? well to do that with every field will be a complete other feature. Not the same as this one, as this feature focuses on the display of the value and not the creation/storing of the values. Further more as you said you already have nice custom script to deal with that. What is also true, is that you can achieve the same effect (in display) with this feature.

lamatieregrise commented

2018-05-27 03:57:58 +00:00

(Migrated from github.com)

Author

Owner

Nice Feature guys!

👍 2

ro-ot (Migrated from github.com) reviewed 2018-05-28 03:37:05 +00:00

ro-ot (Migrated from github.com) reviewed 2018-05-28 04:06:28 +00:00

ro-ot commented

2018-05-28 04:22:44 +00:00

(Migrated from github.com)

Author

Owner

I also found that the JavaScript in the new view is inconsistent.

But the feature is working great, I like the updates you made to the area that builds the body of the list views.

The option to also model the fields during the creation of a new item in this kind of basic way could be a nice added bonus, @mwweb thanks for sharing.

I also found that the JavaScript in the new view is inconsistent. But the feature is working great, I like the updates you made to the area that builds the body of the list views. The option to also model the fields during the creation of a new item in _this kind of basic way_ could be a nice added bonus, @mwweb thanks for sharing.

Llewellyn commented

2018-05-29 04:18:17 +00:00

Author

Owner

The JavaScript should be more stable now, and also added the option to over-ride the column header via the relation area.

Llewellyn reviewed 2018-05-29 04:20:24 +00:00

Llewellyn reviewed 2018-05-29 04:21:49 +00:00

Llewellyn commented

2018-05-29 04:23:02 +00:00

Author

Owner

I need feedback on this ASAP, so we can get this update out.