Added CodeMirror to code areas all accross JCB

Llewellyn commented

2018-06-29 02:26:35 +00:00

Owner

Pull Request for Issue gh-305 .

Summary of Changes

Changed all/most textarea fields to editor fields with codemirror.

Testing Instructions

Open all areas that has custom code areas and check if the values are editable and gets saved correctly.

Expected result

That this transition from textarea fields to editor will improve JCB custom scripting.

Actual result

New feature

Documentation Changes Required

Well now we should have better control over the custom code, and so it should make things easier. We may need to make a tutorial to help those who do not know how to customize codemirror.

Pull Request for Issue gh-305 . ### Summary of Changes Changed all/most textarea fields to editor fields with codemirror. ### Testing Instructions Open all areas that has custom code areas and check if the values are editable and gets saved correctly. ### Expected result That this transition from textarea fields to editor will improve JCB custom scripting. ### Actual result New feature ### Documentation Changes Required Well now we should have better control over the custom code, and so it should make things easier. We may need to make a tutorial to help those who do not know how to customize codemirror.

ro-ot commented

2018-06-30 01:45:46 +00:00

(Migrated from github.com)

Author

Owner

@Llewellynvdm I am still getting issues with the new editor. Checkout the dynamic get area, some of those php fields will not submit.

Llewellyn commented

2018-06-30 20:35:55 +00:00

Author

Owner

I am working on this... very strange.

Llewellyn commented

2018-07-01 00:21:47 +00:00

Author

Owner

To me it is clear that codemirror has been broken with the last update of Joomla. I have used other code editors and with it the issue is resolved. At this point I think we need to roll back this update/release until codemirror gets fixed, so gh-305 will have to wait.

Llewellyn commented

2018-07-01 00:27:05 +00:00

Author

Owner

Two options going forward, revert back to textarea, or just default the editor to none for now as default. There is also the option to tweak the editor with a global switch in the global options of the JCB component.

ro-ot commented

2018-07-06 16:14:39 +00:00

(Migrated from github.com)

Author

Owner

This look great! I will run a few test. What do you think about gh-312

Llewellyn commented

2018-07-06 16:42:32 +00:00

Author

Owner

I also got the same error:

I am looking into it as we speak.

I also got the same error: ![image](https://user-images.githubusercontent.com/5607939/42390476-ea51ae3e-8143-11e8-843e-2ef2e4333f58.png) I am looking into it as we speak.

Llewellyn added this to the Feature Requests project 2022-08-05 08:25:50 +00:00

Added CodeMirror to code areas all accross JCB #308

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required