Few Fixes and Improved the Admin Fields Relations #326

Merged

Llewellyn merged 5 commits from staging into master

2018-07-30 13:21:39 +00:00

Llewellyn commented

2018-07-30 01:35:01 +00:00

Owner

Pull Request for Issues gh-325, gh-324, gh-322, gh-318, gh-317 .

Summary of Changes

Fixed gh-325 that caused a security token validation error.
Fixed gh-324 that had a typo with the storing of the PHPx values.
Improved the safeString helper method
Improved the Admin Fields Relations area to allow more custom coding without the need of selecting Join Field/s.
Improved the dynamic get string fixing implementation to avoid conflict when the same field name is used in multiple joined tables requiring string fixing.
Fixed gh-322 to insure ID is always readonly even if override detected.
Added new feature to control access and view/hide control per/field.
Fixed gh-318 so that default and other none database fields will not trigger SQL update and version increment.
Fixed gh-317 that had conflict variable naming in the jsonToString helper method. Improved the refresh method for JCB package area.

Testing Instructions

Please read all the fixed issues and do the test surrounding those areas. Most of them have already been tested, and confirmed fixed inside the given issues.

Expected result

That JCB is more stable then before, with a few new features.

Actual result

We had some bugs (which has been fixed), and new features added.

Documentation Changes Required

We may need some tutorial on the new permission feature, just so that it gets introduced, and some update to the Admin Fields Relations area.

Pull Request for Issues gh-325, gh-324, gh-322, gh-318, gh-317 . ### Summary of Changes - Fixed gh-325 that caused a security token validation error. - Fixed gh-324 that had a typo with the storing of the PHPx values. - Improved the safeString helper method - Improved the Admin Fields Relations area to allow more custom coding without the need of selecting Join Field/s. - Improved the dynamic get string fixing implementation to avoid conflict when the same field name is used in multiple joined tables requiring string fixing. - Fixed gh-322 to insure ID is always readonly even if override detected. - Added new feature to control access and view/hide control per/field. - Fixed gh-318 so that default and other none database fields will not trigger SQL update and version increment. - Fixed gh-317 that had conflict variable naming in the jsonToString helper method. Improved the refresh method for JCB package area. ### Testing Instructions Please read all the fixed issues and do the test surrounding those areas. Most of them have already been tested, and confirmed fixed inside the given issues. ### Expected result That JCB is more stable then before, with a few new features. ### Actual result We had some bugs (which has been fixed), and new features added. ### Documentation Changes Required We may need some tutorial on the new permission feature, just so that it gets introduced, and some update to the Admin Fields Relations area.

ro-ot (Migrated from github.com) reviewed 2018-07-30 05:50:58 +00:00

ro-ot (Migrated from github.com) reviewed 2018-07-30 05:53:49 +00:00

Llewellyn reviewed 2018-07-30 06:01:46 +00:00

Llewellyn reviewed 2018-07-30 06:04:00 +00:00

ro-ot (Migrated from github.com) approved these changes 2018-07-30 06:30:06 +00:00