Added InoDB options, Expanded the Custom Field #350

Merged

Llewellyn merged 13 commits from staging into master

2018-10-07 19:47:50 +00:00

Llewellyn commented

2018-10-05 19:36:24 +00:00

Owner

Pull Request for Issue gh-341, gh-345, gh-348, gh-349.

Summary of Changes

Fixed gh-349 to insure dynamic joined and other tweaks are not added when custom code is selected as main source with a dynamicGet
We removed the Transition to InnoDB for all JCB tables and moved it to https://gist.github.com/Llewellynvdm/85234c6bd1e7d0eb4ddd6c925770aa2c for those who want to manually make the transition. gh-348
We also added a pre-flight script to remove all unused columns from JCB.
Improved the custom-custom field implementation, to allow duplicate fields to be use in sub-forms and in same form/view with the correct expected behavior of incremental naming, only if in same sub-form or form/view. gh-341
Further fix to the search of customcode placeholders across the system.
Added the option to random order the dynamic get result set. gh-348
Fixed the search for customcode placeholders across the system. gh-341
Changed the text field for Value/Example in the Fieldtype area to a textarea so we can add more code per/line. gh-341
Little fix to the field builder in the compiler
Resolved gh-345 by adding whole new mysql table selection options in the admin view, under the mySql tab. Fixed the folder & file loader.
Fixed the Update of custom files, so even the custom code and external code placeholders will work in external files.
Resolved gh-341 that adds the feature to expand the custom field option far beyond the default. Moved the menu prefix option in to the Joomla component area -> tab -> Settings to allow each component to override the global setting.
Added the [Run Expansion] button option for faster compile and install option of selected components.
Update the Uikit 3 lib. Fixed permission check in getEditUrl.

Testing Instructions

Please review the various issues gh-341, gh-345, gh-348, gh-349 (most already tested successful)

Expected result

A stable JCB

Actual result

Many new features and bug fixes

Documentation Changes Required

We have a new tutorials for the new custom-custom field type implementation.

Pull Request for Issue gh-341, gh-345, gh-348, gh-349. ### Summary of Changes - Fixed gh-349 to insure dynamic joined and other tweaks are not added when custom code is selected as main source with a dynamicGet - We removed the Transition to InnoDB for all JCB tables and moved it to https://gist.github.com/Llewellynvdm/85234c6bd1e7d0eb4ddd6c925770aa2c for those who want to manually make the transition. gh-348 - We also added a pre-flight script to remove all unused columns from JCB. - Improved the custom-custom field implementation, to allow duplicate fields to be use in sub-forms and in same form/view with the correct expected behavior of incremental naming, only if in same sub-form or form/view. gh-341 - Further fix to the search of customcode placeholders across the system. - Added the option to random order the dynamic get result set. gh-348 - Fixed the search for customcode placeholders across the system. gh-341 - Changed the text field for Value/Example in the Fieldtype area to a textarea so we can add more code per/line. gh-341 - Little fix to the field builder in the compiler - Resolved gh-345 by adding whole new mysql table selection options in the admin view, under the mySql tab. Fixed the folder & file loader. - Fixed the Update of custom files, so even the custom code and external code placeholders will work in external files. - Resolved gh-341 that adds the feature to expand the custom field option far beyond the default. Moved the menu prefix option in to the Joomla component area -> tab -> Settings to allow each component to override the global setting. - Added the [Run Expansion] button option for faster compile and install option of selected components. - Update the Uikit 3 lib. Fixed permission check in getEditUrl. ### Testing Instructions Please review the various issues gh-341, gh-345, gh-348, gh-349 (most already tested successful) ### Expected result A stable JCB ### Actual result Many new features and bug fixes ### Documentation Changes Required We have [a new tutorials](https://www.youtube.com/watch?v=Mu9H0zgH9Lw&index=75&list=PLQRGFI8XZ_wtGvPQZWBfDzzlERLQgpMRE) for the new custom-custom field type implementation.

ro-ot (Migrated from github.com) reviewed 2018-10-06 11:45:57 +00:00

ro-ot (Migrated from github.com) reviewed 2018-10-06 12:01:54 +00:00

ro-ot (Migrated from github.com) reviewed 2018-10-06 12:10:16 +00:00

ro-ot (Migrated from github.com) left a comment

Author

Owner

Looking over the code, all seems in order. I will run a few tests to confirm stability. We should really think about adding unit-testing to JCB.

Llewellyn reviewed 2018-10-06 14:33:43 +00:00

ro-ot (Migrated from github.com) approved these changes 2018-10-07 00:15:29 +00:00