Transliteration of cyrillic characters.

bamboo2panda commented

2019-10-11 10:18:33 +00:00

(Migrated from github.com)

Pull Request for Issue gh- .

Summary of Changes

Transliteration of cyrillic names of Views when preparing safe string

Testing Instructions

Make Admin view named in russian like "Таблица"
Add this view to component
Compile component
Check folder admin/view

Expected result

Folders in admin/views:
- tablica
- tablici

Actual result

No folders of this view in admin/views

Documentation Changes Required

No changes required.

Pull Request for Issue gh- . ### Summary of Changes - Transliteration of cyrillic names of Views when preparing safe string ### Testing Instructions - Make Admin view named in russian like "Таблица" - Add this view to component - Compile component - Check folder admin/view ### Expected result - Folders in admin/views: - tablica - tablici ### Actual result - No folders of this view in admin/views ### Documentation Changes Required No changes required.

Llewellyn commented

2019-10-11 10:29:59 +00:00

Please only commit the changes, meaning only the lines you changed or added, and do not reformat the whole file, since I can't see what you have changed.

Llewellyn commented

2019-10-11 10:56:29 +00:00

I can add this no problem, we need also think of more areas that will be effected. So I am just wonder did you see the new implementation of field naming and type naming in JCB?

It looks like this is an older version of the helper class since it does no have these new function for field and type naming.

Always work on the latest branch of JCB staging 👍

I think we can wrap this option into a function to be turn-on in the GUI, since it has you have to anyway change the global language target right, in the global options of JCB:

So do you know which languages all use Cyrillic Characters the we can use that to trigger this feature.

I can add this no problem, we need also think of more areas that will be effected. So I am just wonder did you see the new implementation of [field naming](https://github.com/vdm-io/Joomla-Component-Builder/blob/staging/admin/helpers/componentbuilder.php#L670) and [type naming](https://github.com/vdm-io/Joomla-Component-Builder/blob/staging/admin/helpers/componentbuilder.php#L728) in JCB? It looks like this is an older version of the helper class since it does no have these new function for field and type naming. Always work on the latest branch of JCB staging :+1: I think we can wrap this option into a function to be turn-on in the GUI, since it has you have to anyway change the global language target right, in the global options of JCB: ![image](https://user-images.githubusercontent.com/5607939/66646358-44481d80-ec26-11e9-8d8b-4380b22d9b9f.png) So do you know which languages all use Cyrillic Characters the we can use that to trigger this feature.

Llewellyn commented

2019-10-11 11:00:45 +00:00

Here is a list of all the Joomla languages in JCB:

We can add this also to the languages area, that we can turn this on and off in each language... just an idea. I could google this I suppose... but any help with this will be great :)

bamboo2panda commented

2019-10-11 11:31:36 +00:00

(Migrated from github.com)

This table is for Russian. The characters in other languages are almost the same, but they have a difference... Yes, it would be nice to make a more universal solution.

But I think that it's no need in UI function. Joomla has JLanguageTransliterate::utf8_latin_to_ascii that transform some strange characters to [a-zA-Z]. Like this here need a function that thansform any none a-z character to a-z or skip if can't do this.

So you do not need to turn it off, because this will lead to an error as in the description.

Now I see that Joomla do the same thing in alias field!

This table is for Russian. The characters in other languages are almost the same, but they have a difference... Yes, it would be nice to make a more universal solution. But I think that it's no need in UI function. Joomla has JLanguageTransliterate::utf8_latin_to_ascii that transform some strange characters to [a-zA-Z]. Like this here need a function that thansform any none a-z character to a-z or skip if can't do this. So you do not need to turn it off, because this will lead to an error as in the description. Now I see that Joomla do the same thing in alias field!

Llewellyn commented

2019-10-11 11:32:41 +00:00

Okay it seems like moving the whole feature to the GUI and making easy for any language to be set manually is idea... and will achieve the goal much more effectively.

I will push the changes in a few minutes.

Okay it seems like moving the whole feature to the GUI and making easy for any language to be set manually is idea... and will achieve the goal much more effectively. I will push the changes in a few minutes.

Llewellyn commented

2019-10-11 11:34:50 +00:00

Now I see that Joomla do the same thing in alias field!

Okay great, let me take a look... it may save us some time.

> Now I see that Joomla do the same thing in alias field! Okay great, let me take a look... it may save us some time.

Llewellyn commented

2019-10-11 11:38:35 +00:00

Do you have a link to the code in Joomla?

bamboo2panda commented

2019-10-11 11:40:44 +00:00

(Migrated from github.com)

No, need to search...

Llewellyn commented

2019-10-11 11:43:53 +00:00

This is how the GUI will look.

Just working on the implementation on the code side.

This is how the GUI will look. ![image](https://user-images.githubusercontent.com/5607939/66648880-fc78c480-ec2c-11e9-9250-3795a27c8f14.png) Just working on the implementation on the code side.

bamboo2panda commented

2019-10-11 12:29:28 +00:00

(Migrated from github.com)

Joomla makes alias by JFilterOutput::stringURLSafe($string)

I think it will be good just to process $string with this function.
And... If it will be GUI feature, switch must be turn "Yes" by default. Because "No" may cause a component error. For example name "table_записи" will be compiled like "table_", that cause no error, but name "Записи" will be compilled to "" (empty string).

P.s. sorry for my english =)

Joomla makes alias by JFilterOutput::stringURLSafe($string) I think it will be good just to process $string with this function. And... If it will be GUI feature, switch must be turn "Yes" by default. Because "No" may cause a component error. For example name "table_записи" will be compiled like "table_", that cause no error, but name "Записи" will be compilled to "" (empty string). P.s. sorry for my english =)

Llewellyn commented

2019-10-11 12:59:51 +00:00

Joomla makes alias by JFilterOutput::stringURLSafe($string)

I think this is the better solution for sure. I will drop the GUI idea... and instead use this option.

> Joomla makes alias by JFilterOutput::stringURLSafe($string) I think this is the better solution for sure. I will drop the GUI idea... and instead use this option.

bamboo2panda commented

2019-10-11 13:04:56 +00:00

(Migrated from github.com)

Ok. Thanks!

Llewellyn commented

2019-10-11 13:45:21 +00:00

Lets keep this pull open... and add these changes here. Was your idea... 👍

Lets keep this pull open... and add these changes here. Was your idea... :+1:

Llewellyn commented

2019-10-11 15:00:39 +00:00

@bamboo2panda thanks for the idea, and direction towards best implementation. Please try it out, remember you need to see the JCB global language to Russian for it to work.

From this:

To this:

Once you have tested it, let me know 👍

@bamboo2panda thanks for the idea, and direction towards best implementation. Please try it out, remember you need to see the JCB global language to Russian for it to work. From this: ![image](https://user-images.githubusercontent.com/5607939/66646358-44481d80-ec26-11e9-8d8b-4380b22d9b9f.png) To this: ![image](https://user-images.githubusercontent.com/5607939/66662166-99952680-ec48-11e9-8daf-730288063837.png) Once you have tested it, let me know :+1:

bamboo2panda commented

2019-10-12 22:01:20 +00:00

(Migrated from github.com)

I tested this implementation on clear joomla with JCB. For testing I took Russian and German names of component and view. It works good! But it can be improved a little.
When JCB compiles "transliterated" component, it make only localised language files (for example ru-RU....ini and ru_RU....sys.ini).
So users with over languages will see LANGUAGE_CONSTANTS insted of menu or fields names. It will be great if JCB make en-GB files with transliterated names as translation by default and whith real translations to en-GB when developer add some.
en-GB is default in Joomla, so if some component doesn't have another language files (ex. ru-RU), it will have English names and cause no GUI problems.

I tested this implementation on clear joomla with JCB. For testing I took Russian and German names of component and view. It works good! But it can be improved a little. When JCB compiles "transliterated" component, it make only localised language files (for example ru-RU....ini and ru_RU....sys.ini). So users with over languages will see LANGUAGE_CONSTANTS insted of menu or fields names. It will be great if JCB make en-GB files with transliterated names as translation by default and whith real translations to en-GB when developer add some. en-GB is default in Joomla, so if some component doesn't have another language files (ex. ru-RU), it will have English names and cause no GUI problems.

Llewellyn commented

2019-10-12 22:49:40 +00:00

Hmmm I am not sure this is logic, for now JCB's behavior is true to the settings you make. If you say you are working in Russian, and so all your naming, and wording in an around is in Russian, it will correctly place them in the RU...ini file as it should. Then if you want it to also be in English, there is a translation area in JCB where you can export all the strings, and import it again with the English translation, then JCB will compile both the Russian and English .ini language files.

To change that will cause unexpected result, that is not logic.

We are in fact working on adding a bridge between Crowdin and JCB so that translation can be easily done via a community initiative. This require that we do not mix languages, and once we do we will lose control of these conventions. This will cause great confusion.

The only alternative for you is to add a Joomla plugin that change the JCB default behavior just for you, since we have events in the compiler that allow you to inject other behavior then the default as set forth by JCB in harmony with all.

I have not yet recorded any tutorial on how to do this, but it is straight forward. You have two events where you can force "English" ini file to be build instead.

To target these events your plugin must be part of the extension group, active in Joomla and the added to the allowed JCB plugins in the global options of JCB.

This way you can hack the core, and yet not lose your changes with new updates. Hope this helps!

Hmmm I am not sure this is logic, for now JCB's behavior is true to the settings you make. If you say you are working in Russian, and so all your naming, and wording in an around is in Russian, it will correctly place them in the RU...ini file as it should. Then if you want it to also be in English, there is a translation area in JCB where you can export all the strings, and import it again with the English translation, then JCB will compile both the Russian and English .ini language files. To change that will cause unexpected result, that is not logic. We are in fact working on adding a bridge between Crowdin and JCB so that translation can be easily done via a community initiative. This require that we do not mix languages, and once we do we will lose control of these conventions. This will cause great confusion. The only alternative for you is to add a Joomla plugin that change the JCB default behavior just for you, since we have events in the compiler that allow you to inject other behavior then the default as set forth by JCB in harmony with all. I have not yet recorded any tutorial on how to do this, but it is straight forward. You have two events where you can force "English" ini file to be build instead. - [jcb_ce_onBeforeBuildAllLangFiles](https://github.com/vdm-io/Joomla-Component-Builder/blob/staging/admin/helpers/compiler/f_Infusion.php#L1215) - [jcb_ce_onBeforeSetLangFileData](https://github.com/vdm-io/Joomla-Component-Builder/blob/staging/admin/helpers/compiler.php#L114) To target these events your plugin must be part of the extension group, active in Joomla and the added to the allowed JCB plugins in the global options of JCB. ![image](https://user-images.githubusercontent.com/5607939/66708599-13b1d200-ed53-11e9-863a-9cf5cef9fc16.png) This way you can hack the core, and yet not lose your changes with new updates. Hope this helps!

bamboo2panda commented

2019-10-13 06:47:23 +00:00

(Migrated from github.com)

Oh, I understand your translation strategy! It makes much more sense =) Thanks again!

Transliteration of cyrillic characters. #483

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required