When field default is DATETIME or CURRENT_TIMESTAMP, the SQL is constructed out of order. The default gets inserted before the NULL/NOT NULL string. One line fix - YAY!
Pull Request for Issue gh-585 .
Summary of Changes
Fixed compilation order
Testing Instructions
Create datetime field with DATETIME or CURRENT_TIMESTAMP as default
Expected result
received_timestamp DATETIME NOT NULL CURRENT_TIMESTAMP
Actual result
received_timestamp DATETIME NOT NULL CURRENT_TIMESTAMP
Documentation Changes Required
none
When field default is DATETIME or CURRENT_TIMESTAMP, the SQL is constructed out of order. The default gets inserted before the NULL/NOT NULL string. One line fix - YAY!
Pull Request for Issue gh-585 .
### Summary of Changes
Fixed compilation order
### Testing Instructions
Create datetime field with DATETIME or CURRENT_TIMESTAMP as default
### Expected result
`received_timestamp` DATETIME NOT NULL CURRENT_TIMESTAMP
### Actual result
`received_timestamp` DATETIME NOT NULL CURRENT_TIMESTAMP
### Documentation Changes Required
none
Please make pull request in the future against the staging branch. I have merged your changes into the staging branch, and it should go to master with the next release. I like to keep the master in sync with the last release, at this point anyway. So I manually close this pull request for GitHub's sake.
Hey nice to see you back, and thank you for the fix!
Please make pull request in the future against the staging branch. I have merged your changes into the staging branch, and it should go to master with the next release. I like to keep the master in sync with the last release, at this point anyway. So I manually close this pull request for GitHub's sake.
Hey nice to see you back, and thank you for the fix!
Llewellyn
When field default is DATETIME or CURRENT_TIMESTAMP, the SQL is constructed out of order. The default gets inserted before the NULL/NOT NULL string. One line fix - YAY!
Pull Request for Issue gh-585 .
Summary of Changes
Fixed compilation order
Testing Instructions
Create datetime field with DATETIME or CURRENT_TIMESTAMP as default
Expected result
received_timestampDATETIME NOT NULL CURRENT_TIMESTAMPActual result
received_timestampDATETIME NOT NULL CURRENT_TIMESTAMPDocumentation Changes Required
none
Please make pull request in the future against the staging branch. I have merged your changes into the staging branch, and it should go to master with the next release. I like to keep the master in sync with the last release, at this point anyway. So I manually close this pull request for GitHub's sake.
Hey nice to see you back, and thank you for the fix!
Reviewers