Update e_Interpretation.php

stutteringp0et commented

2020-08-13 13:56:07 +00:00

(Migrated from github.com)

When field default is DATETIME or CURRENT_TIMESTAMP, the SQL is constructed out of order. The default gets inserted before the NULL/NOT NULL string. One line fix - YAY!

Pull Request for Issue gh-585 .

Summary of Changes

Fixed compilation order

Testing Instructions

Create datetime field with DATETIME or CURRENT_TIMESTAMP as default

Expected result

received_timestamp DATETIME NOT NULL CURRENT_TIMESTAMP

Actual result

received_timestamp DATETIME NOT NULL CURRENT_TIMESTAMP

Documentation Changes Required

none

When field default is DATETIME or CURRENT_TIMESTAMP, the SQL is constructed out of order. The default gets inserted before the NULL/NOT NULL string. One line fix - YAY! Pull Request for Issue gh-585 . ### Summary of Changes Fixed compilation order ### Testing Instructions Create datetime field with DATETIME or CURRENT_TIMESTAMP as default ### Expected result `received_timestamp` DATETIME NOT NULL CURRENT_TIMESTAMP ### Actual result `received_timestamp` DATETIME NOT NULL CURRENT_TIMESTAMP ### Documentation Changes Required none

Llewellyn commented

2020-08-13 23:11:08 +00:00

Please make pull request in the future against the staging branch. I have merged your changes into the staging branch, and it should go to master with the next release. I like to keep the master in sync with the last release, at this point anyway. So I manually close this pull request for GitHub's sake.

Hey nice to see you back, and thank you for the fix!

Please make pull request in the future against the staging branch. I have merged your changes into the staging branch, and it should go to master with the next release. I like to keep the master in sync with the last release, at this point anyway. So I manually close this pull request for GitHub's sake. Hey nice to see you back, and thank you for the fix!

👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Update e_Interpretation.php #586