Major upgrade, with new filter system, and many bug fixes. #618

Merged

Llewellyn merged 25 commits from staging into master

2020-12-12 06:53:26 +00:00

Llewellyn commented

2020-12-07 16:27:15 +00:00

Owner

Pull Request for Issue gh-378, gh-609, gh-612, gh-616.

Summary of Changes

Fixed Warning: Invalid argument supplied for foreach() in ../html/libraries/cms/html/select.php on line 592 by adding empty select option.
Resolve gh-609 to make sure that custom code set in a field that gets linked to a module will get added to the module.
Removed legacy code from site views, that is no longer needed. Resolved gh-612
Added filters above the admin list views to resolve gh-378
Fixed the access filter in query.
Fixed the array to int helper use.
Added the correct language strings to category and access filters. gh-378
Added sql to the uninstall sql to remove changes made to the assets table on uninstall of a component. resolved gh-616
Fixed the file naming colution for the new filters. gh-378
Use the new select language string in filters.
Fixed category column naming issue in array query.
Added the category code to the new filters area. gh-378
Update the direction default the descending.
Added getListViewDefaultOrdering method to compiler.
Moved getFieldDatabaseName to the get class of the compiler.
Updated the setFieldFilterListSet method.
Imporved the filter query code to ignore empty values. gh-378
Moved the default static code of the admin list views to compiler. gh-378
Added the getCustomFieldCode, setFieldFilterSet, setFieldFilterListSet, setFilterFieldFile methods to the field compiler area.
Refactored few other methods and added setDefaultSidebarFilterHelper, setCategorySidebarFilterHelper, setBatchDisplayHelper, setDefaultBatchHelper, setCategoryBatchHelper methods in the integration area of the compiler.
Improved the header ser feature and added the setCategoryBatchHelper method. gh-378
Add getFieldsetXML and getFieldXMLString method to build fields in compiler gh-378.
Refactoring the compiler to use camelcase for view code names.
Refactored the setFilterFields and setStoredId in the compiler as still part of the new filter option improvement. gh-378
Updated the contribute area in README.
Added the multi filter query method, and adapted the setFilterQuery method for the new filter options. gh-378
Added the admin filter type switch to compiler gh-378.
Moved the name_single and name_list to the view->name_list and view->name_list_code in the compiler (refactoring).
Added the new field changes for the new filter implementation. gh-378
Fixed gh-609 so that JS and CSS from fields are added to module.
Also formatted the class with auto code reformat in phpstorm.

Testing Instructions

Look over all the issues fixed, resolved and test accordingly.

Expected result

That all issues are resolved.

Documentation Changes Required

How to use the new filters
How to use the custom js and css in modules
and more..

Pull Request for Issue gh-378, gh-609, gh-612, gh-616. ### Summary of Changes - Fixed Warning: Invalid argument supplied for foreach() in ../html/libraries/cms/html/select.php on line 592 by adding empty select option. - Resolve gh-609 to make sure that custom code set in a field that gets linked to a module will get added to the module. - Removed legacy code from site views, that is no longer needed. Resolved gh-612 - Added filters above the admin list views to resolve gh-378 - Fixed the access filter in query. - Fixed the array to int helper use. - Added the correct language strings to category and access filters. gh-378 - Added sql to the uninstall sql to remove changes made to the assets table on uninstall of a component. resolved gh-616 - Fixed the file naming colution for the new filters. gh-378 - Use the new select language string in filters. - Fixed category column naming issue in array query. - Added the category code to the new filters area. gh-378 - Update the direction default the descending. - Added getListViewDefaultOrdering method to compiler. - Moved getFieldDatabaseName to the get class of the compiler. - Updated the setFieldFilterListSet method. - Imporved the filter query code to ignore empty values. gh-378 - Moved the default static code of the admin list views to compiler. gh-378 - Added the getCustomFieldCode, setFieldFilterSet, setFieldFilterListSet, setFilterFieldFile methods to the field compiler area. - Refactored few other methods and added setDefaultSidebarFilterHelper, setCategorySidebarFilterHelper, setBatchDisplayHelper, setDefaultBatchHelper, setCategoryBatchHelper methods in the integration area of the compiler. - Improved the header ser feature and added the setCategoryBatchHelper method. gh-378 - Add getFieldsetXML and getFieldXMLString method to build fields in compiler gh-378. - Refactoring the compiler to use camelcase for view code names. - Refactored the setFilterFields and setStoredId in the compiler as still part of the new filter option improvement. gh-378 - Updated the contribute area in README. - Added the multi filter query method, and adapted the setFilterQuery method for the new filter options. gh-378 - Added the admin filter type switch to compiler gh-378. - Moved the name_single and name_list to the view->name_list and view->name_list_code in the compiler (refactoring). - Added the new field changes for the new filter implementation. gh-378 - Fixed gh-609 so that JS and CSS from fields are added to module. - Also formatted the class with auto code reformat in phpstorm. ### Testing Instructions Look over all the issues fixed, resolved and test accordingly. ### Expected result That all issues are resolved. ### Documentation Changes Required - How to use the new filters - How to use the custom js and css in modules - and more..

Oh Martin approved these changes 2020-12-09 07:19:41 +00:00

Oh Martin left a comment

First-time contributor

The new filters above the list views works like a charm and JCB's performance has improved with the new changes!

Oh Martin reviewed 2020-12-09 11:23:03 +00:00

Oh Martin left a comment

First-time contributor

When I select multiple items in the list admin view, I get this NOTICE:

Notice: Array to string conversion in /var/www/html/administrator/components/com_ehealth_portal/models/vmmcs.php on line 458

When I set a custom fields's filter option to Yes (multi), I get this error on compilation

When I Insert the above code snippet into the custom field, the component compiles successfully and when I try filtering (by selecting multiple items) in the admin list view I get this ERROR:

**When I select multiple items in the list admin view, I get this NOTICE:** Notice: Array to string conversion in /var/www/html/administrator/components/com_ehealth_portal/models/vmmcs.php on line 458 **When I set a custom fields's filter option to `Yes (multi)`, I get this error on compilation** ![Screenshot from 2020-12-09 12-48-35](https://user-images.githubusercontent.com/38046346/101623089-98b07e00-3a20-11eb-8ed8-1ac09b309ec0.png) **When I Insert the above code snippet into the custom field, the component compiles successfully and when I try filtering (by selecting multiple items) in the admin list view I get this ERROR:** ![Screenshot from 2020-12-09 13-08-36](https://user-images.githubusercontent.com/38046346/101623578-52a7ea00-3a21-11eb-8442-aa28f1b52310.png)

Llewellyn commented

2020-12-10 04:46:55 +00:00

Author

Owner

Okay so the issue was related to the getStoredId method, and is now resolved, please check again and let me know.

Oh Martin commented

2020-12-10 07:58:16 +00:00

First-time contributor

@Llewellynvdm

Multi item filtering in custom fields works well now, However I just discovered two more issues which are:

When I filter fields by their categories in JCB's Fields list view, I get the following:
Notice: Array to string conversion in /var/www/html/administrator/components/com_componentbuilder/models/fields.php on line 655

And when I filter field-types by their categories in JCB's Fieldtypes list view, I get the following:
Notice: Array to string conversion in /var/www/html/administrator/components/com_componentbuilder/models/fieldtypes.php on line 411

@Llewellynvdm Multi item filtering in custom fields works well now, However I just discovered two more issues which are: **When I filter fields by their categories in JCB's Fields list view, I get the following:** Notice: Array to string conversion in /var/www/html/administrator/components/com_componentbuilder/models/fields.php on line 655 **And when I filter field-types by their categories in JCB's Fieldtypes list view, I get the following:** Notice: Array to string conversion in /var/www/html/administrator/components/com_componentbuilder/models/fieldtypes.php on line 411

Llewellyn commented

2020-12-11 02:27:29 +00:00

Author

Owner

So the category filter was also now fixed, please confirm this.