joomla
/
Component-Builder
15
11
Fork 3
Code Issues 52 Pull Requests Projects 3 Releases Wiki Activity
Labels Milestones

Bug fixes #641

Merged
Llewellyn merged 10 commits from staging into master 2 years ago
Conversation 0 Commits 10 Files Changed 1517
Llewellyn commented 2 years ago
Owner

Pull Request for Issue gh-629, gh-630, gh-626, gh-637 .

Summary of Changes

  • Fixed gh-637 so that the header values will be added.
  • Updated the copyright to only show the first year so we need not update these again.
  • Improved the layout compiler methods.
  • Added the trash helper option to JCB as a pro feature.
  • Added more header options and renamed the header method in the compiler.
  • Improved the compiler message area.
  • Fixed gh-626 to ensure that language strings that are already uppercase do not get added, even if it has a number.
  • Fixed gh-630 by moving the templatestyle field type to the plain field group.
  • Improved the permissions adding behaviour so that no permissions tab will be added if no permissions are set in a view. gh-629
  • Fixed gh-629 to add a hidden title field when a view does not have a title field.
  • Updated the forum details

Testing Instructions

Please read the related issues, and test accordingly.

Expected result

That all issues are fixed

Pull Request for Issue gh-629, gh-630, gh-626, gh-637 . ### Summary of Changes - Fixed gh-637 so that the header values will be added. - Updated the copyright to only show the first year so we need not update these again. - Improved the layout compiler methods. - Added the trash helper option to JCB as a pro feature. - Added more header options and renamed the header method in the compiler. - Improved the compiler message area. - Fixed gh-626 to ensure that language strings that are already uppercase do not get added, even if it has a number. - Fixed gh-630 by moving the templatestyle field type to the plain field group. - Improved the permissions adding behaviour so that no permissions tab will be added if no permissions are set in a view. gh-629 - Fixed gh-629 to add a hidden title field when a view does not have a title field. - Updated the forum details ### Testing Instructions Please read the related issues, and test accordingly. ### Expected result That all issues are fixed
Oh Martin approved these changes 2 years ago
Oh Martin left a comment
Collaborator

###SITE_ADMIN_VIEW_HEADER### placeholder now gets replaced by the appropriate header code and all the toolbar buttons are now active and functional. The trash helper methods also work very well, thanks!

`###SITE_ADMIN_VIEW_HEADER###` placeholder now gets replaced by the appropriate header code and all the toolbar buttons are now active and functional. The trash helper methods also work very well, thanks!

Reviewers

Oh Martin approved these changes 2 years ago
The pull request has been merged as d9da5d9fc4.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Oh Martin
Labels
Apply labels
Clear labels
Bug Documentation enhancement help wanted invalid joomla
Joomla related changes question URGENT wontfix
No Label Bug Documentation enhancement help wanted invalid joomla question URGENT wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#641
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'staging'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes