joomla/Component-Builder
joomla/Component-Builder
40
24
Fork 11
Code Issues 89 Pull Requests Projects 4 Wiki Activity

Bug fixes #641

Merged
Llewellyn merged 1 commits from staging into master 2025-01-18 08:00:39 +00:00
Conversation 1 Commits 1 Files Changed 1467 +1491 -1481
Llewellyn commented 2021-01-03 16:56:27 +00:00
Owner
Copy Link

Pull Request for Issue gh-629, gh-630, gh-626, gh-637 .

Summary of Changes

  • Fixed gh-637 so that the header values will be added.
  • Updated the copyright to only show the first year so we need not update these again.
  • Improved the layout compiler methods.
  • Added the trash helper option to JCB as a pro feature.
  • Added more header options and renamed the header method in the compiler.
  • Improved the compiler message area.
  • Fixed gh-626 to ensure that language strings that are already uppercase do not get added, even if it has a number.
  • Fixed gh-630 by moving the templatestyle field type to the plain field group.
  • Improved the permissions adding behaviour so that no permissions tab will be added if no permissions are set in a view. gh-629
  • Fixed gh-629 to add a hidden title field when a view does not have a title field.
  • Updated the forum details

Testing Instructions

Please read the related issues, and test accordingly.

Expected result

That all issues are fixed

Pull Request for Issue gh-629, gh-630, gh-626, gh-637 . ### Summary of Changes - Fixed gh-637 so that the header values will be added. - Updated the copyright to only show the first year so we need not update these again. - Improved the layout compiler methods. - Added the trash helper option to JCB as a pro feature. - Added more header options and renamed the header method in the compiler. - Improved the compiler message area. - Fixed gh-626 to ensure that language strings that are already uppercase do not get added, even if it has a number. - Fixed gh-630 by moving the templatestyle field type to the plain field group. - Improved the permissions adding behaviour so that no permissions tab will be added if no permissions are set in a view. gh-629 - Fixed gh-629 to add a hidden title field when a view does not have a title field. - Updated the forum details ### Testing Instructions Please read the related issues, and test accordingly. ### Expected result That all issues are fixed
Oh approved these changes 2021-01-04 08:56:14 +00:00
Oh left a comment
First-time contributor
Copy Link

###SITE_ADMIN_VIEW_HEADER### placeholder now gets replaced by the appropriate header code and all the toolbar buttons are now active and functional. The trash helper methods also work very well, thanks!

`###SITE_ADMIN_VIEW_HEADER###` placeholder now gets replaced by the appropriate header code and all the toolbar buttons are now active and functional. The trash helper methods also work very well, thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Oh
Labels
Clear labels
Beta
Issues related to the a beta release
Bug
Documentation
enhancement
help wanted
invalid
joomla
Joomla related changes
question
URGENT
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joomla/Component-Builder#641
No description provided.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?