joomla/Component-Builder
42
28 Fork 13
Code Issues 56 Pull Requests Projects Wiki Activity

Complete implementation of the language manager/translator feature. #67

Merged
Llewellyn merged 1 commits from staging into master 2025-01-18 08:00:37 +00:00
Conversation 13 Commits 1 Files Changed 186
+212 -194
Llewellyn commented 2017-04-07 20:37:18 +00:00
Owner
Copy link
Copy source

Yes will still expand this translator feature more, but this is the complete basic needed function for translations of the English strings.

Yes will still expand this translator feature more, but this is the complete basic needed function for translations of the English strings.
🎉 1
admin/helpers/compiler/a_Get.php
@@ -3241,0 +3331,4 @@
}
else
{
// remove the string since no translation found and not linked to any other component
Llewellyn commented 2017-04-07 20:39:25 +00:00
Author
Owner
Copy link
Copy source

Added a purge function the clear unused language strings from the database and unlink them from the related component during compilation.

Added a purge function the clear unused language strings from the database and unlink them from the related component during compilation.
admin/helpers/compiler/e_Interpretation.php
Llewellyn commented 2017-04-07 20:40:34 +00:00
Author
Owner
Copy link
Copy source

Oops typo!

Oops typo!
ro-ot (Migrated from github.com) reviewed 2017-04-08 11:27:31 +00:00
admin/helpers/compiler/a_Get.php
@@ -3241,0 +3331,4 @@
}
else
{
// remove the string since no translation found and not linked to any other component
ro-ot (Migrated from github.com) commented 2017-04-08 11:27:31 +00:00
Author
Owner
Copy link
Copy source

Works well, wonder if it should run every time.

Works well, wonder if it should run every time.
ro-ot (Migrated from github.com) approved these changes 2017-04-08 11:28:39 +00:00
ro-ot (Migrated from github.com) left a comment
Author
Owner
Copy link
Copy source

Tested it and seems to work as intended.

Tested it and seems to work as intended.
ro-ot (Migrated from github.com) reviewed 2017-04-08 11:32:54 +00:00
admin/models/import_joomla_components.php
ro-ot (Migrated from github.com) commented 2017-04-08 11:32:54 +00:00
Author
Owner
Copy link
Copy source

Smart move, to keep already translated strings. I would think it should check the language also, to avoid conflict of multipel translation strings of the same language.

Smart move, to keep already translated strings. I would think it should check the language also, to avoid conflict of multipel translation strings of the same language.
ro-ot (Migrated from github.com) reviewed 2017-04-08 11:33:39 +00:00
admin/models/joomla_component.php
@@ -621,2 +629,4 @@
$componentCounter = ' - <small>' . JText::_('COM_COMPONENTBUILDER_USED_IN') . ' ' . count($item->components) . '</small>';
}
// load the languages to the string
if (ComponentbuilderHelper::checkArray($langBucket))
ro-ot (Migrated from github.com) commented 2017-04-08 11:33:38 +00:00
Author
Owner
Copy link
Copy source

nice tweak 👍

nice tweak :+1:
Llewellyn commented 2017-04-08 18:56:37 +00:00
Author
Owner
Copy link
Copy source

@mwweb how is this release working for you?

@mwweb how is [this release](https://github.com/vdm-io/Joomla-Component-Builder/archive/7afbb131ce8091e0e31092c44892511255bf127e.zip) working for you?
mwweb commented 2017-04-08 19:27:42 +00:00
First-time contributor
Copy link
Copy source

I haven't had a chance to look at it. I will try to today.

I haven't had a chance to look at it. I will try to today.
admin/models/import_joomla_components.php
Llewellyn commented 2017-04-08 20:55:55 +00:00
Author
Owner
Copy link
Copy source

Hi @mwweb this is the fix for the issue you reported in issue #53 please test this version and let me know if the error continues.

Hi @mwweb this is the fix for the issue you reported in issue #53 please test [this version](https://github.com/vdm-io/Joomla-Component-Builder/archive/f39a877db28d7ce8bf6cede2b6a4d4057c26a835.zip) and let me know if the error continues.
ro-ot (Migrated from github.com) approved these changes 2017-04-08 21:48:23 +00:00
ro-ot (Migrated from github.com) left a comment
Author
Owner
Copy link
Copy source

Can we get this PR merged!

Can we get this PR merged!
ro-ot commented 2017-04-08 21:52:17 +00:00 (Migrated from github.com)
Author
Owner
Copy link
Copy source

@Llewellynvdm I think it is stable enough to merge this Pull request. So we can get some of these fixes out to all as the next release.

@Llewellynvdm I think it is stable enough to merge this Pull request. So we can get some of these fixes out to all as the next release.
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
mwweb
Llewellyn
ro-ot
Labels
Clear labels
Beta
Issues related to the a beta release
 Bug
Documentation
URGENT
enhancement
help wanted
invalid
joomla
Joomla related changes
 question
wontfix
No labels enhancement
Milestone
No items
No Milestone Major improvement to core (speedup production)
Projects
Clear projects
No projects
Assignees
Clear assignees
aamigo Eunice Hannah Jeff Lemuel Llewellyn Malachi Roline vistamedia Martin (Martin Kopp) aB0t (Robot) ro-ot (root) TLWebdesign (Tom van der Laan)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joomla/Component-Builder#67