joomla/Component-Builder
joomla
/
Component-Builder
38
19
Fork 11
Code Issues 41 Pull Requests Projects 3 Releases Wiki Activity

Complete implementation of the language manager/translator feature. #67

Merged
Llewellyn merged 6 commits from staging into master 2017-04-08 22:04:21 +00:00
Conversation 3 Commits 6 Files Changed 228 +865 -514
Llewellyn commented 2017-04-07 20:37:18 +00:00
Owner
Copy Link

Yes will still expand this translator feature more, but this is the complete basic needed function for translations of the English strings.

Yes will still expand this translator feature more, but this is the complete basic needed function for translations of the English strings.
🎉 1
mwweb (Migrated from github.com) reviewed 2017-04-07 20:37:18 +00:00
Llewellyn reviewed 2017-04-07 20:39:25 +00:00
admin/helpers/compiler/a_Get.php
@ -3241,0 +3331,4 @@
}
else
{
// remove the string since no translation found and not linked to any other component
Llewellyn commented 2017-04-07 20:39:25 +00:00
Author
Owner
Copy Link

Added a purge function the clear unused language strings from the database and unlink them from the related component during compilation.

Added a purge function the clear unused language strings from the database and unlink them from the related component during compilation.
Llewellyn reviewed 2017-04-07 20:40:34 +00:00
admin/helpers/compiler/e_Interpretation.php
Llewellyn commented 2017-04-07 20:40:34 +00:00
Author
Owner
Copy Link

Oops typo!

Oops typo!
Llewellyn reviewed 2017-04-07 20:40:47 +00:00
admin/helpers/compiler/e_Interpretation.php
Llewellyn commented 2017-04-07 20:40:47 +00:00
Author
Owner
Copy Link

Bug!!

Bug!!
ro-ot (Migrated from github.com) reviewed 2017-04-08 11:27:31 +00:00
admin/helpers/compiler/a_Get.php
@ -3241,0 +3331,4 @@
}
else
{
// remove the string since no translation found and not linked to any other component
ro-ot (Migrated from github.com) commented 2017-04-08 11:27:31 +00:00
Author
Owner
Copy Link

Works well, wonder if it should run every time.

Works well, wonder if it should run every time.
ro-ot (Migrated from github.com) approved these changes 2017-04-08 11:28:39 +00:00
ro-ot (Migrated from github.com) left a comment
Author
Owner
Copy Link

Tested it and seems to work as intended.

Tested it and seems to work as intended.
ro-ot (Migrated from github.com) reviewed 2017-04-08 11:32:54 +00:00
admin/models/import_joomla_components.php
ro-ot (Migrated from github.com) commented 2017-04-08 11:32:54 +00:00
Author
Owner
Copy Link

Smart move, to keep already translated strings. I would think it should check the language also, to avoid conflict of multipel translation strings of the same language.

Smart move, to keep already translated strings. I would think it should check the language also, to avoid conflict of multipel translation strings of the same language.
ro-ot (Migrated from github.com) reviewed 2017-04-08 11:33:39 +00:00
admin/models/joomla_component.php
@ -621,2 +629,4 @@
$componentCounter = ' - <small>' . JText::_('COM_COMPONENTBUILDER_USED_IN') . ' ' . count($item->components) . '</small>';
}
// load the languages to the string
if (ComponentbuilderHelper::checkArray($langBucket))
ro-ot (Migrated from github.com) commented 2017-04-08 11:33:38 +00:00
Author
Owner
Copy Link

nice tweak 👍

nice tweak :+1:
Llewellyn commented 2017-04-08 18:56:37 +00:00
Author
Owner
Copy Link

@mwweb how is this release working for you?

@mwweb how is [this release](https://github.com/vdm-io/Joomla-Component-Builder/archive/7afbb131ce8091e0e31092c44892511255bf127e.zip) working for you?
mwweb commented 2017-04-08 19:27:42 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

I haven't had a chance to look at it. I will try to today.

I haven't had a chance to look at it. I will try to today.
Llewellyn reviewed 2017-04-08 20:55:55 +00:00
admin/models/import_joomla_components.php
Llewellyn commented 2017-04-08 20:55:55 +00:00
Author
Owner
Copy Link

Hi @mwweb this is the fix for the issue you reported in issue #53 please test this version and let me know if the error continues.

Hi @mwweb this is the fix for the issue you reported in issue #53 please test [this version](https://github.com/vdm-io/Joomla-Component-Builder/archive/f39a877db28d7ce8bf6cede2b6a4d4057c26a835.zip) and let me know if the error continues.
ro-ot (Migrated from github.com) approved these changes 2017-04-08 21:48:23 +00:00
ro-ot (Migrated from github.com) left a comment
Author
Owner
Copy Link

Can we get this PR merged!

Can we get this PR merged!
ro-ot commented 2017-04-08 21:52:17 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

@Llewellynvdm I think it is stable enough to merge this Pull request. So we can get some of these fixes out to all as the next release.

@Llewellynvdm I think it is stable enough to merge this Pull request. So we can get some of these fixes out to all as the next release.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
mwweb
ro-ot
Labels
Clear labels   
Beta

Issues related to the a beta release

  
Bug

   
Documentation

   
enhancement

   
help wanted

   
invalid

   
joomla

Joomla related changes

  
question

   
URGENT

   
wontfix
No Label
Beta
Bug
Documentation
enhancement
help wanted
invalid
joomla
question
URGENT
wontfix
Milestone
Clear milestone
No items
No Milestone
Major improvement to core (speedup production)
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#67
No description provided.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?