joomla/Component-Builder
joomla/Component-Builder
39
23
Fork 11
Code Issues 83 Pull Requests Projects 4 Wiki Activity

Urgent fix for Joomla 3.9.25 #679

Merged
Llewellyn merged 2 commits from staging into master 2021-03-05 01:48:51 +00:00
Conversation 1 Commits 2 Files Changed 12 +95 -35
Llewellyn commented 2021-03-04 06:19:47 +00:00
Owner
Copy Link

Pull Request for Issue gh-678.

Summary of Changes

Fixed gh-678 moved the compilation success message out of the redirection message to a user state message, that get loaded to the page on successful compilation. This preserves the button scripts needed to install the compiled packages.

Testing Instructions

Upgrade to Joomla 3.9.25, and install this patch. Then the compiler page should work as expected.

Expected result

That JCB would work in Joomla 3.9.25 as always.

Actual result

The Joomla 3.9.25 update broke the compiler page installation buttons.

Pull Request for Issue gh-678. ### Summary of Changes Fixed gh-678 moved the compilation success message out of the redirection message to a user state message, that get loaded to the page on successful compilation. This preserves the button scripts needed to install the compiled packages. ### Testing Instructions Upgrade to Joomla 3.9.25, and install this patch. Then the compiler page should work as expected. ### Expected result That JCB would work in Joomla 3.9.25 as always. ### Actual result The Joomla 3.9.25 update broke the compiler page installation buttons.
Oh commented 2021-03-04 06:45:35 +00:00
First-time contributor
Copy Link

Quickly upgrading JCB to the current staging branch to test this

Quickly upgrading JCB to the current staging branch to test this
Oh approved these changes 2021-03-04 06:50:02 +00:00
Oh left a comment
First-time contributor
Copy Link

Compiler Install function now works on Joomla 3.9.25 with the latest JCB staging branch

Compiler Install function now works on **Joomla 3.9.25** with the latest **JCB** staging branch
Sign in to join this conversation.
Reviewers
No reviewers
Oh
Labels
Clear labels   
Beta

Issues related to the a beta release

  
Bug

   
Documentation

   
enhancement

   
help wanted

   
invalid

   
joomla

Joomla related changes

  
question

   
URGENT

   
wontfix
No Label
Beta
Bug
Documentation
enhancement
help wanted
invalid
joomla
question
URGENT
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#679
No description provided.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?