Urgent fix for Joomla 3.9.25 #679

Merged
Llewellyn merged 2 commits from staging into master 2 years ago
Owner

Pull Request for Issue gh-678.

Summary of Changes

Fixed gh-678 moved the compilation success message out of the redirection message to a user state message, that get loaded to the page on successful compilation. This preserves the button scripts needed to install the compiled packages.

Testing Instructions

Upgrade to Joomla 3.9.25, and install this patch. Then the compiler page should work as expected.

Expected result

That JCB would work in Joomla 3.9.25 as always.

Actual result

The Joomla 3.9.25 update broke the compiler page installation buttons.

Pull Request for Issue gh-678. ### Summary of Changes Fixed gh-678 moved the compilation success message out of the redirection message to a user state message, that get loaded to the page on successful compilation. This preserves the button scripts needed to install the compiled packages. ### Testing Instructions Upgrade to Joomla 3.9.25, and install this patch. Then the compiler page should work as expected. ### Expected result That JCB would work in Joomla 3.9.25 as always. ### Actual result The Joomla 3.9.25 update broke the compiler page installation buttons.
Collaborator

Quickly upgrading JCB to the current staging branch to test this

Quickly upgrading JCB to the current staging branch to test this
Oh Martin approved these changes 2 years ago
Oh Martin left a comment
Collaborator

Compiler Install function now works on Joomla 3.9.25 with the latest JCB staging branch

Compiler Install function now works on **Joomla 3.9.25** with the latest **JCB** staging branch

Reviewers

Oh Martin approved these changes 2 years ago
The pull request has been merged as 192d44b477.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#679
Loading…
There is no content yet.