joomla/Component-Builder
42
28 Fork 13
Code Issues 56 Pull Requests Projects Wiki Activity

Solve the problem of repeating the siteview name twice by the router's build method #759

Merged
saman222 merged 1 commits from staging into staging 2021-06-26 01:22:11 +00:00
Conversation 5 Commits 1 Files Changed 1
+1 -1
saman222 commented 2021-06-14 11:08:29 +00:00 (Migrated from github.com)
Copy link
Copy source

when we build link with ID and without Itemid, router's build method repeats siteview name twice in 'SEF' situation.
like:
mysite.com/index.php/component/componentname/siteviewname/siteviewname/id

when we build link with ID and without Itemid, router's build method repeats siteview name twice in 'SEF' situation. like: mysite.com/index.php/component/componentname/siteviewname/siteviewname/id
Llewellyn commented 2021-06-14 23:53:54 +00:00
Copy link
Copy source

After our last JUG meeting we had a conversation to refactor the router in JCB, you should join the working group ;)

We would like to move JCB to the new router implementation seen here in action, as this will help moving JCB to Joomla 4.

After our last JUG meeting we had a conversation to refactor the router in JCB, you should join the working group ;) We would like to move JCB to the new router implementation [seen here in action](https://github.com/joomla-extensions/pkg_languagepack/blob/master/com_languagepack/site/router.php), as this will help moving JCB to Joomla 4.
Oh commented 2021-06-15 22:04:02 +00:00
First-time contributor
Copy link
Copy source

when we build link with ID and without Itemid, router's build method repeats siteview name twice in 'SEF' situation.
like:
mysite.com/index.php/component/componentname/siteviewname/siteviewname/id

Hey @saman222,
May you please provide a more detailed step by step process on how to replicate this for testing?

> when we build link with ID and without Itemid, router's build method repeats siteview name twice in 'SEF' situation. > like: > mysite.com/index.php/component/componentname/siteviewname/siteviewname/id Hey @saman222, May you please provide a more detailed step by step process on how to replicate this for testing?
saman222 commented 2021-06-19 04:56:33 +00:00 (Migrated from github.com)
Copy link
Copy source

when we build link with ID and without Itemid, router's build method repeats siteview name twice in 'SEF' situation.
like:
mysite.com/index.php/component/componentname/siteviewname/siteviewname/id

Hey @saman222,
May you please provide a more detailed step by step process on how to replicate this for testing?

hi @ohrionmartin
suppose there is a site view called courseDetail and in this site view we want to enter another site view through the link given by the following command
JRoute :: _ (index.php?Option=com_moojla&view=teacherDetail&id=452)
in this case , by turning on SEF URL's we expect the following link to be generated for us to transfer to teacherDetail site view
www.example.com/index.ph/fa/component/moojla/teacherdetail/452
but the link produced is as follow
www.example.com/index.ph/fa/component/moojla/teacherdetail/teacherdetail/452

picture 1 :
1

picture 2 :
2

> > > > when we build link with ID and without Itemid, router's build method repeats siteview name twice in 'SEF' situation. > > like: > > mysite.com/index.php/component/componentname/siteviewname/siteviewname/id > > Hey @saman222, > May you please provide a more detailed step by step process on how to replicate this for testing? hi @ohrionmartin suppose there is a site view called courseDetail and in this site view we want to enter another site view through the link given by the following command JRoute :: _ (index.php?Option=com_moojla&view=teacherDetail&id=452) in this case , by turning on SEF URL's we expect the following link to be generated for us to transfer to teacherDetail site view www.example.com/index.ph/fa/component/moojla/teacherdetail/452 but the link produced is as follow www.example.com/index.ph/fa/component/moojla/teacherdetail/teacherdetail/452 picture 1 : ![1](https://user-images.githubusercontent.com/13805543/122631331-658e2c00-d0e0-11eb-924b-03e0eaf6f904.png) picture 2 : ![2](https://user-images.githubusercontent.com/13805543/122631333-6757ef80-d0e0-11eb-95b3-530389f9152a.png)
Oh approved these changes 2021-06-21 09:04:26 +00:00
saman222 commented 2021-06-25 08:46:50 +00:00 (Migrated from github.com)
Copy link
Copy source

excuse me can you say is my commit approved ? if yes why https://github.com/vdm-io/Joomla-Component-Builder/blob/staging/admin/compiler/joomla_3/router.php not changed?

excuse me can you say is my commit approved ? if yes why https://github.com/vdm-io/Joomla-Component-Builder/blob/staging/admin/compiler/joomla_3/router.php not changed?
Sign in to join this conversation.
Reviewers
No Reviewers
Oh
Labels
Clear labels
Beta
Issues related to the a beta release
 Bug
Documentation
URGENT
enhancement
help wanted
invalid
joomla
Joomla related changes
 question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
aamigo Eunice Hannah Jeff Lemuel Llewellyn Malachi Roline vistamedia Martin (Martin Kopp) aB0t (Robot) ro-ot (root) TLWebdesign (Tom van der Laan)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joomla/Component-Builder#759