joomla
/
Component-Builder
41
17
Fork 6
Code Issues 64 Pull Requests Projects 3 Releases Wiki Activity

Implement the Plugin sql updates #842

Closed
saman222 wants to merge 0 commits from staging into staging
pull from: staging
merge into: joomla:staging
Conversation 5 Commits - Files Changed -
saman222 commented 2021-12-27 07:48:25 +00:00 (Migrated from github.com)

I checked the JCB codes and tried to implement the plugin sql updates section , which did not work , according to the JCB structure

I checked the JCB codes and tried to implement the plugin sql updates section , which did not work , according to the JCB structure
Llewellyn commented 2021-12-30 12:26:42 +00:00

I have looked over the code, and for the most part you did a great job... but I think there is a simpler way, that does not need us
messing with some of the function you touched.

I am a little over occupied at the moment, but will give it another look the second or third week or so in the new year.

I have looked over the code, and for the most part you did a great job... but I think there is a simpler way, that does not need us messing with some of the function you touched. I am a little over occupied at the moment, but will give it another look the second or third week or so in the new year.
saman222 commented 2021-12-30 18:12:53 +00:00 (Migrated from github.com)

I'm trying to get a professional membership. Do you accept this commit of mine as my second commit, regardless of whether you apply it or not?
I spend many time to do this commit.
And i want to go for 3rd commit. Have you any reformable code suggest?

I'm trying to get a professional membership. Do you accept this commit of mine as my second commit, regardless of whether you apply it or not? I spend many time to do this commit. And i want to go for 3rd commit. Have you any reformable code suggest?
Llewellyn commented 2021-12-30 19:34:14 +00:00

I will in good faith give you access trusting that you will continue to help and contribute to JCB ;) happy new year!

I will in good faith give you access trusting that you will continue to help and contribute to JCB ;) happy new year!
❤️ 1 🎉 1
saman222 commented 2021-12-30 20:16:37 +00:00 (Migrated from github.com)

Thank you very much @Llewellynvdm .
I was looking forward to this moment. I will definitely try to play an active role.

Thank you very much @Llewellynvdm . I was looking forward to this moment. I will definitely try to play an active role.
saman222 commented 2022-01-01 04:51:21 +00:00 (Migrated from github.com)

hi @Llewellynvdm
if you give me a little guidance, i can implement Plugin sql updates with your standard path and code style.

hi @Llewellynvdm if you give me a little guidance, i can implement Plugin sql updates with your standard path and code style.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Beta

Issues related to the a beta release   
Bug
   
Documentation
   
enhancement
   
help wanted
   
invalid
   
joomla

Joomla related changes   
question
   
URGENT
   
wontfix
No Label
Beta
Bug
Documentation
enhancement
help wanted
invalid
joomla
question
URGENT
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#842
There is no content yet.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?