joomla/Component-Builder
40
26
Fork 12
Code Issues 84 Pull Requests 2 Projects 4 Wiki Activity

Fix Database IF NOT EXISTS issue for older databases and updated marked.js (vulnerability) #854

Merged
Llewellyn merged 1 commits from staging into master 2025-01-18 08:00:40 +00:00
Conversation 3 Commits 1 Files Changed 36 +510 -67
Llewellyn commented 2022-01-15 18:01:24 +00:00
Owner
Copy Link

Pull Request for Issue gh-841.

Summary of Changes

  • Updates marked JS package.
  • Adds more events to the compiler.
  • Fix gh-841 database issue (IF NOT EXISTS).
  • Update Agerix banner link.
  • Adds more clone options.

Testing Instructions

Check that the database issue is resolved and that you can clone files_folders, component_modules, component_plugins, component_placeholders, component_dashboards. Also check that all notices that get converted with marked.js loads correctly.

Pull Request for Issue gh-841. ### Summary of Changes - Updates marked JS package. - Adds more events to the compiler. - Fix gh-841 database issue (IF NOT EXISTS). - Update Agerix banner link. - Adds more clone options. ### Testing Instructions Check that the database issue is resolved and that you can clone files_folders, component_modules, component_plugins, component_placeholders, component_dashboards. Also check that all notices that get converted with marked.js loads correctly.
Oh approved these changes 2022-01-16 15:14:49 +00:00
Oh left a comment
First-time contributor
Copy Link

I have not run into any issues while testing

I have not run into any issues while testing
cpaschen commented 2022-03-15 02:24:46 +00:00
First-time contributor
Copy Link

Should these fixes be present in 2.12.15?
(I'm not seeing the "IF NOT EXISTS" fix working there if it is)

Should these fixes be present in 2.12.15? (I'm not seeing the "IF NOT EXISTS" fix working there if it is)
cpaschen commented 2022-03-15 02:28:33 +00:00
First-time contributor
Copy Link

Ignore that. I was working on an old version of JCB that hadn't been updated yet.
Updated to 2.12.15 and works fine.

Ignore that. I was working on an old version of JCB that hadn't been updated yet. Updated to 2.12.15 and works fine.
Sign in to join this conversation.
Reviewers
No Reviewers
Oh
Labels
Clear labels
Beta
Issues related to the a beta release
Bug
Documentation
enhancement
help wanted
invalid
joomla
Joomla related changes
question
URGENT
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aamigo Lemuel Llewellyn Malachi Roline vistamedia Martin Martin Kopp aB0t Robot ro-ot root TLWebdesign Tom van der Laan
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joomla/Component-Builder#854
No description provided.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?