joomla
/
Component-Builder
41
17
Fork 6
Code Issues 64 Pull Requests Projects 3 Releases Wiki Activity

Fix Database IF NOT EXISTS issue for older databases and updated marked.js (vulnerability) #854

Merged
Llewellyn merged 2 commits from staging into master 2022-01-21 12:22:19 +00:00
Conversation 2 Commits 2 Files Changed 37
Llewellyn commented 2022-01-15 18:01:24 +00:00
Owner

Pull Request for Issue gh-841.

Summary of Changes

  • Updates marked JS package.
  • Adds more events to the compiler.
  • Fix gh-841 database issue (IF NOT EXISTS).
  • Update Agerix banner link.
  • Adds more clone options.

Testing Instructions

Check that the database issue is resolved and that you can clone files_folders, component_modules, component_plugins, component_placeholders, component_dashboards. Also check that all notices that get converted with marked.js loads correctly.

Pull Request for Issue gh-841. ### Summary of Changes - Updates marked JS package. - Adds more events to the compiler. - Fix gh-841 database issue (IF NOT EXISTS). - Update Agerix banner link. - Adds more clone options. ### Testing Instructions Check that the database issue is resolved and that you can clone files_folders, component_modules, component_plugins, component_placeholders, component_dashboards. Also check that all notices that get converted with marked.js loads correctly.
Oh Martin approved these changes 2022-01-16 15:14:49 +00:00
Oh Martin left a comment
Collaborator

I have not run into any issues while testing

I have not run into any issues while testing
cpaschen commented 2022-03-15 02:24:46 +00:00 (Migrated from github.com)
Poster
Owner

Should these fixes be present in 2.12.15?
(I'm not seeing the "IF NOT EXISTS" fix working there if it is)

Should these fixes be present in 2.12.15? (I'm not seeing the "IF NOT EXISTS" fix working there if it is)
cpaschen commented 2022-03-15 02:28:33 +00:00 (Migrated from github.com)
Poster
Owner

Ignore that. I was working on an old version of JCB that hadn't been updated yet.
Updated to 2.12.15 and works fine.

Ignore that. I was working on an old version of JCB that hadn't been updated yet. Updated to 2.12.15 and works fine.
Sign in to join this conversation.
Reviewers
No reviewers
Oh Martin
Labels
Clear labels   
Beta

Issues related to the a beta release   
Bug
   
Documentation
   
enhancement
   
help wanted
   
invalid
   
joomla

Joomla related changes   
question
   
URGENT
   
wontfix
No Label
Beta
Bug
Documentation
enhancement
help wanted
invalid
joomla
question
URGENT
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#854
There is no content yet.
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?