Remove specific type for adapter parameter from all installer methods #949

Merged
Llewellyn merged 1 commits from ggppdk/Component-Builder:j4_installer_compatibility into staging 6 months ago

Summary of Changes

Remove type for $adapter parameter for methods in Installer script

Testing Instructions

Try installing in J4,
You get error
...InstallerScript::postflight(): Argument #2 ($adapter) must be of type JAdapterInstance, Joomla\CMS\Installer\Adapter\ModuleAdapter given

Expected result

Installer succeeds in J4

Actual result

Installer fails in J4

Documentation Changes Required

None

### Summary of Changes Remove type for $adapter parameter for methods in Installer script ### Testing Instructions Try installing in J4, You get error ...InstallerScript::postflight(): Argument #2 ($adapter) must be of type JAdapterInstance, Joomla\CMS\Installer\Adapter\ModuleAdapter given ### Expected result Installer succeeds in J4 ### Actual result Installer fails in J4 ### Documentation Changes Required None
ggppdk added 1 commit 6 months ago
Owner

Noted, and is helpful.

Yet since the installer script is compiler build, we need to adapt the compiler and let it update the script.php on the next build.

Since I know the install script needs lots of love going to J4.

For example:

  • removal/update of all the (unpdate and removal) script to the assets table
  • removal of all history related database integration (must be moved to a plugin)

So we need to change this area in a big way, and is one of the major release blockers going to J4

Yet none of these changes is only JCB related, as JCB itself is build with itself, if we make these changes in the compiler it will immediately effect all extensions build with it.

That said we are working on refactoring the compiler and all changes like these must waite untill that is completed.

Noted, and is helpful. Yet since the installer script is **compiler** build, we need to adapt the compiler and let it update the script.php on the next build. Since I know the install script needs lots of love going to J4. For example: - removal/update of all the (unpdate and removal) script to the assets table - removal of all history related database integration (must be moved to a plugin) So we need to change this area in a big way, and is one of the major release blockers going to J4 Yet none of these changes is only JCB related, as JCB itself is build with itself, if we make these changes in the compiler it will immediately effect all extensions build with it. That said we are working on [refactoring the compiler](https://git.vdm.dev/joomla/Component-Builder/milestone/92) and all changes like these must waite untill that is completed.
Poster

Hello, this change should be 100% compatible and should not break anything, as it simply removes the type from the parameters. With this change i able to compile a single package for modules and plugins that is installable in both J3 and J4

Hello, this change should be 100% compatible and should not break anything, as it simply removes the type from the parameters. With this change i able to compile a single package for modules and plugins that is installable in both J3 and J4
Llewellyn merged commit 154cd5ae1e into staging 6 months ago
Llewellyn deleted branch j4_installer_compatibility 6 months ago
Owner

I would like to see GPG signed commits in the future 👍

I have merged this in favor modules and plugins, but note that this does not yet effect components directly.

I would like to see [GPG signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) commits in the future 👍 I have merged this in favor modules and plugins, but note that this does not **yet effect** components directly.
The pull request has been merged as 154cd5ae1e.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#949
Loading…
There is no content yet.