Remove specific type for adapter parameter from all installer methods
MergedLlewellyn merged 1 commits from
staging10 months ago
Reference in New Issue
There is no content yet.
Delete Branch 'ggppdk/Component-Builder:j4_installer_compatibility'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Summary of Changes
Remove type for $adapter parameter for methods in Installer script
Try installing in J4,
You get error
...InstallerScript::postflight(): Argument #2 ($adapter) must be of type JAdapterInstance, Joomla\CMS\Installer\Adapter\ModuleAdapter given
Installer succeeds in J4
Installer fails in J4
Documentation Changes Required
Noted, and is helpful.
Yet since the installer script is compiler build, we need to adapt the compiler and let it update the script.php on the next build.
Since I know the install script needs lots of love going to J4.
So we need to change this area in a big way, and is one of the major release blockers going to J4
Yet none of these changes is only JCB related, as JCB itself is build with itself, if we make these changes in the compiler it will immediately effect all extensions build with it.
That said we are working on refactoring the compiler and all changes like these must waite untill that is completed.
Hello, this change should be 100% compatible and should not break anything, as it simply removes the type from the parameters. With this change i able to compile a single package for modules and plugins that is installable in both J3 and J4
154cd5ae1einto staging 10 months ago
I would like to see GPG signed commits in the future 👍
I have merged this in favor modules and plugins, but note that this does not yet effect components directly.
Step 1:From your project repository, check out a new branch and test the changes.
Step 2:Merge the changes and update on Gitea.