29
0
mirror of https://github.com/joomla/joomla-cms.git synced 2024-06-27 07:33:41 +00:00
Commit Graph

12859 Commits

Author SHA1 Message Date
Hannes Papenberg
deae2f0dea
Atom Feed: Prevent notice from empty description (#42670) 2024-01-19 15:42:14 +01:00
Irata
6da6c6dbcf
[4.4] Fix missing 'separator' lines between sub menus in Admin Components (#42588)
* Implement the ability to have 'separator' lines between sub menu items of a component in the Components menu of the Admin area.

* Add ability to provide alias value to support multiple sub menu separators.

---------
2024-01-14 23:44:27 +01:00
Richard Fath
59eeabadad
Fix parameter type for whereIn query (#42638) 2024-01-10 19:22:31 +01:00
Stefan Bauer
9839f6dca8
Update SiteRouter.php - check $force_ssl non type safe (#42615)
* Update SiteRouter.php - check $force_ssl non type safe

### Summary of Changes
When updateing joomla from joomla 3 to joomla 4.4 the value in cofiguration.php is still saved with `public $force_ssl = '2'` instead of `public $force_ssl = 2`. If set as string, the force_ssl setting has no effect, the redirection to https is not working.

Furthermore, the cli command '/cli/joomla.php config:set force_ssl=2' also sets the configuration.php to `public $force_ssl = '2'`.

The change should have no further effect, everywhere else in the code force_ssl is checked non type-safe.


### Testing Instructions
Joomla 4.4.1
Run '/cli/joomla.php config:set force_ssl=2' and you will get `public $force_ssl = '2';` in configuration.php


### Actual result BEFORE applying this Pull Request
redirection to https is not wotking, site loads with http://...


### Expected result AFTER applying this Pull Request
Force SSL ist working, when opening with http://... the site is redirected to https://...


### Link to documentations
Please select:
- [ ] Documentation link for docs.joomla.org: <link>
- [x] No documentation changes for docs.joomla.org needed

- [ ] Pull Request link for manual.joomla.org: <link>
- [x] No documentation changes for manual.joomla.org needed

* Update libraries/src/Router/SiteRouter.php

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

---------
2024-01-10 18:16:20 +01:00
Christian Heel
14a1ad4279
[4.4] check for valid referrer (#42599) 2024-01-10 12:48:30 +01:00
Martin Kopp
26cf45c21c
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2024-01-09 16:51:01 +01:00
Martin Kopp
f5c559ee01
Joomla! 4.4.2 Stable 2024-01-05 11:49:39 +01:00
Martin Kopp
56221633dc
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2024-01-03 15:34:48 +01:00
Martin Kopp
a31a19c007
Joomla! 4.4.2 Rc 1 2024-01-03 15:00:20 +01:00
Richard Fath
80751a6b4a
[4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576)
* Use concat of columns for getting core extensions

* Fix PHPCS

* Remove wrong quotes
2023-12-31 13:45:13 +01:00
Richard Fath
e125943d68
Better message on package uninstallation (#42570)
Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .
2023-12-27 12:26:35 +01:00
George Wilson
58ccc936d2
Fixes to form validation process (#42560)
Fixes hardening measure introduced in https://github.com/joomla/joomla-cms/pull/23716
2023-12-23 17:52:04 +01:00
Richard Fath
1b4fea43a7
[4.4] Add information about reasons to Joomla Update when an update was found which doesn't fulfil PHP or DB requirements (#42489)
* Add information on reasons if no suitable update was found

* Change technical requirements link

* PHP CS

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Apply suggestion from code review

Co-authored-by: Quy <quy@nomonkeybiz.com>

* Better English (1)

Co-authored-by: Brian Teeman <brian@teeman.net>

* Better English (2)

Co-authored-by: Brian Teeman <brian@teeman.net>

---------
2023-12-20 10:47:09 +01:00
Elfangor
291c565135
[4.4] File::delete() throws error and terminates installation/update/uninstall (#42533)
* fix issue by checking if is_file()

Before calling File::delete(), the file path gets checked for existence with the PHP build in function is_file(). Only if the provided path is an existing file, it gets deleted using File::delete().

* remove \ for consistency
2023-12-19 09:25:42 +01:00
Denitz
c4260cb6f9
[4.4] json_decode of NULL in InstallerScript::getItemArray() (#40527)
* json_decode of NULL

* Check for name in Installer Script
2023-12-07 16:05:04 +01:00
Martin Kopp
1354da155f
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2023-11-28 15:47:16 +01:00
Martin Kopp
4ee38101e1
Joomla! 4.4.1 Stable 2023-11-23 11:16:58 +01:00
Martin Kopp
ac9aa34077
Joomla! 4.4.1 Rc 2 2023-11-23 10:57:58 +01:00
Martin Kopp
b7c1fc9cd3
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2023-11-18 15:45:27 +01:00
Martin Kopp
16681afbd4
Joomla! 4.4.1 Rc 1 2023-11-18 15:26:09 +01:00
Fedir Zinchuk
0b6137699f
Fix a bug of web assets file joomla.asset.json registration/parsing (#41431)
* Make sure that all registry files parsed

* Make sure that all registry files parsed

---------
2023-11-16 13:05:42 +01:00
Fedir Zinchuk
874f23122d
Text::script should update existing script strings (#41543)
* Text::script should update existing script strings

* Text::script should update existing script strings

* comment
2023-11-15 10:34:55 +01:00
Octavian Cinciu
fa832ac9db
Fix multi-factor migration when updating from J3 to J4 (#42253)
* Update MultiFactorAuthenticationHandler.php

* Remove unuised MfaTable

---------
2023-11-05 15:46:58 +01:00
Sven Schultschik
6ad3c41071
fix #42191 Unknown column 'id' in 'field list' (#42199)
In this method it tries to load the field 'id' from the extensions table. But there isn't any field called id in this table. The id field for the extenions table is called extension_id
2023-11-03 14:05:15 +01:00
kochinc
3b13b2433b
[4.4] Proposed fix for Workflow transition error (#42036)
* Update UsersModel.php for 'GROUP BY' fix

* Update administrator/components/com_users/src/Model/UsersModel.php

Conform to coding style

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

* Update Workflow.php for issue #42031

Proposed fix for the reported error at #42031:
An error has occurred.
42601 42601, 7, ERROR: syntax error at or near "WHERE" LINE 5: WHERE "t"."id" = $1 AND "t"."workflow_id" = "w"."id" AND "t"... ^

* Revised update Workflow.php for #42031

Corrected join() call.

* Update Workflow.php for code style

Remove a space which caused phpcs complained.

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
2023-10-30 22:27:09 +01:00
Martin Kopp
04c9945ae6
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2023-10-17 18:06:33 +02:00
Martin Kopp
874cf40178
Joomla! 4.4.0 Stable 2023-10-14 14:42:04 +02:00
Martin Kopp
cb0a826a79
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2023-10-03 18:01:23 +02:00
Martin Kopp
4b89519792
Joomla! 4.4.0 Rc 1 2023-10-03 13:36:15 +02:00
Fedir Zinchuk
b9561c3916
Fix deprecated null, in ModuleAdapter (#41617)
Co-authored-by: Quy <quy@nomonkeybiz.com>
2023-09-28 19:46:01 +02:00
Martin Kopp
f6b96f96cc
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2023-09-26 18:00:51 +02:00
Martin Kopp
fdfd7041a2
Joomla! 4.4.0 Beta 3 2023-09-26 13:44:57 +02:00
Nicola Galgano
9b26ca286b
[4] Mismatched tag ids/tag names in articles webservice/api (#41397)
* Mismatched tag ids/tag names in articles webservice/api

* redone

* new function

* use the new helper function

* cs

---------

Co-authored-by: Martin Carl Kopp <6154099+MacJoom@users.noreply.github.com>
2023-09-25 19:42:41 +02:00
Fedir Zinchuk
77bb5edf0c
Event argument setters use onSet callback (#41831) 2023-09-20 18:14:14 +02:00
Fedir Zinchuk
d173dfeb57
[4.4][RFC] Rename Event pre-processing methods from set/get to onSet/onGet (#41722)
* Rename Event pre-processing events from set/get to onSet/onGet

* Apply suggestions from code review

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
2023-09-20 17:19:32 +02:00
Elisa Foltyn
60c0bb46b1
Update HtmlView.php (#41274)
Fix like suggested in https://github.com/joomla/joomla-cms/issues/41270#issuecomment-1655905244
2023-09-20 16:06:40 +02:00
George Wilson
487dedba55
[4.4] Add model exception for components to start using (#41809) 2023-09-20 11:21:37 +02:00
Martin Kopp
2efbdfe70b
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2023-09-19 18:00:10 +02:00
Martin Kopp
116ad860ab
Joomla! 4.4.0 Beta 2 2023-09-19 14:47:35 +02:00
Allon Moritz
8bbe6c6f32
Merge branch '4.3-dev' into 4.4-dev 2023-09-19 10:40:48 +02:00
Denitz
6da44a9a22
PHP 8.2 Creation of dynamic property (#41554) 2023-09-18 19:34:51 -04:00
Allon Moritz
9284af9d16
Invalid import from upmerge 2023-09-18 14:27:32 +02:00
Allon Moritz
aa7c5bf768
Merge branch '4.3-dev' into 4.4-dev 2023-09-18 13:20:31 +02:00
Richard Fath
b04c168b49
[4.4] Add Joomla 5 compat plugin to 4.4.0 to fix class "JPlugin" not found error on update to 5 (#41738)
* Add J5 compat plugin to 4.4.0

* Adapt provider.php to latest changes in 5.0-dev

* Add to ExtensionsHelper

* Use protected = 0

* Better XML description.

* Use correct creationDate in XML file

Co-authored-by: Brian Teeman <brian@teeman.net>

---------

Co-authored-by: Brian Teeman <brian@teeman.net>
2023-09-13 18:00:14 +02:00
Harald Leithner
295fceefbc
[4.4] Upmerge (#41733)
* [4.3] fix localised cli installation (#41706)

* [4.3] Work around a successful upgrade with silent errors (#41367)

* Log all

* Capture errors

* Log messages

* Error collector

* Error collector

* More error collecting

* More error collecting

* Show errors

* Cli command check errors

* phpcs

* phpcs

* Back button and better text

* phpcs

* logs

* Make sure logging is working before continue

* Apply suggestions from code review

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Harald Leithner <leithner@itronic.at>

* cs

---------

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Fedir Zinchuk <getthesite@gmail.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
2023-09-13 12:17:49 +02:00
Fedir Zinchuk
666bdd3fca
[4.3] Work around a successful upgrade with silent errors (#41367)
* Log all

* Capture errors

* Log messages

* Error collector

* Error collector

* More error collecting

* More error collecting

* Show errors

* Cli command check errors

* phpcs

* phpcs

* Back button and better text

* phpcs

* logs

* Make sure logging is working before continue

* Apply suggestions from code review

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Harald Leithner <leithner@itronic.at>
2023-09-13 10:20:58 +02:00
Allon Moritz
a75867224d
Merge branch '4.3-dev' into 4.4-dev 2023-09-11 15:39:25 +02:00
Brian Teeman
61ff226552
[4.4] set_time_limit (#41523) 2023-09-08 14:18:08 +02:00
Denitz
5c8d6df69d
Update CleanCacheCommand.php (#41555) 2023-09-06 19:35:48 -04:00
Martin Kopp
7ccce2bc8b
Revert to dev
Signed-off-by: Martin Kopp <kopp05@infotech.ch>
2023-09-05 18:00:33 +02:00