To the best of my ability to search github these "spacer" were added 57c5180fb5
If you look at that PR the code was wrong and the field was never used althoough it was intended to be a spacer before a button.
That button has long since been removed and has never even been in a 3.x release
Let's stop maintaining it
When viewing a user profile on the frontend you see the text
"No information entered" on any of the basic settings that have not been changed
Far better to say "Website default" as at least that way there is no confusion to the user. In the form they "selected" the -use default - option so to their understanding they have made a selection
This pr removes the class `hasTooltip` from the buttons shown below
It is no longer being used as we have already removed the useless duplicated "bubble"
As a result of the accessibility performed last night on the Permissions page it was realised that it would be best for screen reader users to know what the changed setting is. For example if they chose "inherited" they need to know that this means that "allowed - inherited" has been selected.
The super easy way to do this is to wrap the "allowed - inherited" span in the html element output. This way whenever the output is updated it is automatically announced by the screen reader.
Technically we could remove the span and put the class on the `<output>` element but as that would require changing the javascript as well I didn;t see the need to do that. The code in this PR works perfectly without making that change
Pull Request for Issue #16788 ....same as #24675 for contacts - I really just copied the work of others (someone has to)
some datetime fields should be nullable as default
- publish_up
- publish_down
- checked_out_time
This PR fixes the bug that the burger icon should be grey when sorting is disabled. (you will need to npm to build the css to test this part)
This PR updates the markup for the title text. It removes a class that was for mootools and as its just a regular title we dont need to pass the text through a helper.
The notices and warning were displayed in a table. A table should never be used for display purposes and this is not tabular data.
This PR corrects that and puts the notices as divs
The help button on the toolbar opens in a new window. To satisfy the accessibility rules there should be both a notification of this.
After applying this PR there is a title attribute on the help button with the required text
Remove the hasTooltip class and simplify the code as we dont need to use the helper or a variable
This is for the title on the check box used to select all items in a list
An error message should always be meaningful to the user AND if possible offer a solution
This PR does two things.
1. It removes the display of the error code - thats not meaningful
2. It modifies the string to simplify it and to offer a solution
