octoleo/gh-ost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Close the binlog syncer

Browse Source
This commit is contained in:
Nikhil Mathew 2017-12-18 11:03:37 -08:00
parent ec6ceffbcb
commit e82d5633f9
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
go/binlog/gomysql_reader.go
View File

@ -158,10 +158,6 @@ func (this *GoMySQLReader) StreamEvents(canStopStreaming func() bool, entriesCha
} }
func (this *GoMySQLReader) Close() error { func (this *GoMySQLReader) Close() error {
// Historically there was a: this.binlogSyncer.Close()
// this.binlogSyncer.Close()
// here. A new go-mysql version closes the binlog syncer connection independently.
// I will go against the sacred rules of comments and just leave this here.
// This is the year 2017. Let's see what year these comments get deleted.
return nil return nil
} }