Commit Graph

1639 Commits

Author SHA1 Message Date
Tim Vaillancourt 05c7ed5f8f
Add basic test for inspector (#1166)
* Add basic test for inspector

* Add header

* Fix return
2022-09-06 15:23:18 +02:00
Tim Vaillancourt 1fa3d4f75a
Add basic tests for applier (#1165)
* Add basic tests for applier

* Add header
2022-09-06 15:06:14 +02:00
Tim Vaillancourt 3c946e97d7
Improve applier `.ReadMigrationRangeValues()` func accuracy (#1164)
* Use a transaction in applier `ReadMigrationRangeValues` func

* Private func names
2022-09-06 14:07:47 +02:00
dm-2 1a473a4f66
Merge pull request #1158 from wangzihuacool/fix-charset
Fix: Convert column value in binlog events to bytes instead of utf8 encoded unicode
2022-09-06 11:56:56 +01:00
dm-2 9c2c7bad1b
Merge branch 'master' into fix-charset 2022-09-06 11:44:07 +01:00
Abirdcfly ca8aef5d6d
chore: remove duplicate word in comments (#1175)
Signed-off-by: Abirdcfly <fp544037857@gmail.com>

Signed-off-by: Abirdcfly <fp544037857@gmail.com>
2022-08-30 23:49:13 +02:00
wangzihuacool e9cb4a233f convert to bytes if character string without charsetConversion. 2022-08-27 01:55:36 +00:00
wangzihuacool a17389e97a Some fix to unit tests. 2022-08-20 01:06:00 +08:00
Tim Vaillancourt 2ad614ab1e
Merge branch 'master' into fix-charset 2022-08-18 22:36:24 +02:00
Tim Vaillancourt 3f44e04365
Set a transaction isolation level for MySQL connections (#1156)
* Set transaction isolation in connections

* Revert load_map.go change

* Var rename

* Restore comment
2022-08-12 18:52:22 +02:00
Tim Vaillancourt 5de91c9f90
Add missing doc from PR #1131 (#1162) 2022-08-11 10:32:00 +02:00
wangzihuacool c93060e743 restore connection charset to utf8mb4 2022-08-11 13:14:38 +08:00
Tim Vaillancourt bee009b9e3
Allow zero in dates (#1161)
* Merge pull request #31 from openark/zero-date

Support zero date and zero in date, via dedicated command line flag

* Merge pull request #32 from openark/existing-date-with-zero

Support tables with existing zero dates

* Remove un-needed ignore_versions file

* Fix new lint errors from golang-ci update

Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
2022-08-10 21:50:59 +02:00
wangzihuacool 8a193e0024
delete junk files 2022-08-03 14:18:50 +08:00
wangzihuacool 113094bbd2 Convert character to bytes and insert into table using latin1 2022-08-03 11:43:18 +08:00
dm-2 7d8e4e8d3d
Merge pull request #1154 from github/fix-build-script
Only build RPM and deb packages for amd64
2022-07-20 15:31:34 +01:00
dm-2 2d3e8d998e Only build RPM and deb packages for amd64 2022-07-20 14:47:51 +01:00
Tim Vaillancourt ffe54f48ed
Enable more `golang-ci` linters (#1149) 2022-07-18 18:37:18 +02:00
Tim Vaillancourt 84dca03311
Add script and docs for linter (#1151) 2022-07-18 18:21:32 +02:00
Tim Vaillancourt f527d63c86
Move `.Kill()` func from inspector to `go/mysql` (#1148) 2022-07-11 11:02:04 +02:00
dm-2 ae02941f67
Merge pull request #1147 from timvaillancourt/rm-go-os-process-go
Remove unused `go/os/process.go`
2022-07-08 11:22:09 +01:00
dm-2 ed8c05c210
Merge branch 'master' into rm-go-os-process-go 2022-07-08 10:50:05 +01:00
dm-2 4648da15ec
Merge pull request #1134 from github/changelog-migrated-state
Add `Migrated` changelog event state
2022-07-08 10:48:40 +01:00
Tim Vaillancourt 582d4cb115
Merge branch 'master' into rm-go-os-process-go 2022-07-08 00:21:25 +02:00
Tim Vaillancourt 30c868816c Remove unused `go/os/process.go` 2022-07-08 00:19:54 +02:00
dm-2 607ea8d3a9
Merge branch 'master' into changelog-migrated-state 2022-07-07 17:01:16 +01:00
dm-2 3da9a9c015
Merge pull request #1146 from github/switch-to-term-package
Switch to golang.org/x/term; go mod vendor
2022-07-07 17:00:22 +01:00
Tim Vaillancourt 54db4174b3 Consolidate no-op states 2022-07-07 17:40:01 +02:00
Tim Vaillancourt 246800e053 Fix lint 2022-07-07 17:38:41 +02:00
dm-2 9c611bda50 switch to golang.org/x/term from deprecated golang.org/x/crypto/ssh/terminal module; go mod vendor 2022-07-07 16:38:22 +01:00
Tim Vaillancourt d6d1d3b436
Merge branch 'master' into changelog-migrated-state 2022-07-07 17:35:59 +02:00
dm-2 eee8ffe7dc
Merge pull request #1145 from timvaillancourt/golang-ci-staticcheck-linter
`golang-ci`: enable/fix `staticcheck` lint warnings
2022-07-07 16:22:49 +01:00
dm-2 f9fa4231d7
Merge branch 'master' into golang-ci-staticcheck-linter 2022-07-07 15:47:59 +01:00
dm-2 78da0d09c4
Merge pull request #1138 from github/changlog-table-comment
Changlog table comment
2022-07-07 15:47:21 +01:00
dm-2 6d5d49616f
Merge branch 'master' into golang-ci-staticcheck-linter 2022-07-07 15:46:18 +01:00
dm-2 8eb9708755
Merge branch 'master' into changlog-table-comment 2022-07-07 15:34:30 +01:00
dm-2 02258ac15d
Merge pull request #1137 from github/go-mysql-binlog-dead-code
Remove unused code in `go/mysql/binlog.go`
2022-07-07 15:07:24 +01:00
Tim Vaillancourt e45357097f cleanup v5 2022-07-07 05:10:22 +02:00
Tim Vaillancourt eead61cb6d cleanup v4 2022-07-07 05:05:37 +02:00
Tim Vaillancourt c3593c94ff cleanup v3 2022-07-07 03:27:36 +02:00
Tim Vaillancourt 0303031fc2 cleanup v2 2022-07-07 03:22:53 +02:00
Tim Vaillancourt 0ec555badf Cleanup 2022-07-07 03:19:53 +02:00
Tim Vaillancourt 500fbefdb9 `golang-ci`: fix `staticcheck` linter warnings 2022-07-07 03:12:44 +02:00
Tim Vaillancourt 09bb5caf88
Merge branch 'master' into go-mysql-binlog-dead-code 2022-07-07 00:39:24 +02:00
Andrew Mason b751499091
Cancel any row count queries before attempting to cut over (#846)
* Cancel any row count queries before attempting to cut over

Closes #830. Switches from using `QueryRow` to `QueryRowContext`, and
stores a context.CancelFunc in the migration context, which is called to
halt any running row count query before beginning the cut over.

* Make it threadsafe

* Kill the count query on the database side as well

* Explicitly grab a connection to run the count, store its connection id
* When the query context is canceled, run a `KILL QUERY ?` on that connection id

* Rewrite these to use the threadsafe functions, stop exporting the cancel func

* Update logger

* Update logger

Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-07 00:23:23 +02:00
Tim Vaillancourt 308ba7f915
Default to `go1.17.11` (#1136)
* Default to go1.17.11

* `go mod vendor`

Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-07 00:05:23 +02:00
Tim Vaillancourt 0918bab29b
Add context/timeout to HTTP throttle check (#1131)
* Add context/timeout to HTTP throttle check

* Dont run `.GetThrottleHTTPInterval()` on every loop

* Update help message

* Var rename

* 2022

* Add timeout flag

* Add unix/tcp server commands, use ParseInt() for string->int64

* Var rename

* Re-check http timeout on every loop iteration

* Remove stale comment

* Make throttle interval idempotent

* var rename

* Usage grammar

* Make http timeout idempotent too

* Parse time.Duration once

* Move timeout to NewThrottler

* Help update

* Set User-Agent header

* Re-add newline

Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-06 23:56:07 +02:00
Tim Vaillancourt 0b066c16a5
Use `switch` statements for readability, simplify `.NewGoMySQLReader()` (#1135)
* Use `switch` statements for readability

* Simplify initBinlogReader()
2022-07-06 23:45:26 +02:00
Tim Vaillancourt 6bf32f2015
Ensure mysql rows responses are closed (#1132)
Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
2022-07-06 23:32:15 +02:00
Shlomi Noach cc38a17e50
compound pk tests (#387)
* compound pk tests

* more details in failure diff

* more elaborate test; the pk-ts one consistently fails

* Fix merge conflict

Co-authored-by: Shlomi Noach <shlomi-noach@github.com>
Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
2022-07-06 23:22:21 +02:00