octoleo/gh-ost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,329 Commits 51 Branches 51 Tags 24 MiB
61de098072
Commit Graph

1329 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andrew Mason
61de098072 Add a check to rows.Err after processing all rows 
Closes #822.

In https://github.com/go-sql-driver/mysql/issues/1075, @acharis notes
that the way the go-sql driver is written, query timeout errors don't
get set in `rows.Err()` until _after_ a call to `rows.Next()` is made.

Because this kind of error means there will be no rows in the result
set, the `for rows.Next()` will never enter the for loop, so we must
check the value of `rows.Err()` after the loop, and surface the error up
appropriately.
 2020-03-31 16:25:16 -04:00
Justin Fudally
4dab06e92b
Merge pull request #833 from github/jfudally-throttle-fix 
Throttle on HTTP throttle error
 2020-03-30 14:38:56 -05:00
Justin Fudally
2178b5947b remove spammy error 2020-03-30 10:05:23 -05:00
Justin Fudally
5816ede7b3 add error message 2020-03-30 09:55:49 -05:00
Justin Fudally
7893f8e1c3 catch error in collectFunc 2020-03-30 09:53:10 -05:00
Justin Fudally
df60fa4204 add error logging 2020-03-25 16:06:17 -05:00
Justin Fudally
57cf5f3c90 add override to ignore http errors 2020-03-25 15:58:32 -05:00
Justin Fudally
46dabd338b go fmt 2020-03-25 15:48:19 -05:00
Justin Fudally
d31f3aac0c Add CLI flag for ignoring http errors 2020-03-25 15:47:56 -05:00
Justin Fudally
ca0b822a3d Add comment 2020-03-25 15:41:23 -05:00
Justin Fudally
64083e4705 Throttle on no metrics/error 2020-03-25 15:40:09 -05:00
Justin Fudally
0b2702bf53 Throttle on no metrics/error 2020-03-25 14:12:00 -05:00
Justin Fudally
d5a7e43266 update gitignore 2020-03-24 14:54:54 -05:00
Shlomi Noach
78dda8ae24
Merge pull request #455 from github/test-latin1text 
latin1 tests with TEXT columns
 2020-02-16 06:47:37 +02:00
Shlomi Noach
eaa1839a9b
Merge branch 'master' into test-latin1text 2020-02-15 09:27:10 +02:00
Shlomi Noach
5ce00ef161
Merge pull request #655 from github/tests-varbinary 
Adding binary/varbinary tests
 2020-02-15 09:26:26 +02:00
Shlomi Noach
30e2512b39
Merge branch 'master' into test-latin1text 2020-02-15 08:33:25 +02:00
Shlomi Noach
ef5cbed0ec
Merge branch 'master' into tests-varbinary 2020-02-15 08:33:12 +02:00
Shlomi Noach
86d8cf4948
Merge pull request #692 from github/bigint-change-nullable 
Testing nullable int
 2020-02-15 08:32:55 +02:00
Shlomi Noach
4fd4be1308
Merge branch 'master' into tests-varbinary 2020-02-14 09:03:38 +02:00
Shlomi Noach
3cc41e24a8
Merge branch 'master' into test-latin1text 2020-02-14 09:02:53 +02:00
Shlomi Noach
6894916516
Merge branch 'master' into bigint-change-nullable 2020-02-14 09:00:05 +02:00
Shlomi Noach
c6eb8db163 Merge pull request #820 from github/dock-build 
Adding script/dock: simplifying testing/packaging
 2020-02-10 09:04:54 +02:00
Shlomi Noach
85a285a9e4 cleanup 2020-02-10 08:59:44 +02:00
Shlomi Noach
f6ea377a4b Dockerfile.packaging 2020-02-09 16:11:50 +02:00
Shlomi Noach
40953fe82f Adding script/dock: simplifying testing/packaging 2020-02-09 16:11:34 +02:00
Shlomi Noach
8bdf2d2dbd Adding script/dock: simplifying testing/packaging 2020-02-09 16:11:19 +02:00
Shlomi Noach
05b4ac08b2 Release v1.0.49 2020-02-09 11:43:19 +02:00
Shlomi Noach
5bffec3412
Merge pull request #818 from github/replica-tests-8-0 
Replication tests: MySQL 8.0
 2020-02-05 11:09:06 +02:00
Shlomi Noach
c30e5862f7 8.0 is on master now 2020-02-05 10:43:08 +02:00
Shlomi Noach
4f827a271e 8.0 is on master now 2020-02-05 10:42:36 +02:00
Shlomi Noach
a6d0d5ca26 not null for unique key test 2020-02-05 10:12:29 +02:00
Shlomi Noach
b0f487ea61 create user 2020-02-05 10:07:14 +02:00
Shlomi Noach
9201b9bc04 fetch and checkout from git path 2020-02-05 09:54:07 +02:00
Shlomi Noach
3528d67550 fetch the correct branch. Oh and removing travis 2020-02-05 09:51:40 +02:00
Shlomi Noach
919647cbbc removing travis 2020-02-05 09:50:34 +02:00
Shlomi Noach
14674274dc Experiment with https://github.com/github/gh-ost-ci-env/pull/8 2020-02-05 09:48:55 +02:00
Shlomi Noach
9af130d931 Replication tests on 8.0 2020-02-05 09:46:35 +02:00
Shlomi Noach
ea339b6023
Merge pull request #805 from knepe/update-rds-docs 
Update rds docs
 2019-12-16 06:51:07 +02:00
Tobias Johansson
19215b2688 Update rds docs 2019-12-10 13:57:18 +01:00
Shlomi Noach
7c9c2b3f43
Merge pull request #795 from mohitm15/master 
Update command-line-flags.md
 2019-11-05 10:57:50 +02:00
Mohit Maroliya
859800079b
Update doc/command-line-flags.md 
Thank you for the suggestion @shlomi-noach

Co-Authored-By: Shlomi Noach <shlomi-noach@github.com>
 2019-10-31 20:13:54 +05:30
Mohit Maroliya
991cdc51f0
Update command-line-flags.md 2019-10-31 19:28:54 +05:30
Shlomi Noach
af43fbd52f
Merge pull request #788 from github/context-status 
context, status and hooks: progressPct and CurrentLag
 2019-10-30 08:03:24 +02:00
Shlomi Noach
d0ce7c014e truncate lag digits 2019-10-23 10:18:56 +03:00
Shlomi Noach
21e7ec6b7c lag: %+vs notation, e.g. 1s 2019-10-07 07:06:11 +03:00
Shlomi Noach
271c7274a3 refactor progressPct into migrationContext 2019-10-07 06:59:56 +03:00
Shlomi Noach
8893b2207b documenting new hook env variables 2019-10-06 17:12:20 +03:00
Shlomi Noach
7869889988 context, status and hooks: progressPct and CurrentLag 2019-10-06 17:08:35 +03:00
Shlomi Noach
dcc3e90f29
Merge pull request #778 from github/ci-build-pipelines 
CI: adapting to internal builds system
 2019-08-15 11:25:11 +03:00