Commit Graph

1211 Commits

Author SHA1 Message Date
Shlomi Noach
79ddcecb1f
Merge pull request #696 from wcurrie/patch-1
Add Why Is "Connect to Replica" mode preferred?
2019-01-28 08:28:48 +02:00
Shlomi Noach
7ffcca0a2a
Merge branch 'master' into patch-1 2019-01-28 08:28:09 +02:00
Shlomi Noach
0d773f7b3d
Merge pull request #701 from github/gh-ost/patch-1
inspect: remove redundant join conditions
2019-01-28 08:26:34 +02:00
Shlomi Noach
93b88e262a
Auto-merged master into gh-ost/patch-1 on deployment 2019-01-23 08:13:55 +02:00
Shlomi Noach
e48844de0b
Merge pull request #578 from MOON-CLJ/minor_changes
minor changes and typo correction
2019-01-23 08:13:04 +02:00
twotwotwo
afa108f8fa
inspect: remove redundant join conditions
The TABLE_SCHEMA and TABLE_NAME are already guaranteed to have the same value in COLUMNS and UNIQUES because of the WHEREs in each query. Dropping it from the ON clause makes it complete much faster.

On (at least) MySQL 5.6 installs with thousands of tables, this query completes in a few seconds without the additional join conditions, but takes more than a minute with it.
2019-01-22 12:26:55 -08:00
Will Currie
5eec741327
Add Why Is "Connect to Replica" mode preferred? 2019-01-16 06:28:05 +11:00
Shlomi Noach
d32304520c
Merge branch 'master' into minor_changes 2019-01-14 10:45:27 +02:00
Shlomi Noach
d5c374a7c9
Merge pull request #684 from github/test-decimal
Fixed DECIMAL datatype
2019-01-13 13:05:48 +02:00
Shlomi Noach
7e0bdbe72a old timestamp, old datetime 2019-01-01 12:28:34 +02:00
Shlomi Noach
7c17cee010 reverting some changes 2019-01-01 11:47:41 +02:00
Shlomi Noach
0be91ba0f2 trying something... 2019-01-01 11:39:43 +02:00
Shlomi Noach
f25d0b1a3c applying datetime patch 2019-01-01 11:02:27 +02:00
Shlomi Noach
14e396ed73 updated go-mysql 2019-01-01 10:58:12 +02:00
Shlomi Noach
255314927d Updated go-mysql library, now with fix to decimal. May break datetime 2019-01-01 10:57:46 +02:00
Shlomi Noach
ffd8fa0ea8
Merge branch 'master' into test-decimal 2019-01-01 10:44:32 +02:00
Shlomi Noach
6a94f65b2f
Merge pull request #633 from heng4fun/master
Support database with underscore
2018-12-25 08:59:08 +02:00
Shlomi Noach
419794e16d
Merge branch 'master' into master 2018-12-25 07:20:47 +02:00
Shlomi Noach
17233fc6b0
Merge pull request #661 from esnunes/fix-inspector-column-types
Fix inspector column types
2018-12-16 11:14:27 +02:00
Shlomi Noach
179a3c2fc4
Merge branch 'master' into fix-inspector-column-types 2018-12-16 10:28:28 +02:00
Shlomi Noach
8245b23b6f
Merge pull request #689 from ClareCat/update_docs_throttle_http_flags
Update docs to include info about throttle-HTTP and some undocumented flags
2018-12-16 10:28:10 +02:00
Shlomi Noach
9e6b7ffc43
Merge branch 'master' into update_docs_throttle_http_flags 2018-12-16 09:22:25 +02:00
Shlomi Noach
034d9e43b8
Merge pull request #648 from github/ggunson-shared-key-docs
Draft rewrite of shared key page
2018-12-16 09:21:54 +02:00
Shlomi Noach
432e83e196 lower case arg name 2018-12-16 07:48:20 +02:00
ClareCat
d5aab8e03d
Add missing quotes 2018-12-13 20:26:51 -08:00
ClareCat
2c48be107c
Update command-line-flags 2018-12-13 20:25:04 -08:00
ClareCat
96d00d470e
Update throttle.md to describe --throttle-HTTP 2018-12-13 19:31:36 -08:00
Gillian Gunson
44db643d4f
Merge branch 'master' into ggunson-shared-key-docs 2018-12-13 15:42:47 -08:00
黄恒
29e3d48c36
Merge branch 'master' into master 2018-12-11 13:12:47 +08:00
Shlomi Noach
736696fb6c
Merge branch 'master' into fix-inspector-column-types 2018-11-29 08:35:52 +02:00
Shlomi Noach
6f673fa627
Merge branch 'master' into test-decimal 2018-11-28 10:20:07 +02:00
Shlomi Noach
00f5044f4f Testing DECIMAL datatype 2018-11-28 10:19:28 +02:00
Shlomi Noach
49270ee577
Merge pull request #680 from github/test-convert-utf8mb4
testing: convert to character set utf8mb4
2018-11-21 12:15:35 +02:00
Shlomi Noach
a7aa4eb2c0 adding latin1 2018-11-20 19:48:59 +02:00
Shlomi Noach
5d4d1cd31b more interesting sample data 2018-11-20 19:37:51 +02:00
Shlomi Noach
13b17b93c4 testing: convert to character set utf8mb4 2018-11-20 19:35:03 +02:00
Shlomi Noach
ebba4f46a3
Merge branch 'master' into fix-inspector-column-types 2018-11-13 07:55:24 +02:00
Shlomi Noach
2d9d602729
Merge pull request #663 from jrgm/fix-sha256-go-darwin
Correct the go SHA used in script/ensure-go-installed for Darwin
2018-11-11 09:04:08 +01:00
Eduardo Nunes
7e934518a5
Merge branch 'master' into fix-inspector-column-types 2018-11-05 09:59:55 +01:00
John Morrison
f98ef18278 Correct the go SHA used in script/ensure-go-installed 2018-11-01 22:20:18 -07:00
Shlomi Noach
bca6be2343
Merge pull request #659 from github/test-bit-support
BIT datatype tests
2018-11-01 15:44:48 +02:00
Eduardo Nunes
5f15f8a539 Remove not needed call by grouping columnLists
There is no need to call `applyColumnTypes` more than once for the same
`databaseName` and `tableName`, it is just move the additional
`columnList` to the first call.
2018-11-01 14:43:57 +01:00
Eduardo Nunes
dfc8aa28f4 Ignore not available columns when applying column types
The given `columnLists` may not contain all columns available in the
given table. This patch prevents the code to fail. Before this patch the
code was panicking whenever it was trying to set a value into a `nil`
object, e.g. `columnList.GetColumn('non-existant').Type = SomeType`.

For some reason the application was not completely failing but as a
side-effect any column after the non-existant column would never get its
Type properly set.
2018-11-01 14:33:11 +01:00
Shlomi Noach
c32823c10a BIT datatype tests 2018-11-01 15:27:28 +02:00
Shlomi Noach
32f2b063d8
Merge pull request #652 from HaraldNordgren/go_versions
thank you
2018-10-21 14:25:42 +03:00
Harald Nordgren
967baf9e3c Bump Travis versions 2018-10-21 13:06:58 +02:00
Gillian Gunson
a93fccdd06
Merge branch 'master' into ggunson-shared-key-docs 2018-10-16 15:14:38 -07:00
Shlomi Noach
f41df8e609 v1.0.47 2018-10-16 11:50:37 +03:00
Shlomi Noach
0c37a6daee
Merge pull request #651 from github/test-throttle-file
localtests support throttle flag file
2018-10-16 11:42:37 +03:00
Shlomi Noach
02602302a0 more attempts at session time zone 2018-10-16 11:25:46 +03:00